From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B01D2C3A589 for ; Thu, 15 Aug 2019 13:40:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 82AEB206C1 for ; Thu, 15 Aug 2019 13:40:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732403AbfHONkT convert rfc822-to-8bit (ORCPT ); Thu, 15 Aug 2019 09:40:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54306 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732267AbfHONkT (ORCPT ); Thu, 15 Aug 2019 09:40:19 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E79D43023087; Thu, 15 Aug 2019 13:40:18 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-120-255.rdu2.redhat.com [10.10.120.255]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7CB3D837BA; Thu, 15 Aug 2019 13:40:17 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: To: Joe Perches Cc: dhowells@redhat.com, Nathan Chancellor , Nick Desaulniers , Nathan Huckleberry , linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] afs: Move comments after /* fallthrough */ MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <12307.1565876416.1@warthog.procyon.org.uk> Content-Transfer-Encoding: 8BIT Date: Thu, 15 Aug 2019 14:40:16 +0100 Message-ID: <12308.1565876416@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Thu, 15 Aug 2019 13:40:19 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Joe Perches wrote: > Make the code a bit easier for a script to appropriately convert > case statement blocks with /* fallthrough */ comments to a macro by > moving comments describing the next case block to the case statement. This doesn't sound good. Can you give an illustration of what a resulting case might look like? Say taking the following as an example: > @@ -282,10 +282,8 @@ static int afs_deliver_cb_callback(struct afs_call *call) > case 0: > afs_extract_to_tmp(call); > call->unmarshall++; > - > - /* extract the FID array and its count in two steps */ > /* fall through */ > - case 1: > + case 1: /* extract the FID array and its count in two steps */ > _debug("extract FID count"); > ret = afs_extract_data(call, true); > if (ret < 0) David