From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759994AbZBXVgB (ORCPT ); Tue, 24 Feb 2009 16:36:01 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752931AbZBXVft (ORCPT ); Tue, 24 Feb 2009 16:35:49 -0500 Received: from casper.infradead.org ([85.118.1.10]:38186 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751863AbZBXVfs (ORCPT ); Tue, 24 Feb 2009 16:35:48 -0500 Subject: Re: [rtc-linux] [PATCH/RFC 0/5] Generic RTC class driver From: David Woodhouse To: Geert Uytterhoeven Cc: Alessandro Zummo , rtc-linux@googlegroups.com, Richard Zidlicky , linux-parisc@vger.kernel.org, Linux Kernel Development , David@ozlabs.org, Kyle McMartin , Linux/PPC Development , Linux/m68k , Benjamin Herrenschmidt In-Reply-To: References: <1235144809-32468-1-git-send-email-Geert.Uytterhoeven@sonycom.com> <20090220170454.04382e9e@i1501.lan.towertech.it> Content-Type: text/plain Date: Wed, 25 Feb 2009 06:35:27 +0900 Message-Id: <1235511327.18632.73.camel@macbook.infradead.org> Mime-Version: 1.0 X-Mailer: Evolution 2.24.4 (2.24.4-1.fc10) Content-Transfer-Encoding: 7bit X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2009-02-23 at 13:34 +0100, Geert Uytterhoeven wrote: > > my opinion on this kind of stuff is that I want to avoid the layering > > of implementations under the rtc subsystem. I'd rather prefer that each > > rtc device had its own driver. > > > > I've made error in the past, by accepting such kind of drivers, and > > would like to avoid that it happens again. > > So you want us to kill the ppc_md.[gs]et_rtc_time() [ppc], mach_hwclk() [m68k], > mach_gettod() [m68knommu] (and probably a few other) abstractions, and move all > RTC code out of arch/ into seperate drivers under drivers/rtc/ instead? That's the ideal... although did we get NTP sync working again yet? The rtc-ppc driver was intended as a short-term workaround so that we can enable the generic RTC class (which was required for PA Semi Electra, iirc), and still have stuff work on other platforms. -- David Woodhouse Open Source Technology Centre David.Woodhouse@intel.com Intel Corporation