From: Johannes Berg <johannes@sipsolutions.net>
To: Bob Copeland <me@bobcopeland.com>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Kernel Testers List <kernel-testers@vger.kernel.org>,
"Sergey S. Kostyliov" <rathamahata@gmail.com>,
Felix Fietkau <nbd@openwrt.org>
Subject: Re: [Bug #12490] ath5k related kernel panic in 2.6.29-rc1
Date: Wed, 08 Apr 2009 02:54:32 +0200 [thread overview]
Message-ID: <1239152072.8456.39.camel@johannes.local> (raw)
In-Reply-To: <20090408004644.GB28096@hash.localnet>
[-- Attachment #1: Type: text/plain, Size: 1498 bytes --]
On Tue, 2009-04-07 at 20:46 -0400, Bob Copeland wrote:
> On Tue, Apr 07, 2009 at 12:03:45PM +0200, Johannes Berg wrote:
> >
> > > Anyway here's a patch to buy some time. Johannes, would this be
> > > an acceptable band-aid for now?
> >
> > This is going to make it print two warnings for one occurrence of the
> > problem though. I'd much prefer to put something into minstrel.c to
> > catch when _it_ returns bogus values and in that case return 0, that way
> > at least the bandaid is restricted to the code it patches up.
>
> Ok, then maybe something like this?
>
> I think this covers most of the bases: if the driver is returning crap or
> the ->cb gets corrupted, it'll get caught in tx_status. If minstrel
> stuffs a -1 in the first slot for any other reason we'll get a warning
> before get_tx_rate and a hopefully valid index gets substituted.
Yeah, that looks nicer, thanks.
> diff --git a/net/mac80211/rc80211_minstrel.c b/net/mac80211/rc80211_minstrel.c
> index 3824990..1cf7152 100644
> --- a/net/mac80211/rc80211_minstrel.c
> +++ b/net/mac80211/rc80211_minstrel.c
> @@ -181,6 +181,11 @@ minstrel_tx_status(void *priv, struct ieee80211_supported_band *sband,
> if (ar[i].idx < 0)
> break;
>
> + if (WARN(ar[i].idx >= mi->n_rates,
> + "minstrel: invalid rate report %d (n=%d)\n",
> + ar[i].idx, mi->n_rates))
> + break;
It might be easier to print this in hex -- that way things like 0x6b are
more apparent?
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2009-04-08 0:55 UTC|newest]
Thread overview: 113+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-06 18:54 2.6.29-git13: Reported regressions from 2.6.28 Rafael J. Wysocki
2009-04-06 19:03 ` [Bug #12499] Problem with using bluetooth adaper connected to usb port Rafael J. Wysocki
2009-04-07 7:14 ` Marcel Holtmann
2009-04-07 7:49 ` Maciej Rutecki
2009-04-08 9:27 ` Maciej Rutecki
2009-04-07 21:13 ` Rafael J. Wysocki
2009-04-06 19:05 ` [Bug #12668] USB flash disk surprise disconnect Rafael J. Wysocki
2009-04-06 19:05 ` [Bug #12574] possible circular locking dependency detected Rafael J. Wysocki
2009-04-06 19:05 ` [Bug #12667] Badness at kernel/time/timekeeping.c:98 in pmud (timekeeping_suspended) Rafael J. Wysocki
2009-04-06 19:05 ` [Bug #12681] s2ram: fails to wake up on Acer Extensa 4220 (SMP disabled) Rafael J. Wysocki
2009-04-06 19:05 ` [Bug #12671] uvc_status_cleanup(): undefined reference to `input_unregister_device' Rafael J. Wysocki
2009-04-06 19:05 ` [Bug #12670] BUG: unable to handle kernel paging request at pin_to_kill+0x21 Rafael J. Wysocki
2009-04-07 8:11 ` Alessandro Bono
2009-04-07 21:14 ` Rafael J. Wysocki
2009-04-06 19:05 ` [Bug #12705] X200: Brightness broken since 2.6.29-rc4-58-g4c098bc Rafael J. Wysocki
2009-04-07 4:12 ` Len Brown
2009-04-07 21:16 ` Rafael J. Wysocki
[not found] ` <20090417143532.GA6195@ikn.schottelius.org>
2009-04-20 10:36 ` Nico Schottelius
2009-04-06 19:05 ` [Bug #12765] i915 VT switch with AIGLX causes X lock up Rafael J. Wysocki
2009-04-06 19:05 ` [Bug #12771] Oops in i915_gem_flush Rafael J. Wysocki
2009-04-06 19:05 ` [Bug #12778] suspend regression from 29rc5 to 29rc6 Rafael J. Wysocki
2009-04-06 19:05 ` [Bug #12867] 2.6.29-rc7 broke r8169 MAC on Thecus n2100 ARM board Rafael J. Wysocki
2009-04-06 19:05 ` [Bug #12836] 2.6.29-rc breaks STD using Intel 945 Rafael J. Wysocki
2009-04-06 19:05 ` [Bug #12809] iozone regression with 2.6.29-rc6 Rafael J. Wysocki
2009-04-06 22:05 ` Linus Torvalds
2009-04-06 22:15 ` Wu Fengguang
2009-04-06 22:20 ` Wu Fengguang
2009-04-06 22:30 ` Rafael J. Wysocki
2009-04-06 23:34 ` [stable] " Chris Wright
2009-04-06 19:05 ` [Bug #12861] Xorg fails to start "Failed to allocate space for kernel memory manager" Rafael J. Wysocki
2009-04-06 19:05 ` [Bug #12871] usb bluetooth crashes system Rafael J. Wysocki
2009-04-07 7:16 ` Marcel Holtmann
2009-04-07 21:09 ` Pavel Machek
2009-04-07 7:27 ` Pavel Machek
2009-04-06 19:05 ` [Bug #12872] pwc mmap always fails with EAGAIN Rafael J. Wysocki
2009-04-06 19:05 ` [Bug #12899] Crash in i915.ko: i915_driver_irq_handler Rafael J. Wysocki
2009-04-06 19:05 ` [Bug #12908] acpi_ex_extract_from_field -- div by zero Rafael J. Wysocki
2009-04-07 4:09 ` Len Brown
2009-04-07 11:03 ` Jiri Slaby
2009-04-06 19:05 ` [Bug #12971] "tg3 transmit timed out" when transmitting at high bitrate Rafael J. Wysocki
2009-04-06 19:05 ` [Bug #12947] r128: system hangs when X is started with DRI enabled Rafael J. Wysocki
2009-04-06 19:05 ` [Bug #12909] boot/kernel init duration regression from 2.6.28 Rafael J. Wysocki
2009-04-06 22:47 ` CaT
2011-06-25 23:59 ` boot/kernel init duration regression in 2.6.39 (was: Re: [Bug #12909] boot/kernel init duration regression from 2.6.28) CaT
2009-04-06 19:05 ` [Bug #12961] Kernel panics in early boot: IO-APIC + timer doesn't work Rafael J. Wysocki
2009-04-06 19:05 ` [Bug #12975] ata2: lots of error messages, but OS still running well Rafael J. Wysocki
2009-04-06 19:05 ` [Bug #13001] PCI-DMA: Out of IOMMU space Rafael J. Wysocki
2009-04-06 19:05 ` [Bug #12980] lockup in X.org Rafael J. Wysocki
2009-04-06 19:05 ` [Bug #13016] consistent oops from request_key in 2.6.29 Rafael J. Wysocki
2009-04-06 19:05 ` [Bug #13017] ATA bus errors on resume Rafael J. Wysocki
2009-04-06 19:05 ` [Bug #13015] pppoe over ethernet Rafael J. Wysocki
2009-04-07 3:31 ` Cyrill Gorcunov
2009-04-07 8:33 ` Detlef Tschirschky
2009-04-07 8:41 ` Cyrill Gorcunov
2009-04-07 21:23 ` Rafael J. Wysocki
2009-04-06 19:05 ` [Bug #13019] /proc/<pid>/maps offset output broken in 2.6.29 Rafael J. Wysocki
2009-04-06 23:13 ` Hugh Dickins
2009-04-07 21:22 ` Rafael J. Wysocki
2009-04-06 19:05 ` [Bug #13026] cs5536 is broken Rafael J. Wysocki
2009-04-06 21:53 ` 2.6.29-git13: Reported regressions from 2.6.28 Linus Torvalds
2009-04-06 22:34 ` Rafael J. Wysocki
2009-04-16 21:08 ` Chris Friesen
2009-04-16 21:35 ` Linus Torvalds
2009-04-20 21:22 ` Chris Friesen
2009-04-20 23:08 ` Hugh Dickins
2009-04-22 19:32 ` Chris Friesen
2009-04-07 3:56 ` Trenton D. Adams
2009-04-07 4:07 ` Linus Torvalds
2009-04-07 4:23 ` Trenton D. Adams
2009-04-07 6:24 ` Jarek Poplawski
2009-04-07 6:31 ` Trenton D. Adams
2009-04-07 6:41 ` Jarek Poplawski
2009-04-07 6:53 ` Trenton D. Adams
2009-04-07 16:16 ` Stefan Richter
2009-04-07 16:44 ` Trenton D. Adams
2009-04-07 17:10 ` 2.6.29 on MacBook 2,1 fails to reboot (was Re: 2.6.29-git13: Reported regressions from 2.6.28) Stefan Richter
2009-04-07 17:20 ` Justin Mattock
2009-04-07 18:22 ` Trenton D. Adams
2009-04-07 19:23 ` Stefan Richter
2009-04-07 20:52 ` Trenton D. Adams
2009-04-08 1:16 ` Trenton D. Adams
2009-04-08 8:00 ` Rafael J. Wysocki
[not found] ` <AsKNxFx2juN.A.cV.bGn2JB@chimera>
2009-04-06 23:03 ` [Bug #12870] 2.6.29-rc "TKIP: replay detected" regression Hugh Dickins
2009-04-07 21:28 ` Rafael J. Wysocki
[not found] ` <AsKNxFx2juN.A.0OH.0Fn2JB@chimera>
2009-04-07 2:13 ` [Bug #13018] 2.6.29 on MacBook 2,1 fails to reboot Trenton D. Adams
2009-04-07 2:14 ` Trenton D. Adams
2009-04-07 21:30 ` Rafael J. Wysocki
2009-04-07 22:00 ` Trenton D. Adams
[not found] ` <AsKNxFx2juN.A.GaD.UJn2JB@chimera>
2009-04-07 2:40 ` [Bug #12490] ath5k related kernel panic in 2.6.29-rc1 Bob Copeland
2009-04-07 10:03 ` Johannes Berg
2009-04-08 0:46 ` Bob Copeland
2009-04-08 0:54 ` Johannes Berg [this message]
2009-04-07 10:02 ` 2.6.29-git13: Reported regressions from 2.6.28 Ilpo Järvinen
2009-04-07 22:24 ` Rafael J. Wysocki
2009-04-17 16:23 ` Rolf Eike Beer
-- strict thread matches above, loose matches on Subject: below --
2009-06-07 10:02 2.6.30-rc8-git4: Reported regressions 2.6.28 -> 2.6.29 Rafael J. Wysocki
2009-06-07 10:03 ` [Bug #12490] ath5k related kernel panic in 2.6.29-rc1 Rafael J. Wysocki
2009-05-30 19:50 2.6.30-rc7-git4: Reported regressions 2.6.28 -> 2.6.29 Rafael J. Wysocki
2009-05-30 19:50 ` [Bug #12490] ath5k related kernel panic in 2.6.29-rc1 Rafael J. Wysocki
2009-05-24 19:27 2.6.30-rc7: Reported regressions 2.6.28 -> 2.6.29 Rafael J. Wysocki
2009-05-24 19:27 ` [Bug #12490] ath5k related kernel panic in 2.6.29-rc1 Rafael J. Wysocki
2009-05-16 19:58 2.6.30-rc6: Reported regressions 2.6.28 -> 2.6.29 Rafael J. Wysocki
2009-05-16 19:59 ` [Bug #12490] ath5k related kernel panic in 2.6.29-rc1 Rafael J. Wysocki
2009-04-26 9:42 2.6.30-rc3-git1: Reported regressions 2.6.28 -> 2.6.29 Rafael J. Wysocki
2009-04-26 9:42 ` [Bug #12490] ath5k related kernel panic in 2.6.29-rc1 Rafael J. Wysocki
2009-03-21 16:28 2.6.29-rc8-git5: Reported regressions from 2.6.28 Rafael J. Wysocki
2009-03-21 16:39 ` [Bug #12490] ath5k related kernel panic in 2.6.29-rc1 Rafael J. Wysocki
2009-03-14 19:01 2.6.29-rc8: Reported regressions from 2.6.28 Rafael J. Wysocki
2009-03-14 19:05 ` [Bug #12490] ath5k related kernel panic in 2.6.29-rc1 Rafael J. Wysocki
2009-03-03 19:22 2.6.29-rc6-git7: Reported regressions from 2.6.28 Rafael J. Wysocki
2009-03-03 19:25 ` [Bug #12490] ath5k related kernel panic in 2.6.29-rc1 Rafael J. Wysocki
2009-02-23 21:45 2.6.29-rc6: Reported regressions from 2.6.28 Rafael J. Wysocki
2009-02-23 21:48 ` [Bug #12490] ath5k related kernel panic in 2.6.29-rc1 Rafael J. Wysocki
2009-02-24 13:25 ` Bob Copeland
2009-02-25 22:55 ` Rafael J. Wysocki
2009-02-14 20:35 2.6.29-rc5: Reported regressions from 2.6.28 Rafael J. Wysocki
2009-02-14 20:38 ` [Bug #12490] ath5k related kernel panic in 2.6.29-rc1 Rafael J. Wysocki
2009-02-08 19:05 2.6.29-rc4: Reported regressions from 2.6.28 Rafael J. Wysocki
2009-02-08 19:21 ` [Bug #12490] ath5k related kernel panic in 2.6.29-rc1 Rafael J. Wysocki
2009-02-04 10:21 2.6.29-rc3-git6: Reported regressions from 2.6.28 Rafael J. Wysocki
2009-02-04 10:23 ` [Bug #12490] ath5k related kernel panic in 2.6.29-rc1 Rafael J. Wysocki
2009-02-06 18:48 ` Bob Copeland
2009-02-06 23:55 ` Rafael J. Wysocki
2009-01-19 21:28 2.6.29-rc2-git1: Reported regressions from 2.6.28 Rafael J. Wysocki
2009-01-19 21:32 ` [Bug #12490] ath5k related kernel panic in 2.6.29-rc1 Rafael J. Wysocki
2009-01-20 22:44 ` Bob Copeland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1239152072.8456.39.camel@johannes.local \
--to=johannes@sipsolutions.net \
--cc=kernel-testers@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=me@bobcopeland.com \
--cc=nbd@openwrt.org \
--cc=rathamahata@gmail.com \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).