From: Jens Axboe <jens.axboe@oracle.com>
To: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Cc: chris.mason@oracle.com, david@fromorbit.com, hch@infradead.org,
akpm@linux-foundation.org, jack@suse.cz,
Jens Axboe <jens.axboe@oracle.com>
Subject: [PATCH 12/13] writeback: check for registered bdi in flusher add and inode dirty
Date: Wed, 8 Apr 2009 14:00:15 +0200 [thread overview]
Message-ID: <1239192016-19857-13-git-send-email-jens.axboe@oracle.com> (raw)
In-Reply-To: <1239192016-19857-1-git-send-email-jens.axboe@oracle.com>
Also a debugging aid. We want to catch dirty inodes being added to
backing devices that don't do writeback.
Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
---
fs/fs-writeback.c | 7 +++++++
include/linux/backing-dev.h | 1 +
mm/backing-dev.c | 6 ++++++
3 files changed, 14 insertions(+), 0 deletions(-)
diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
index 7ed86a0..1d25d3a 100644
--- a/fs/fs-writeback.c
+++ b/fs/fs-writeback.c
@@ -426,6 +426,13 @@ void __mark_inode_dirty(struct inode *inode, int flags)
*/
if (!was_dirty) {
struct bdi_writeback *wb = inode_get_wb(inode);
+ struct backing_dev_info *bdi = wb->bdi;
+
+ if (bdi_cap_writeback_dirty(bdi) &&
+ !test_bit(BDI_registered, &bdi->state)) {
+ WARN_ON(1);
+ printk("bdi-%s not registered\n", bdi->name);
+ }
inode->dirtied_when = jiffies;
list_move(&inode->i_list, &wb->b_dirty);
diff --git a/include/linux/backing-dev.h b/include/linux/backing-dev.h
index a343719..c7c1ed6 100644
--- a/include/linux/backing-dev.h
+++ b/include/linux/backing-dev.h
@@ -29,6 +29,7 @@ enum bdi_state {
BDI_wblist_lock, /* bdi->wb_list now needs locking */
BDI_async_congested, /* The async (write) queue is getting full */
BDI_sync_congested, /* The sync queue is getting full */
+ BDI_registered, /* bdi_register() was done */
BDI_unused, /* Available bits start here */
};
diff --git a/mm/backing-dev.c b/mm/backing-dev.c
index f86f9cc..9d6ac11 100644
--- a/mm/backing-dev.c
+++ b/mm/backing-dev.c
@@ -485,6 +485,11 @@ static void bdi_add_one_flusher_task(struct backing_dev_info *bdi,
if (!bdi_cap_writeback_dirty(bdi))
return;
+ if (WARN_ON(!test_bit(BDI_registered, &bdi->state))) {
+ printk("bdi %p/%s is not registered!\n", bdi, bdi->name);
+ return;
+ }
+
/*
* Check with the helper whether to proceed adding a task. Will only
* abort if we two or more simultanous calls to
@@ -588,6 +593,7 @@ int bdi_register(struct backing_dev_info *bdi, struct device *parent,
bdi->dev = dev;
bdi_debug_register(bdi, dev_name(dev));
+ set_bit(BDI_registered, &bdi->state);
exit:
return ret;
--
1.6.2.2.446.gfbdc0
next prev parent reply other threads:[~2009-04-08 12:12 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-08 12:00 [PATCH 0/13] Per-bdi writeback flusher threads #3 Jens Axboe
2009-04-08 12:00 ` [PATCH 01/13] buffer: switch do_emergency_thaw() away from pdflush_operation() Jens Axboe
2009-04-08 13:03 ` Christoph Hellwig
2009-04-08 13:08 ` Jens Axboe
2009-04-08 12:00 ` [PATCH 02/13] writeback: move dirty inodes from super_block to backing_dev_info Jens Axboe
2009-04-08 12:00 ` [PATCH 03/13] writeback: switch to per-bdi threads for flushing data Jens Axboe
2009-04-08 12:00 ` [PATCH 04/13] writeback get rid of pdflush completely Jens Axboe
2009-04-08 12:00 ` [PATCH 05/13] writeback: separate the flushing state/task from the bdi Jens Axboe
2009-04-08 12:00 ` [PATCH 06/13] writeback: support > 1 flusher thread per bdi Jens Axboe
2009-04-08 12:00 ` [PATCH 07/13] writeback: include default_backing_dev_info in writeback Jens Axboe
2009-04-08 12:00 ` [PATCH 08/13] writeback: allow sleepy exit of default writeback task Jens Axboe
2009-04-08 12:00 ` [PATCH 09/13] writeback: btrfs must register its backing_devices Jens Axboe
2009-04-08 12:00 ` [PATCH 10/13] writeback: add some debug inode list counters to bdi stats Jens Axboe
2009-04-08 12:00 ` [PATCH 11/13] writeback: add name to backing_dev_info Jens Axboe
2009-04-08 12:00 ` Jens Axboe [this message]
2009-04-08 12:00 ` [PATCH 13/13] writeback: ensure consistency for generic_sync_sb_inodes() with WB_SYNC_ALL Jens Axboe
2009-04-10 3:46 ` [PATCH 0/13] Per-bdi writeback flusher threads #3 Zhang, Yanmin
2009-04-10 7:21 ` Jens Axboe
2009-04-13 3:18 ` Zhang, Yanmin
2009-04-17 13:07 ` Jens Axboe
2009-04-21 13:25 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1239192016-19857-13-git-send-email-jens.axboe@oracle.com \
--to=jens.axboe@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=chris.mason@oracle.com \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).