From: Andrew Patterson <andrew.patterson@hp.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "Mike Miller (OS Dev)" <mikem@beardog.cca.cpqcorp.net>,
Jens Axboe <jens.axboe@oracle.com>,
LKML <linux-kernel@vger.kernel.org>,
LKML-SCSI <linux-scsi@vger.kernel.org>,
mike.miller@hp.com
Subject: Re: [PATCH 1/1] cciss: resubmit export uid, model, vendor, rev to sysfs
Date: Fri, 10 Apr 2009 05:08:54 +0000 [thread overview]
Message-ID: <1239340134.19984.276.camel@grinch> (raw)
In-Reply-To: <20090409215226.8b03bc2b.akpm@linux-foundation.org>
On Thu, 2009-04-09 at 21:52 -0700, Andrew Morton wrote:
> On Tue, 7 Apr 2009 13:04:11 -0500 "Mike Miller (OS Dev)" <mikem@beardog.cca.cpqcorp.net> wrote:
>
> > Patch 1 of 1 resubmit
> >
> > cciss: add cciss driver sysfs entries
> >
> > This patch adds sysfs entries to the cciss driver needed for the
> > dm/multipath tools. A file for vendor, model, rev, and unique_id are
> > added for each logical drive under directory
> > /sys/bus/pci/devices/<dev>/ccissX/cXdY. Where X = the controller (or
> > host) number and Y is the logical drive number. A link from
> > /sys/bus/pci/devices/<dev>/ccissX/cXdY/block:cciss!cXdY to
> > /sys/block/cciss!cXdY/device is also created.
> >
> > ...
> >
> > +static ssize_t dev_show_model(struct device *dev,
> > + struct device_attribute *attr,
> > + char *buf)
> > +{
> > + drive_info_struct *drv = to_drv(dev);
> > + struct ctlr_info *h = to_hba(drv->dev.parent);
> > + char model[MODEL_LEN + 1];
> > + unsigned long flags;
> > + int ret = 0;
> > +
> > + spin_lock_irqsave(CCISS_LOCK(h->ctlr), flags);
> > + if (h->busy_configuring)
> > + ret = -EBUSY;
> > + else
> > + memcpy(model, drv->model, MODEL_LEN + 1);
> > + spin_unlock_irqrestore(CCISS_LOCK(h->ctlr), flags);
> > +
> > + if (ret)
> > + return ret;
> > + else
> > + return snprintf(buf, MODEL_LEN + 2, "%s\n", drv->model);
>
> Isn't the buffer sizing wrong here? Should be MODEL_LEN+1.
>
Don't we need space for the '\0' and the '\n'?
> > +}
> > +DEVICE_ATTR(model, S_IRUGO, dev_show_model, NULL);
> > +
> > +static ssize_t dev_show_rev(struct device *dev,
> > + struct device_attribute *attr,
> > + char *buf)
> > +{
> > + drive_info_struct *drv = to_drv(dev);
> > + struct ctlr_info *h = to_hba(drv->dev.parent);
> > + char rev[REV_LEN + 1];
> > + unsigned long flags;
> > + int ret = 0;
> > +
> > + spin_lock_irqsave(CCISS_LOCK(h->ctlr), flags);
> > + if (h->busy_configuring)
> > + ret = -EBUSY;
> > + else
> > + memcpy(rev, drv->rev, REV_LEN + 1);
> > + spin_unlock_irqrestore(CCISS_LOCK(h->ctlr), flags);
> > +
> > + if (ret)
> > + return ret;
> > + else
> > + return snprintf(buf, REV_LEN + 2, "%s\n", drv->rev);
>
> Repeated in various places.
>
> > +}
next prev parent reply other threads:[~2009-04-10 5:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-07 18:04 [PATCH 1/1] cciss: resubmit export uid, model, vendor, rev to sysfs Mike Miller (OS Dev)
2009-04-08 6:19 ` Jens Axboe
2009-04-08 8:13 ` Jens Axboe
2009-04-08 14:53 ` Mike Miller (OS Dev)
2009-04-08 12:26 ` Kay Sievers
2009-04-08 16:24 ` Andrew Patterson
2009-04-08 16:34 ` Kay Sievers
[not found] ` <1239258160.19984.217.camel@grinch>
[not found] ` <ac3eb2510904090719n730dededp54b25390a9087a79@mail.gmail.com>
[not found] ` <1239296221.19984.218.camel@grinch>
[not found] ` <ac3eb2510904091005q13e5b5a1j3907de22ad3df70c@mail.gmail.com>
2009-04-09 18:07 ` Andrew Patterson
2009-04-09 18:12 ` Kay Sievers
2009-04-10 4:52 ` Andrew Morton
2009-04-10 5:08 ` Andrew Patterson [this message]
2009-04-10 5:17 ` Andrew Morton
2009-04-10 17:19 ` Andrew Patterson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1239340134.19984.276.camel@grinch \
--to=andrew.patterson@hp.com \
--cc=akpm@linux-foundation.org \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mike.miller@hp.com \
--cc=mikem@beardog.cca.cpqcorp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).