From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71426C433B4 for ; Fri, 14 May 2021 10:58:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4A2F76144F for ; Fri, 14 May 2021 10:58:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232080AbhENK7b (ORCPT ); Fri, 14 May 2021 06:59:31 -0400 Received: from foss.arm.com ([217.140.110.172]:47334 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229973AbhENK7Z (ORCPT ); Fri, 14 May 2021 06:59:25 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BA2F51713; Fri, 14 May 2021 03:58:13 -0700 (PDT) Received: from [10.57.31.97] (unknown [10.57.31.97]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 891023F73B; Fri, 14 May 2021 03:58:12 -0700 (PDT) Subject: Re: [STABLE][PATCH 4.4] thermal/core/fair share: Lock the thermal zone while looping over instances To: Greg KH Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, daniel.lezcano@linaro.org, rui.zhang@intel.com References: <20210514104916.19975-1-lukasz.luba@arm.com> From: Lukasz Luba Message-ID: <12419f82-3efa-7587-da50-4edf7eef99e1@arm.com> Date: Fri, 14 May 2021 11:58:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/14/21 11:56 AM, Greg KH wrote: > On Fri, May 14, 2021 at 11:49:16AM +0100, Lukasz Luba wrote: >> commit fef05776eb02238dcad8d5514e666a42572c3f32 upstream. >> >> The tz->lock must be hold during the looping over the instances in that >> thermal zone. This lock was missing in the governor code since the >> beginning, so it's hard to point into a particular commit. >> >> CC: stable@vger.kernel.org # 4.4 >> Signed-off-by: Lukasz Luba >> --- >> Hi all, >> >> I've backported my patch which was sent to LKML: >> https://lore.kernel.org/linux-pm/20210422153624.6074-2-lukasz.luba@arm.com/ >> >> The upstream patch failed while applying: >> https://lore.kernel.org/stable/16206371483193@kroah.com/ >> >> This patch should apply to stable v4.4.y, on top of stable tree branch: >> linux-4.4.y which head was at: >> commit 47127fcd287c ("Linux 4.4.268") > > What about 4.9, 4.14, 4.14, and 5.4 releases? They need this fix as > well, right? s/4.14/4.19 Yes, I'm going to send them in next few hours after building and testing. Regards, Lukasz