From: "Hawkins, Nick" <nick.hawkins@hpe.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: "Verdun, Jean-Marie" <verdun@hpe.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"joel@jms.id.au" <joel@jms.id.au>,
"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 2/5] dt-bindings: i2c: Add hpe,gxp-i2c
Date: Mon, 23 Jan 2023 20:05:37 +0000 [thread overview]
Message-ID: <12428676-2923-4AAD-9963-AA701A2A5E90@hpe.com> (raw)
In-Reply-To: <d63231dd-38a7-2cf4-3433-8f28018665f6@linaro.org>
> > + hpe,sysreg:
> > + $ref: /schemas/types.yaml#/definitions/phandle
> > + description:
> > + Phandle to a global status and enable registers shared
> > + between each I2C controller instance. Each bit of the
> > + registers represents an individual I2C engine.
> But what is the purpose? What is it doing? Why I2C controller needs it?
Here is an updated to describe the registers' purpose, and function.
description:
Phandle to the global status and enable interrupt registers shared
between each I2C engine controller instance. It enables the I2C
engine controller to act as both a master or slave by being able to
arm and respond to interrupts from its engine. Each bit in the
registers represent the respective bit position.
Thank you for your feedback,
-Nick Hawkins
next prev parent reply other threads:[~2023-01-23 20:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-20 19:01 [PATCH v3 0/5] ARM: Add GXP I2C Support nick.hawkins
2023-01-20 19:01 ` [PATCH v3 1/5] i2c: hpe: Add GXP SoC I2C Controller nick.hawkins
2023-01-20 23:02 ` kernel test robot
2023-01-23 5:11 ` Joel Stanley
2023-01-23 15:41 ` Hawkins, Nick
2023-01-20 19:01 ` [PATCH v3 2/5] dt-bindings: i2c: Add hpe,gxp-i2c nick.hawkins
2023-01-22 14:02 ` Krzysztof Kozlowski
2023-01-23 20:05 ` Hawkins, Nick [this message]
2023-01-20 19:01 ` [PATCH v3 3/5] ARM: dts: hpe: Add I2C Topology nick.hawkins
2023-01-20 19:01 ` [PATCH v3 4/5] ARM: multi_v7_defconfig: add gxp i2c module nick.hawkins
2023-01-20 19:01 ` [PATCH v3 5/5] MAINTAINERS: Add HPE GXP I2C Support nick.hawkins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12428676-2923-4AAD-9963-AA701A2A5E90@hpe.com \
--to=nick.hawkins@hpe.com \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=robh+dt@kernel.org \
--cc=verdun@hpe.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).