From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752086AbbH1KWn (ORCPT ); Fri, 28 Aug 2015 06:22:43 -0400 Received: from mx0b-0016f401.pphosted.com ([67.231.156.173]:14222 "EHLO mx0b-0016f401.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751688AbbH1KWl (ORCPT ); Fri, 28 Aug 2015 06:22:41 -0400 From: Jialing Fu To: Ulf Hansson , Shawn Lin CC: linux-mmc , "linux-kernel@vger.kernel.org" Subject: RE: [RESEND PATCH] mmc: core: fix race condition in mmc_wait_data_done Thread-Topic: [RESEND PATCH] mmc: core: fix race condition in mmc_wait_data_done Thread-Index: AQHQ4T+eDZIOOfCyr0mmEOYQQpdjHZ4hNUqAgABcHoCAABAXAIAABIeA//+NdiA= Date: Fri, 28 Aug 2015 10:22:35 +0000 Message-ID: <1243788837884e859a8959cf8265125c@SC-EXCH04.marvell.com> References: <1440731589-22241-1-git-send-email-shawn.lin@rock-chips.com> <55DFD4B7.3070601@rock-chips.com> <55E02F7C.1020204@rock-chips.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.93.176.43] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2015-08-28_05:,, signatures=0 X-Proofpoint-Spam-Details: rule=inbound_notspam policy=inbound score=0 kscore.is_bulkscore=0 kscore.compositescore=1 compositescore=0.9 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 kscore.is_spamscore=0 rbsscore=0.9 spamscore=0 urlsuspectscore=0.9 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1507310000 definitions=main-1508280163 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id t7SAMmtt005838 [...] >>> Hi, ulf >>> >>> We find this bug on Intel-C3230RK platform for very small probability. >>> >>> Whereas I can easily reproduce this case if I add a mdelay(1) or >>> longer delay as Jialing did. >>> >>> This patch seems useful to me. Should we push it forward? :) >> >> >> It seems like a very good idea! >> >> Should we add a fixes tag to it? > > > That's cool, but how to add a fixes tag? > > [Fixes] mmc: core: fix race condition in mmc_wait_data_done ? :) > A fixes tag points to an old commit which introduced the bug. If we can't find one, we can add a Cc tag to "stable". Just search the git log and you will find examples. Like add one line as below? Fixes: 2220eedfd7ae ("mmc: fix async request mechanism for sequential read scenarios") Kind regards Uffe {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I