From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6966AC04AA5 for ; Mon, 15 Oct 2018 13:19:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2C86A20652 for ; Mon, 15 Oct 2018 13:19:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2C86A20652 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=siemens.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726628AbeJOVEU (ORCPT ); Mon, 15 Oct 2018 17:04:20 -0400 Received: from david.siemens.de ([192.35.17.14]:36866 "EHLO david.siemens.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726550AbeJOVET (ORCPT ); Mon, 15 Oct 2018 17:04:19 -0400 Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id w9FDIDQJ032373 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 15 Oct 2018 15:18:13 +0200 Received: from [139.25.68.37] (md1q0hnc.ad001.siemens.net [139.25.68.37] (may be forged)) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id w9FDIDFm004775; Mon, 15 Oct 2018 15:18:13 +0200 Subject: Re: [PATCH] x86/entry/32: Fix setup of CS high bits To: David Laight , Andy Lutomirski Cc: Joerg Roedel , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , X86 ML , LKML , Linux-MM , Linus Torvalds , Dave Hansen , Josh Poimboeuf , Juergen Gross , Peter Zijlstra , Borislav Petkov , Jiri Kosina , Boris Ostrovsky , Brian Gerst , Denys Vlasenko , Eduardo Valentin , Greg KH , Will Deacon , "Liguori, Anthony" , Daniel Gruss , Hugh Dickins , Kees Cook , Andrea Arcangeli References: <1531906876-13451-1-git-send-email-joro@8bytes.org> <1531906876-13451-11-git-send-email-joro@8bytes.org> <97421241-2bc4-c3f1-4128-95b3e8a230d1@siemens.com> <35a24feb-5970-aa03-acbf-53428a159ace@web.de> <406a08c7-6199-a32d-d385-c032fb4c34d6@siemens.com> From: Jan Kiszka Message-ID: <1246b176-02bf-3c04-5470-69333951263b@siemens.com> Date: Mon, 15 Oct 2018 15:18:12 +0200 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15.10.18 15:14, David Laight wrote: > From: Jan Kiszka >> Sent: 15 October 2018 14:09 > ... >>> Those fields are genuinely 16 bit. So the comment should say >>> something like "Those high bits are used for CS_FROM_ENTRY_STACK and >>> CS_FROM_USER_CR3". >> >> /* >> * The high bits of the CS dword (__csh) are used for >> * CS_FROM_ENTRY_STACK and CS_FROM_USER_CR3. Clear them in case >> * hardware didn't do this for us. >> */ > > What's a 'dword' ? :-) > > On a 32bit processor a 'word' will be 32 bits to a 'double-word' > would be 64 bits. > One of the worst names to use. That's ia32 nomenclature: a doubleword (dword) is a 32-bit value. Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux