From: MyungJoo Ham <myungjoo.ham@samsung.com>
To: 이종화 <jonghwa3.lee@samsung.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"sre@kernel.org" <sre@kernel.org>,
"dbaryshkov@gmail.com" <dbaryshkov@gmail.com>,
"dwmw2@infradead.org" <dwmw2@infradead.org>,
"anton@enomsg.org" <anton@enomsg.org>,
"pavel@ucw.cz" <pavel@ucw.cz>, 최찬우 <cw00.choi@samsung.com>
Subject: Re: [PATCH RESEND v2 03/10] power: charger-manager: Remove deprecated function, cm_notify_event().
Date: Fri, 19 Dec 2014 07:52:04 +0000 (GMT) [thread overview]
Message-ID: <1255984171.39711418975524329.JavaMail.weblogic@epmlwas08d> (raw)
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=utf-8, Size: 1082 bytes --]
>
> cm_notify_event() is introduced to get event associated with battery status
> externally, but no one had been used. Moreover it makes charger manager
> driver more complicated. This patch tries to drop the function and all data
> related to simplify the driver.
>
> Signed-off-by: Jonghwa Lee <jonghwa3.lee@samsung.com>
You are not just removing cm_notify_event() and its related.
You are hereby removing the much of software charger control
and suspend-related operations. Could you please be more specific
on why? (many of such features are to comply with operators' requirements)
(Or we may meet next Monday for some discussions :) )
> ---
> .../bindings/power_supply/charger-manager.txt | 1 -
> drivers/power/charger-manager.c | 196 +-------------------
> include/linux/power/charger-manager.h | 19 +-
> 3 files changed, 8 insertions(+), 208 deletions(-)
>
ÿôèº{.nÇ+·®+%Ëÿ±éݶ\x17¥wÿº{.nÇ+·¥{±þG«éÿ{ayº\x1dÊÚë,j\a¢f£¢·hïêÿêçz_è®\x03(éÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?¨èÚ&£ø§~á¶iOæ¬z·vØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?I¥
next reply other threads:[~2014-12-19 7:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-19 7:52 MyungJoo Ham [this message]
2014-12-19 8:32 ` [PATCH RESEND v2 03/10] power: charger-manager: Remove deprecated function, cm_notify_event() jonghwa3.lee
2014-12-20 0:16 ` Pavel Machek
-- strict thread matches above, loose matches on Subject: below --
2014-12-19 2:47 [PATCH RESEND V2 0/10] Improve charger manager driver for optimized operation Jonghwa Lee
2014-12-19 2:47 ` [PATCH RESEND v2 03/10] power: charger-manager: Remove deprecated function, cm_notify_event() Jonghwa Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1255984171.39711418975524329.JavaMail.weblogic@epmlwas08d \
--to=myungjoo.ham@samsung.com \
--cc=anton@enomsg.org \
--cc=cw00.choi@samsung.com \
--cc=dbaryshkov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=jonghwa3.lee@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).