From: Aneesh Kumar K V <aneesh.kumar@linux.ibm.com>
To: kajoljain <kjain@linux.ibm.com>,
Nageswara Sastry <rnsastry@linux.ibm.com>,
mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org,
nvdimm@lists.linux.dev, linux-kernel@vger.kernel.org,
peterz@infradead.org, dan.j.williams@intel.com,
ira.weiny@intel.com, vishal.l.verma@intel.com
Cc: santosh@fossix.org, maddy@linux.ibm.com,
atrajeev@linux.vnet.ibm.com, vaibhav@linux.ibm.com,
tglx@linutronix.de
Subject: Re: [PATCH v6 0/4] Add perf interface to expose nvdimm
Date: Fri, 25 Feb 2022 13:17:15 +0530 [thread overview]
Message-ID: <125761cdabbfeaf6615e67d087ec113408f8eb7e.camel@linux.ibm.com> (raw)
In-Reply-To: <ea6bc468-c7ae-c844-5111-8f0dc3207f89@linux.ibm.com>
On Fri, 2022-02-25 at 12:08 +0530, kajoljain wrote:
>
>
> On 2/25/22 11:25, Nageswara Sastry wrote:
> >
> >
> > On 17/02/22 10:03 pm, Kajol Jain wrote:
> > >
....
> > >
> > > Changelog
> >
> > Tested these patches with the automated tests at
> > avocado-misc-tests/perf/perf_nmem.py
> > URL:
> > https://github.com/avocado-framework-tests/avocado-misc-tests/blob/master/perf/perf_nmem.py
> >
> >
> > 1. On the system where target id and online id were different then
> > not
> > seeing value in 'cpumask' and those tests failed.
> >
> > Example:
> > Log from dmesg
> > ...
> > papr_scm ibm,persistent-memory:ibm,pmemory@44100003: Region
> > registered
> > with target node 1 and online node 0
> > ...
>
> Hi Nageswara Sastry,
> Thanks for testing the patch set. Yes you right, incase target
> node id and online node id is different, it can happen when target
> node is not online and hence can cause this issue, thanks for
> pointing
> it.
>
> Function dev_to_node will return node id for a given nvdimm device
> which
> can be offline in some scenarios. We should use numa node id return
> by
> numa_map_to_online_node function in that scenario. This function
> incase
> given node is offline, it will lookup for next closest online node
> and
> return that nodeid.
>
> Can you try with below change and see, if you are still getting this
> issue. Please let me know.
>
> diff --git a/arch/powerpc/platforms/pseries/papr_scm.c
> b/arch/powerpc/platforms/pseries/papr_scm.c
> index bdf2620db461..4dd513d7c029 100644
> --- a/arch/powerpc/platforms/pseries/papr_scm.c
> +++ b/arch/powerpc/platforms/pseries/papr_scm.c
> @@ -536,7 +536,7 @@ static void papr_scm_pmu_register(struct
> papr_scm_priv *p)
> PERF_PMU_CAP_NO_EXCLUDE;
>
> /*updating the cpumask variable */
> - nodeid = dev_to_node(&p->pdev->dev);
> + nodeid = numa_map_to_online_node(dev_to_node(&p->pdev->dev));
> nd_pmu->arch_cpumask = *cpumask_of_node(nodeid);
>
> >
Can you use p->region->numa_node?
-aneesh
next prev parent reply other threads:[~2022-02-25 7:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-17 16:33 [PATCH v6 0/4] Add perf interface to expose nvdimm Kajol Jain
2022-02-17 16:33 ` [PATCH v6 1/4] drivers/nvdimm: Add nvdimm pmu structure Kajol Jain
2022-02-17 16:33 ` [PATCH v6 2/4] drivers/nvdimm: Add perf interface to expose nvdimm performance stats Kajol Jain
2022-02-17 16:33 ` [PATCH v6 3/4] powerpc/papr_scm: Add perf interface support Kajol Jain
2022-02-17 16:33 ` [PATCH v6 4/4] docs: ABI: sysfs-bus-nvdimm: Document sysfs event format entries for nvdimm pmu Kajol Jain
2022-02-18 18:06 ` [PATCH v6 0/4] Add perf interface to expose nvdimm Dan Williams
2022-02-23 19:07 ` Dan Williams
2022-02-23 21:17 ` Dan Williams
2022-02-25 5:55 ` Nageswara Sastry
2022-02-25 6:38 ` kajoljain
2022-02-25 7:47 ` Aneesh Kumar K V [this message]
2022-02-25 8:39 ` kajoljain
2022-02-25 11:11 ` Nageswara Sastry
2022-02-25 11:23 ` kajoljain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=125761cdabbfeaf6615e67d087ec113408f8eb7e.camel@linux.ibm.com \
--to=aneesh.kumar@linux.ibm.com \
--cc=atrajeev@linux.vnet.ibm.com \
--cc=dan.j.williams@intel.com \
--cc=ira.weiny@intel.com \
--cc=kjain@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=nvdimm@lists.linux.dev \
--cc=peterz@infradead.org \
--cc=rnsastry@linux.ibm.com \
--cc=santosh@fossix.org \
--cc=tglx@linutronix.de \
--cc=vaibhav@linux.ibm.com \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).