From: Tom Rix <trix@redhat.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
airlied@linux.ie, daniel@ffwll.ch,
daniele.ceraolospurio@intel.com, jani.nikula@linux.intel.com,
joonas.lahtinen@linux.intel.com, lionel.g.landwerlin@intel.com,
rodrigo.vivi@intel.com,
tejaskumarx.surendrakumar.upadhyay@intel.com,
tvrtko.ursulin@intel.com, venkata.s.dhanalakota@intel.com
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/i915: remove h from printk format specifier
Date: Tue, 15 Dec 2020 11:00:06 -0800 [thread overview]
Message-ID: <12579dc7-603e-2fbe-85c0-0a4110b8992a@redhat.com> (raw)
In-Reply-To: <160805599050.14591.5854311082825914383@build.alporthouse.com>
On 12/15/20 10:13 AM, Chris Wilson wrote:
> Quoting trix@redhat.com (2020-12-15 14:41:01)
>> From: Tom Rix <trix@redhat.com>
>>
>> See Documentation/core-api/printk-formats.rst.
>> h should no longer be used in the format specifier for printk.
> It's understood by format_decode().
> * 'h', 'l', or 'L' for integer fields
>
> At least reference commit cbacb5ab0aa0 ("docs: printk-formats: Stop
> encouraging use of unnecessary %h[xudi] and %hh[xudi]") as to why the
> printk-formats.rst was altered so we know the code is merely in bad
> taste and not using undefined behaviour of printk.
Ok, i will fix this after the first run of patches.
Tom
> -Chris
>
prev parent reply other threads:[~2020-12-15 19:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-15 14:41 [PATCH] drm/i915: remove h from printk format specifier trix
2020-12-15 18:13 ` Chris Wilson
2020-12-15 19:00 ` Tom Rix [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12579dc7-603e-2fbe-85c0-0a4110b8992a@redhat.com \
--to=trix@redhat.com \
--cc=airlied@linux.ie \
--cc=chris@chris-wilson.co.uk \
--cc=daniel@ffwll.ch \
--cc=daniele.ceraolospurio@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lionel.g.landwerlin@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=tejaskumarx.surendrakumar.upadhyay@intel.com \
--cc=tvrtko.ursulin@intel.com \
--cc=venkata.s.dhanalakota@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).