From: Luca Weiss <luca@z3ntu.xyz>
To: Stephan Gerhold <stephan@gerhold.net>
Cc: ~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org,
"Bjorn Andersson" <andersson@kernel.org>,
"Konrad Dybcio" <konrad.dybcio@linaro.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Ulf Hansson" <ulf.hansson@linaro.org>,
"Matti Lehtimäki" <matti.lehtimaki@gmail.com>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH v2 1/3] dt-bindings: power: rpmpd: Add MSM8974 power domains
Date: Sun, 11 Feb 2024 12:19:14 +0100 [thread overview]
Message-ID: <12625470.O9o76ZdvQC@z3ntu.xyz> (raw)
In-Reply-To: <Zcipcz70vEPWLAFg@gerhold.net>
On Sonntag, 11. Februar 2024 12:03:15 CET Stephan Gerhold wrote:
> On Sat, Feb 10, 2024 at 05:38:56PM +0100, Luca Weiss wrote:
> > Add the compatibles and indexes for the rpmpd in MSM8974, both with the
> > standard PM8841+PM8941 PMICs but also devices found with PMA8084.
> >
> > Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> > ---
> >
> > Documentation/devicetree/bindings/power/qcom,rpmpd.yaml | 2 ++
> > include/dt-bindings/power/qcom-rpmpd.h | 7 +++++++
> > 2 files changed, 9 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
> > b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml index
> > 2ff246cf8b81..929b7ef9c1bc 100644
> > --- a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
> > +++ b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
> >
> > @@ -24,6 +24,8 @@ properties:
> > - qcom,msm8917-rpmpd
> > - qcom,msm8939-rpmpd
> > - qcom,msm8953-rpmpd
> >
> > + - qcom,msm8974-rpmpd
> > + - qcom,msm8974pro-pma8084-rpmpd
> >
> > - qcom,msm8976-rpmpd
> > - qcom,msm8994-rpmpd
> > - qcom,msm8996-rpmpd
>
> This is maybe more something for the DT reviewers to decide but I wonder
> if it is a bit confusing/misleading to describe one particular PMIC with
> a generic compatible, and the other with a more specific one. Perhaps it
> would be clearer to include the PMIC name in both compatibles, i.e.
> "qcom,msm8974-pm8941-rpmpd" instead of "qcom,msm8974-rpmpd".
FWIW if we'd do that it should be qcom,msm8974-pm8841-rpmpd (so pm8841 instead
of pm8941)
But also in the same vain, it was maybe a bit of a bad decision originally to
make the compatibles SoC-specific and not SoC+PMIC-specific - though in nearly
all cases this combo is fixed for a given SoC?
Anyways, I'll wait for more comments about this, I'm open to changing it
either way.
Regards
Luca
>
> The "qcom,msm8974-rpmpd" compatible could be maybe added as fallback.
> While it wouldn't be used for matching in the (Linux) driver the DT
> binding itself *is* "compatible" between the two PMICs because they both
> have the same power domain indexes.
>
> i.e.
> compatible = "qcom,msm8974-pm8941-rpmpd", "qcom,msm8974-rpmpd";
> compatible = "qcom,msm8974pro-pma8084-rpmpd", "qcom,msm8974-rpmpd";
>
> Thanks,
> Stephan
next prev parent reply other threads:[~2024-02-11 11:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-10 16:38 [PATCH v2 0/3] Add RPMPD support for MSM8974 Luca Weiss
2024-02-10 16:38 ` [PATCH v2 1/3] dt-bindings: power: rpmpd: Add MSM8974 power domains Luca Weiss
2024-02-11 11:03 ` Stephan Gerhold
2024-02-11 11:19 ` Luca Weiss [this message]
2024-02-11 12:17 ` Krzysztof Kozlowski
2024-02-10 16:38 ` [PATCH v2 2/3] pmdomain: qcom: rpmpd: Add MSM8974+PM8841 " Luca Weiss
2024-02-10 17:18 ` Konrad Dybcio
2024-02-10 16:38 ` [PATCH v2 3/3] pmdomain: qcom: rpmpd: Add MSM8974PRO+PMA8084 " Luca Weiss
2024-02-10 17:19 ` Konrad Dybcio
2024-02-13 12:33 ` [PATCH v2 0/3] Add RPMPD support for MSM8974 Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12625470.O9o76ZdvQC@z3ntu.xyz \
--to=luca@z3ntu.xyz \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=matti.lehtimaki@gmail.com \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=stephan@gerhold.net \
--cc=ulf.hansson@linaro.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).