From: Zhu Yi <yi.zhu@intel.com>
To: Norbert Preining <preining@logic.at>
Cc: "Chatre, Reinette" <reinette.chatre@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"ipw3945-devel@lists.sourceforge.net"
<ipw3945-devel@lists.sourceforge.net>
Subject: Re: [ipw3945-devel] hang on 2.6.33-rc4
Date: Wed, 20 Jan 2010 17:32:44 +0800 [thread overview]
Message-ID: <1263979965.10275.2.camel@debian> (raw)
In-Reply-To: <20100119054715.GA10780@gamma.logic.tuwien.ac.at>
On Mon, 2010-01-18 at 22:47 -0700, Norbert Preining wrote:
> Hi Reinette,
>
> On Fr, 15 Jan 2010, reinette chatre wrote:
> > > I am having repeatable complete hard lockups on my laptop with 2.6.33-rc4.
> > > 2.6.32.3 works fine.
> > >
> > > I believe that it is related to the network, because sometimes I can
> > > actually log in (gnomes session) and as soon as I do some network
> > > related suddenly hard hang, not even Sysrq working anymore.
> > >
> > > Interestingly it only happens at a specific AP where the ESSID is
> > > hidden (at work). At home I can work without any problems (ESSID not
> > > hidden).
> > >
> > > Unfortunately I cannot set up a serial console or similar.
> >
> > Does that mean no netconsole either? Does anything show up in the logs?
> > Is it easy to reproduce? If so, perhaps you can have increased debug at
> > that time and hopefully something will be captured in the logs when the
> > problem occurs.
>
> Ok, I can confirm that setting up the network is not the problem, nor
> is it pinging other hosts. But ssh-ing into another server
> made it go boom. From the screenshot I attach it looks like something
> in TCP code (that explains why it does not happen in pings), below
> I see tcp_data_snd_check
>
> I managed to swithc in time to a console with tail -f syslog before
> it hard locked up. The log files are empty, but I got a screenshot photo
> which has some hopefully useful information. I cannot scroll up or down
> anymore ...
Looks like this this is the BUG_ON in skb_pull. Please try if this patch
help? BTW, are you using swiotlb?
diff --git a/drivers/net/wireless/iwlwifi/iwl-rx.c b/drivers/net/wireless/iwlwifi/iwl-rx.c
index 6f36b6e..2f8978f 100644
--- a/drivers/net/wireless/iwlwifi/iwl-rx.c
+++ b/drivers/net/wireless/iwlwifi/iwl-rx.c
@@ -1031,6 +1031,11 @@ void iwl_rx_reply_rx(struct iwl_priv *priv,
return;
}
+ if (len < ieee80211_hdrlen(header->frame_control)) {
+ IWL_DEBUG_RX(priv, "Packet size is too small %d\n", len);
+ return;
+ }
+
/* This will be used in several places later */
rate_n_flags = le32_to_cpu(phy_res->rate_n_flags);
next prev parent reply other threads:[~2010-01-20 9:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-15 15:22 hang on 2.6.33-rc4 Norbert Preining
2010-01-15 17:29 ` [ipw3945-devel] " reinette chatre
2010-01-16 2:30 ` Norbert Preining
2010-01-16 18:30 ` Norbert Preining
2010-01-18 17:06 ` reinette chatre
2010-01-18 17:19 ` Norbert Preining
2010-01-19 5:47 ` Norbert Preining
2010-01-19 17:01 ` reinette chatre
2010-01-19 17:59 ` Johannes Berg
2010-01-20 0:36 ` Norbert Preining
2010-01-20 9:52 ` Johannes Berg
2010-01-20 9:32 ` Zhu Yi [this message]
2010-01-21 0:28 ` Norbert Preining
2010-01-21 18:18 ` John Ranson
2010-01-27 15:37 ` Norbert Preining
2010-01-27 16:54 ` reinette chatre
2010-01-28 8:41 ` Norbert Preining
2010-01-28 16:23 ` reinette chatre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1263979965.10275.2.camel@debian \
--to=yi.zhu@intel.com \
--cc=ipw3945-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=preining@logic.at \
--cc=reinette.chatre@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).