From: Alberto Panizzo <maramaopercheseimorto@gmail.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: H Hartley Sweeten <hartleys@visionengravers.com>,
linux-input@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-arm-kernel-infradead <linux-arm-kernel@lists.infradead.org>,
Sascha linux-arm <s.hauer@pengutronix.de>
Subject: Re: [PATCH v2] input: MXC: add mxc-keypad driver to support the Keypad Port present in the mxc application processors family.
Date: Tue, 26 Jan 2010 11:29:01 +0100 [thread overview]
Message-ID: <1264501741.5260.29.camel@realization> (raw)
In-Reply-To: <20100126095217.GC3480@core.coreip.homeip.net>
Hi Dmitry! Thanks for reviewing!
On mar, 2010-01-26 at 01:52 -0800, Dmitry Torokhov wrote:
> > This algorithm is done via a threaded management of the keypad interrupt source
> > and delayed by a proper (and longer) debounce interval controlled by the
> > platform initialization.
>
> This I am not so sure about - the core of the matrix scan routine does
> not sleep so I wonder if starting a separate thread is not too wasteful
> in this case - you can easily do whan you want with a timer, no?
I'm pretty new to kernel programming and, from the university, the
threaded way looked the better (and unique) for me..
Let me find some documentation on timers and I will restructure the
interrupt management. Yes I need only to delay the matrix-scan activity
without waste cpu time.
>
> > +
> > + /*
> > + * Search for rows and cols enabled
> > + */
> > + keymap_data = (struct matrix_keymap_data *) pdata->keymap_data;
>
> Why do you need to cast away constness instead of declaring keymap_data
> as const pointer?
In next version will be fixed.
Alberto!
prev parent reply other threads:[~2010-01-26 10:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-08 18:58 MXC: input: add mxc-keypad driver to support the keypad interface present in the mxc application processors family Alberto Panizzo
2010-01-08 20:33 ` H Hartley Sweeten
2010-01-16 17:48 ` [PATCH v2] input: MXC: add mxc-keypad driver to support the Keypad Port " Alberto Panizzo
2010-01-21 16:17 ` Alberto Panizzo
2010-01-23 10:46 ` Alberto Panizzo
2010-01-26 9:52 ` Dmitry Torokhov
2010-01-26 10:29 ` Alberto Panizzo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1264501741.5260.29.camel@realization \
--to=maramaopercheseimorto@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=hartleys@visionengravers.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).