From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752017AbbD3Ag2 (ORCPT ); Wed, 29 Apr 2015 20:36:28 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:14419 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751048AbbD3Ag0 (ORCPT ); Wed, 29 Apr 2015 20:36:26 -0400 X-AuditID: cbfee690-f796f6d000005054-90-5541790710c4 From: Kukjin Kim To: "'Javier Martinez Canillas'" , "'Kukjin Kim'" Cc: "'Doug Anderson'" , "'Olof Johansson'" , "'Krzysztof Kozlowski'" , "'Andrzej Hajda'" , "'Kevin Hilman'" , "'Tyler Baker'" , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org References: <1428870659-5525-1-git-send-email-javier.martinez@collabora.co.uk> <552F6750.6020306@collabora.co.uk> <55417810.6070202@collabora.co.uk> In-reply-to: <55417810.6070202@collabora.co.uk> Subject: RE: [PATCH 1/1] ARM: dts: Make DP a consumer of DISP1 power domain on Exynos5420 Date: Thu, 30 Apr 2015 09:36:23 +0900 Message-id: <126501d082dd$af818a30$0e849e90$@kernel.org> MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-index: AQHxUDNKI+yG11z1FX/jy+Xpm4P+zQJi/lJAAWx6Y7WdBJ8N4A== Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrMIsWRmVeSWpSXmKPExsVy+t8zY12OSsdQg/6LjBa31p1jtTi77CCb xdHfBRavXxha9D9+zWzx9fAKRotNj6+xWlzeNYfNYsb5fUwWp65/ZrP4uOMeiwO3x+yGiywe f59fZ/HYtKqTzePOtT1sHpuX1HtcOdHE6tG3ZRWjx+dNcgEcUVw2Kak5mWWpRfp2CVwZhw/M YCp4yFvR3DeXsYGxkbuLkZNDQsBE4trrVYwQtpjEhXvr2boYuTiEBJYxSvw93MgGU9Rx9B07 RGI6o8S1OfvZQRJCAu8ZJbq2K3UxcnCwCShLNDbpg4SFBbQkFm5pYgGxRQSSJe6fmMMI0sss 8IhJom//PlaIQdMYJTbMOMUM0swpoC9xcV4SRHO0RP+rc2DzWQRUJb40XWUGsXkFLCTWvWll grAFJX5Mvge2gFlAXWLSvEXMELa8xOY1b5khjlaQ2HH2NSPEEU4Sh382QtWISOx78Q7sIAmB pRwSy37+YYVYJiDxbfIhFpB7JARkJTYdgJojKXFwxQ2WCYySs5CsnoVk9Swkq2chWbGAkWUV o2hqQXJBcVJ6kYlecWJucWleul5yfu4mRkhamLCD8d4B60OMAhyMSjy8HGoOoUKsiWXFlbmH GE2BLprILCWanA9MPnkl8YbGZkYWpiamxkbmlmZK4ryvpX4GCwmkJ5akZqemFqQWxReV5qQW H2Jk4uCUamDkOrvGKlgi6MgKZV7na3FTTtvcvrixtNiwd8J6MzOfrtIj7ifde1Pdurr9L9Zy tR84Jz+z9xdPbNH6lYYLo4v/O906ar1li1q3J5fDxaeJWnVlz4tK3M+d6F/9dHVEdsrOZS// fp167O4r/8qtnzW81nsE1TXOfTE9ri3m4h07y+bk14KvvH4qsRRnJBpqMRcVJwIAxn1/LQYD AAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrLKsWRmVeSWpSXmKPExsVy+t9jQV32SsdQg3dTLC1urTvHanF22UE2 i6O/CyxevzC06H/8mtni6+EVjBabHl9jtbi8aw6bxYzz+5gsTl3/zGbxccc9Fgduj9kNF1k8 /j6/zuKxaVUnm8eda3vYPDYvqfe4cqKJ1aNvyypGj8+b5AI4ohoYbTJSE1NSixRS85LzUzLz 0m2VvIPjneNNzQwMdQ0tLcyVFPISc1NtlVx8AnTdMnOA7lRSKEvMKQUKBSQWFyvp22GaEBri pmsB0xih6xsSBNdjZIAGEtYxZhw+MIOp4CFvRXPfXMYGxkbuLkZODgkBE4mOo+/YIWwxiQv3 1rN1MXJxCAlMZ5S4Nmc/WEJI4D2jRNd2pS5GDg42AWWJxiZ9kLCwgJbEwi1NLCC2iECyxP0T cxhBepkFHjFJ9O3fxwoxaBqjxIYZp5hBmjkF9CUuzkuCaI6W6H91Dmw+i4CqxJemq8wgNq+A hcS6N61MELagxI/J98AWMAuoS0yat4gZwpaX2LzmLTPE0QoSO86+ZoQ4wkni8M9GqBoRiX0v 3jFOYBSehWTULCSjZiEZNQtJywJGllWMoqkFyQXFSem5hnrFibnFpXnpesn5uZsYwUnnmdQO xpUNFocYBTgYlXh4BXQdQoVYE8uKK3MPMUpwMCuJ8PIXOYYK8aYkVlalFuXHF5XmpBYfYjQF +nQis5Rocj4wIeaVxBsam5gZWRqZWRiZmJsrifPO0ZULFRJITyxJzU5NLUgtgulj4uCUamD0 iyhe8scw7Pu3LXXVvAvm5VXHHXdczFzVveTxs7b7n3ueL9gTwprrx3un45mJft2auLhuzsbH 707JK6r9OrjhSiWn1JfZU25PDzgjk7foxeab6iVbDpksWZr70Kw6LWH+sQcaWhv21c4sSzUJ M6/wfZNkfOzs6x1rMr7ZRp1WW+ms4unkkq6rxFKckWioxVxUnAgAI+R5mlADAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Javier Martinez Canillas wrote: > > Hello Kukjin, > Hi, > On 04/16/2015 09:40 AM, Javier Martinez Canillas wrote: > > > > On 04/12/2015 10:30 PM, Javier Martinez Canillas wrote: > >> Commit ea08de16eb1b ("ARM: dts: Add DISP1 power domain for exynos5420") > >> added a device node for the Exynos5420 DISP1 power domain but dit not > >> make the DP controller a consumer of that power domain. > >> > >> This causes an "Unhandled fault: imprecise external abort" error if the > >> exynos-dp driver tries to access the DP controller registers and the PD > >> was turned off. This lead to a kernel panic and a complete system hang. > >> > >> Make the DP controller device node a consumer of the DISP1 power domain > >> to ensure that the PD is turned on when the exynos-dp driver is probed. > >> > >> Fixes: ea08de16eb1b ("ARM: dts: Add DISP1 power domain for exynos5420") > >> Signed-off-by: Javier Martinez Canillas > > > > Any comments about this patch? > > > > It's very trivial but fixes a very important regression on Exynos5420 boards > > with display panel and Peach Pit and Pi have been broken since next-20150401. > > > > This [0] is the Peach Pit boot log with yesteday's linux-next for example. > > > > Best regards, > > Javier > > > > [0]: http://arm-soc.lixom.net/bootlogs/next/next-20150415/pit-arm-exynos_defconfig.html > > > > It has been many weeks since this patch has been posted and linux-next > is still broken: > > http://arm-soc.lixom.net/bootlogs/next/next-20150429/pi-arm-exynos_defconfig.html > > Could you please apply $subject to fix the imprecise external abort issue. > Sure I'll in this weekend. Thanks for your gentle reminder ;-) - Kukjin