From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
Giridhar Malavali <giridhar.malavali@qlogic.com>,
Sarang Radke <sarang.radke@qlogic.com>
Subject: Re: linux-next: build warning after merge of the scsi tree
Date: Wed, 10 Feb 2010 17:13:51 -0500 [thread overview]
Message-ID: <1265840031.2769.571.camel@mulgrave.site> (raw)
In-Reply-To: <20100210165133.0dd46452.sfr@canb.auug.org.au>
On Wed, 2010-02-10 at 16:51 +1100, Stephen Rothwell wrote:
> Hi all,
>
> After merging the percpu tree, today's linux-next build (powerpc
> ppc64_defconfig) produced these warnings:
>
> drivers/scsi/qla2xxx/qla_attr.c: In function 'qla2x00_process_vendor_specific':
> drivers/scsi/qla2xxx/qla_attr.c:2150: warning: 'req_data' may be used uninitialized in this function
> drivers/scsi/qla2xxx/qla_attr.c:2152: warning: 'req_data_len' may be used uninitialized in this function
>
> If the first "goto done_unmap_sg;" in this function is followed, the
> req_data will be tested even though it has not been assigned to yet and
> if it is non zero, it and req_data_len will be passed to
> dma_free_coherent() while still uninitialised.
>
> Introduced by commit 9a069e196767d7b87184fd8d8211d22bb5b9c0b8 ("[SCSI]
> qla2xxx: Add BSG support for FC ELS/CT passthrough and vendor commands").
>
> The compiler also produces these:
>
> drivers/scsi/qla2xxx/qla_attr.c:2144: warning: 'command_sent' may be used uninitialized in this function
> drivers/scsi/qla2xxx/qla_attr.c:2146: warning: 'type' may be used uninitialized in this function
>
> but I can't easily tell if they are false positives.
They seem to be false positives. The unconditional initialisation is on
line 2191, and there's no use before then that I can find ... I also
don't see this error on my builds, so it looks like a toolchain issue.
James
next prev parent reply other threads:[~2010-02-10 22:13 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-10 5:51 linux-next: build warning after merge of the scsi tree Stephen Rothwell
2010-02-10 22:13 ` James Bottomley [this message]
2010-08-04 3:13 Stephen Rothwell
2010-08-04 4:17 ` James Bottomley
[not found] <20110518114912.dfdf8835.sfr@canb.auug.org.au>
2011-05-18 2:06 ` Nicholas A. Bellinger
2011-05-18 3:58 ` Stephen Rothwell
2011-05-19 2:54 ` Nicholas A. Bellinger
2011-05-19 16:18 ` Kiran Patil
2011-05-19 16:22 ` Geert Uytterhoeven
2011-06-23 17:02 ` Randy Dunlap
2011-07-20 4:08 Stephen Rothwell
2013-09-02 8:28 Stephen Rothwell
2013-09-04 9:18 ` Sujit Reddy Thumma
2013-09-04 9:54 ` Sujit Reddy Thumma
2014-11-18 8:21 Stephen Rothwell
2014-11-20 8:23 ` Christoph Hellwig
2016-09-13 4:15 Stephen Rothwell
2016-09-13 14:09 ` Bryant G. Ly
2016-09-15 13:55 ` Martin K. Petersen
2016-11-22 7:44 Stephen Rothwell
2016-11-22 22:24 ` Martin K. Petersen
2017-04-06 4:04 Stephen Rothwell
2017-04-06 8:18 ` Fam Zheng
2018-04-17 2:25 Stephen Rothwell
2018-04-18 21:52 ` Long Li
2018-04-18 23:30 ` Martin K. Petersen
[not found] <20180620132911.5f6ab464@canb.auug.org.au>
2018-07-10 7:31 ` Stephen Rothwell
2018-07-10 14:09 ` Jens Axboe
2018-07-10 14:14 ` James Bottomley
2018-07-10 14:22 ` Jens Axboe
2018-07-10 14:26 ` James Bottomley
2018-07-10 14:35 ` Jens Axboe
2018-07-10 15:08 ` Martin K. Petersen
2018-10-19 4:50 Stephen Rothwell
2018-10-19 4:54 ` James Bottomley
2018-10-19 4:58 ` Stephen Rothwell
2019-04-05 3:25 Stephen Rothwell
2019-04-05 4:30 ` Bart Van Assche
2019-04-05 4:52 ` James Bottomley
2019-05-31 3:36 Stephen Rothwell
2019-06-03 20:29 ` Tyrel Datwyler
2019-06-03 23:37 ` Tyrel Datwyler
2019-06-20 6:10 Stephen Rothwell
2019-11-07 4:01 Stephen Rothwell
2019-11-07 15:51 ` Bart Van Assche
2019-11-08 23:02 ` James Smart
[not found] <CGME20200625034139epcas5p126a29921cc3f751528786b00f4b2828b@epcas5p1.samsung.com>
2020-06-25 3:41 ` Stephen Rothwell
2020-06-25 14:29 ` Alim Akhtar
2021-03-18 5:54 Stephen Rothwell
2021-08-20 6:14 Stephen Rothwell
2021-08-20 6:30 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1265840031.2769.571.camel@mulgrave.site \
--to=james.bottomley@hansenpartnership.com \
--cc=giridhar.malavali@qlogic.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sarang.radke@qlogic.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).