From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161180AbcFMJXb (ORCPT ); Mon, 13 Jun 2016 05:23:31 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:52034 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964844AbcFMJXa (ORCPT ); Mon, 13 Jun 2016 05:23:30 -0400 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Andrey Smirnov , Shawn Guo , Russell King , linux-kernel@vger.kernel.org, Sascha Hauer Subject: Re: [PATCH 1/3] i.MX: system.c: Convert goto to if statement Date: Mon, 13 Jun 2016 11:24:16 +0200 Message-ID: <12670937.kESCsuxMaL@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <1465797329-22537-1-git-send-email-andrew.smirnov@gmail.com> References: <1465797329-22537-1-git-send-email-andrew.smirnov@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:GTq5NjDE0cPUGL30ylN6cqmPKu4jjEBZr5aVbcHDVSqRpDv99b8 YoHFihOIlLrq6Li5C8Xj3suUjmKLvcyuKLvv6Z+ZUf/b3PSmDu+ZQ136KDxDRkvQT7l7fRU LrI0qix47Yn1WP42s+CLt6KziQMVjQheeJh9VyaYhQmoIlgXAzm7hp730h+cXVLwYqIi3I3 lxtYo12iJly5eRZmbsSQg== X-UI-Out-Filterresults: notjunk:1;V01:K0:m4Ul4wEh1y0=:ROk3eHZulbmZB72D0W3T6b CSNIOs2FVIOrdD2RLczc+YJ1hmn6G6JwV5Hmvd+GvjWpFOXpkkJ458lv3jBK/k2hDN5ERTlA6 k7cLda9mzQ7UIGhpZDpHI/EADsFCOF3a18KItqYFqpjOS1lMd26ad7ESm5EklIlM08p7g5RqN eY/X/UbijpXfvfKeJ1K0Rn0SC0ppLB/3K7Sgr3NieCXDsnNaJIeh2MZrKOtZcMNZtKPj+PFrD zBUIpxE+rbbzNN2pQ0WcJA5S27ZbR7LJvhcX/fXCAYkrqyWtiXooo8bCAIOz3yQBEMpnBg8GB 8CmASVOWz+l9RLbKDKNsP3joy4/ihA/XdtSSy/BuJNujIJt/yI0bwAVfhSksvOJJ9RTjk2uYL Azlh1wKzQW+WXCCXYG2vlXZkI+nMCp/BLuw7Yrx04Tk5JM+00bdhMeI7eIo2BcFf+j6DpHmtl 8//VuFtyk0PnLVl7JOFntP2xeLmHHbWIszbMPHCHgW5AePQYM3F3VXc8Ela56l152U5uVM6Hi FwmUSiWobh9vA2VOgw7IpwnIQrKb9+iRkJwxYdHcMdazg4FYwvJ6IC8Ai5FE2rHGNlH3YXf3h BfSbSQCunyHajMRk7OD4I0w6MEtlpdue/jh1Gh2dWNrfOk9zjMJP/5W+V5pBFhnClvhOFuHDi erkZZAx+4diZvOBmTeVRZRkXX7WC1gvjzVRUyiEikFEL4T61lpOqPMqMEhI4fNLVuBlbKhqLi IG4Cc5NM0VL273UN Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sunday, June 12, 2016 10:55:27 PM CEST Andrey Smirnov wrote: > Using goto here doesn't bring any advantages and only makes the code > flow less clear. No functional changes. > > Signed-off-by: Andrey Smirnov All three patches looks reasonable to me, but now that I looked at the function, I wonder if we could do another cleanup on top and not call this function for imx35 at all but instead set the .l2c_aux_val/.l2c_aux_mask fields in its machine descriptor. The call to l2x0_of_init(0, ~0) seems to be the only thing we do on imx35 (where arm,pl310-cache is not present), and the kernel can do it automatically. Arnd