From: Frederic Weisbecker <fweisbec@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: LKML <linux-kernel@vger.kernel.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@elte.hu>, Don Zickus <dzickus@redhat.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Cyrill Gorcunov <gorcunov@gmail.com>
Subject: [PATCH 1/4] lockup_detector: Update some config
Date: Sun, 16 May 2010 04:33:57 +0200 [thread overview]
Message-ID: <1273977240-30800-2-git-send-regression-fweisbec@gmail.com> (raw)
In-Reply-To: <20100515073732.GA17120@elte.hu>
We kept CONFIG_DETECT_SOFTLOCKUP around for compatibility with
older configs. But it was enabled by default if CONFIG_DEBUG_KERNEL.
So if we want to enable CONFIG_LOCKUP_DETECTOR on configs that had
CONFIG_DETECT_SOFTLOCKUP, all we need is to have the same enabling
by default if CONFIG_DEBUG_KERNEL. We can then remove
CONFIG_DETECT_SOFTLOCKUP directly.
So tag CONFIG_LOCKUP_DETECTOR as default y. This is what we want for
most serious kernel debugging anyway.
And also forbid the lockup detector in S390 as it was for the
previous softlockup detector, event though the true reason for that
is not outlined.
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Don Zickus <dzickus@redhat.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Cyrill Gorcunov <gorcunov@gmail.com>
---
lib/Kconfig.debug | 25 +++----------------------
1 files changed, 3 insertions(+), 22 deletions(-)
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index 755713a..3a18b0b 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -152,29 +152,10 @@ config DEBUG_SHIRQ
Drivers ought to be able to handle interrupts coming in at those
points; some don't and need to be caught.
-config DETECT_SOFTLOCKUP
- bool
- depends on DEBUG_KERNEL && !S390
- default y
- help
- Say Y here to enable the kernel to detect "soft lockups",
- which are bugs that cause the kernel to loop in kernel
- mode for more than 60 seconds, without giving other tasks a
- chance to run.
-
- When a soft-lockup is detected, the kernel will print the
- current stack trace (which you should report), but the
- system will stay locked up. This feature has negligible
- overhead.
-
- (Note that "hard lockups" are separate type of bugs that
- can be detected via the NMI-watchdog, on platforms that
- support it.)
-
config LOCKUP_DETECTOR
bool "Detect Hard and Soft Lockups"
- depends on DEBUG_KERNEL
- default DETECT_SOFTLOCKUP
+ depends on DEBUG_KERNEL && !S390
+ default y
help
Say Y here to enable the kernel to act as a watchdog to detect
hard and soft lockups.
@@ -212,7 +193,7 @@ config BOOTPARAM_SOFTLOCKUP_PANIC
config BOOTPARAM_SOFTLOCKUP_PANIC_VALUE
int
- depends on DETECT_SOFTLOCKUP
+ depends on LOCKUP_DETECTOR
range 0 1
default 0 if !BOOTPARAM_SOFTLOCKUP_PANIC
default 1 if BOOTPARAM_SOFTLOCKUP_PANIC
--
1.6.2.3
next prev parent reply other threads:[~2010-05-16 2:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-14 5:53 linux-next: build failure after merge of the final tree Stephen Rothwell
2010-05-14 15:03 ` Don Zickus
2010-05-15 7:37 ` Ingo Molnar
2010-05-15 20:28 ` Frederic Weisbecker
2010-05-16 2:33 ` [GIT PULL] Lockup detector build fixes Frederic Weisbecker
2010-05-16 2:36 ` Frederic Weisbecker
2010-05-16 7:56 ` Ingo Molnar
2010-05-17 13:44 ` Don Zickus
2010-05-16 2:33 ` Frederic Weisbecker [this message]
2010-05-16 2:33 ` [PATCH 2/4] lockup_detector: Adapt CONFIG_PERF_EVENT_NMI to other archs Frederic Weisbecker
2010-05-16 2:33 ` [PATCH 3/4] lockup_detector: Introduce CONFIG_HARDLOCKUP_DETECTOR Frederic Weisbecker
2010-05-16 2:34 ` [PATCH 4/4] lockup_detector: Cross arch compile fixes Frederic Weisbecker
2010-05-14 15:11 ` linux-next: build failure after merge of the final tree Don Zickus
2010-05-16 9:20 ` [tip:perf/nmi] lockup_detector: Cross arch compile fixes tip-bot for Don Zickus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1273977240-30800-2-git-send-regression-fweisbec@gmail.com \
--to=fweisbec@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=dzickus@redhat.com \
--cc=gorcunov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).