From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755262Ab0EaXCf (ORCPT ); Mon, 31 May 2010 19:02:35 -0400 Received: from mail-wy0-f174.google.com ([74.125.82.174]:33476 "EHLO mail-wy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755164Ab0EaXCc (ORCPT ); Mon, 31 May 2010 19:02:32 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer:x-mailer-version :in-reply-to:references; b=CoNXPfWuOED3kGHhYtqtFUC0xcFoO4iWoPU7XUwoH/ZpAfTc7zPd4qCykB2ZnzyaDb YqFJ8UwGKdzqy2Aic2saQPA7N0b2oI1Ro091LcSYky8WK/cqSsJ6Km/blB8hBwnzNGg2 KDwTczluOFDqQRnzzbJ50V4eZZD9A0/3IkK04= From: Frederic Weisbecker To: Ingo Molnar Cc: LKML , Borislav Petkov , Ingo Molnar , Peter Zijlstra , Arnaldo Carvalho de Melo , Paul Mackerras , Tom Zanussi , Stephane Eranian , Frederic Weisbecker Subject: [PATCH 4/4] perf-record: Check correct pid when forking Date: Tue, 1 Jun 2010 01:02:20 +0200 Message-Id: <1275346940-18498-5-git-send-regression-fweisbec@gmail.com> X-Mailer: git-send-regression X-Mailer-version: 0.1, "The maintainer couldn't reproduce after one week full time debugging" special version. In-Reply-To: <1275346940-18498-1-git-send-regression-fweisbec@gmail.com> References: <1275346940-18498-1-git-send-regression-fweisbec@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Borislav Petkov When forking the child to be traced, we should check the correct return value from fork() and not a local variable which is otherwise unused. Signed-off-by: Borislav Petkov Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Arnaldo Carvalho de Melo Cc: Paul Mackerras Cc: Tom Zanussi Cc: Stephane Eranian LKML-Reference: <20100531211818.GA30175@liondog.tnic> Signed-off-by: Frederic Weisbecker --- tools/perf/builtin-record.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c index 9bc8905..dc3435e 100644 --- a/tools/perf/builtin-record.c +++ b/tools/perf/builtin-record.c @@ -503,7 +503,6 @@ static int __cmd_record(int argc, const char **argv) { int i, counter; struct stat st; - pid_t pid = 0; int flags; int err; unsigned long waking = 0; @@ -572,7 +571,7 @@ static int __cmd_record(int argc, const char **argv) if (forks) { child_pid = fork(); - if (pid < 0) { + if (child_pid < 0) { perror("failed to fork"); exit(-1); } -- 1.6.2.3