From: Alex Williamson <alex.williamson@redhat.com>
To: Tom Lyon <pugs@cisco.com>
Cc: randy.dunlap@oracle.com, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org, chrisw@sous-sol.org, joro@8bytes.org,
hjk@linutronix.de, mst@redhat.com, avi@redhat.com,
gregkh@suse.de, aafabbri@cisco.com, scofeldm@cisco.com,
Donald Dutile <ddutile@redhat.com>
Subject: Re: [PATCH V2] VFIO driver: Non-privileged user level PCI drivers
Date: Thu, 01 Jul 2010 09:29:04 -0600 [thread overview]
Message-ID: <1277998144.10112.58.camel@x201> (raw)
In-Reply-To: <4c0eb470.1HMjondO00NIvFM6%pugs@cisco.com>
On Tue, 2010-06-08 at 14:21 -0700, Tom Lyon wrote:
> +The VFIO_DMA_MASK ioctl is used to set the maximum permissible DMA address
> +(device dependent). It takes a single unsigned 64 bit integer as an argument.
> +This call also has the side effect of enabling PCI bus mastership.
Hi Tom,
This interface doesn't make sense for the MAP_IOVA user. Especially in
qemu, we have no idea what the DMA mask is for the device we're
assigning. It doesn't really matter though because the guest will use
bounce buffers internally once it loads the device specific drivers and
discovers the DMA mask. This only seems relevant if we're using a
DMA_MAP call that gets to pick the dmaaddr, so I'd propose we only make
this a required call for that interface, and create a separate ioctl for
actually enabling bus master. Thanks,
Alex
next prev parent reply other threads:[~2010-07-01 15:29 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-08 21:21 [PATCH V2] VFIO driver: Non-privileged user level PCI drivers Tom Lyon
2010-06-08 21:41 ` Randy Dunlap
2010-06-09 12:11 ` Arnd Bergmann
2010-06-08 21:45 ` Randy Dunlap
2010-06-08 22:38 ` Michael S. Tsirkin
2010-06-08 23:54 ` Tom Lyon
2010-06-09 5:45 ` Michael S. Tsirkin
2010-06-11 22:15 ` Tom Lyon
2010-06-13 10:23 ` Michael S. Tsirkin
2010-06-17 21:14 ` Tom Lyon
2010-06-17 21:47 ` Michael S. Tsirkin
2010-06-24 12:22 ` Joerg Roedel
2010-06-24 15:03 ` Michael S. Tsirkin
2010-06-09 11:04 ` Avi Kivity
2010-06-09 15:25 ` Greg KH
2010-06-09 16:05 ` Michael S. Tsirkin
2010-06-10 17:27 ` Konrad Rzeszutek Wilk
2010-06-11 1:58 ` Tom Lyon
2010-06-11 4:19 ` Greg KH
2010-06-11 4:56 ` Avi Kivity
2010-06-30 6:14 ` Alex Williamson
2010-06-30 13:36 ` Michael S. Tsirkin
2010-06-30 14:00 ` Alex Williamson
2010-06-30 22:17 ` Tom Lyon
2010-06-30 22:32 ` Michael S. Tsirkin
2010-06-30 22:49 ` Tom Lyon
2010-07-01 4:16 ` Alex Williamson
2010-07-01 4:30 ` Tom Lyon
2010-07-01 5:16 ` Alex Williamson
2010-07-01 15:29 ` Alex Williamson [this message]
2010-07-01 15:31 ` Michael S. Tsirkin
2010-07-01 15:48 ` Alex Williamson
2010-07-01 16:22 ` Michael S. Tsirkin
2010-07-01 18:49 ` Tom Lyon
2010-07-06 4:50 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1277998144.10112.58.camel@x201 \
--to=alex.williamson@redhat.com \
--cc=aafabbri@cisco.com \
--cc=avi@redhat.com \
--cc=chrisw@sous-sol.org \
--cc=ddutile@redhat.com \
--cc=gregkh@suse.de \
--cc=hjk@linutronix.de \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=pugs@cisco.com \
--cc=randy.dunlap@oracle.com \
--cc=scofeldm@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).