From: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
To: Dmitry Vyukov <dvyukov@google.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Cc: Petr Mladek <pmladek@suse.com>,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
syzkaller <syzkaller@googlegroups.com>
Subject: Re: [syzbot? printk?] no WARN_ON() messages printed before "Kernel panic - not syncing: panic_on_warn set ..."
Date: Wed, 8 May 2019 19:31:06 +0900 [thread overview]
Message-ID: <127c9c3b-f878-174f-7065-66dc50fcabcf@i-love.sakura.ne.jp> (raw)
In-Reply-To: <CACT4Y+ZhHvsVZh1pKzK1tn-P78rOssOz=7eWkXz7z2Sh1JscdA@mail.gmail.com>
Hello.
We are again getting corrupted reports where message from WARN() is missing.
For example, https://syzkaller.appspot.com/text?tag=CrashLog&x=1720cac8a00000 was
titled as "WARNING in cgroup_exit" because the
"WARNING: CPU: 0 PID: 7870 at kernel/cgroup/cgroup.c:6008 cgroup_exit+0x51a/0x5d0"
line is there but https://syzkaller.appspot.com/text?tag=CrashLog&x=1670a602a00000
was titled as "corrupted report (2)" because the
"WARNING: CPU: 0 PID: 10223 at kernel/cgroup/cgroup.c:6008 cgroup_exit+0x51a/0x5d0"
line is missing. Also, it is unlikely that there was no printk() for a few minutes.
Thus, I suspect something is again suppressing console output.
Since this problem is happening in 5.1.0-next-20190507, do we want to try below one?
kernel/printk/printk.c | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
index e1e8250..f0b9463 100644
--- a/kernel/printk/printk.c
+++ b/kernel/printk/printk.c
@@ -3338,3 +3338,23 @@ void kmsg_dump_rewind(struct kmsg_dumper *dumper)
EXPORT_SYMBOL_GPL(kmsg_dump_rewind);
#endif
+
+#ifdef CONFIG_DEBUG_AID_FOR_SYZBOT
+static int initial_loglevel;
+static void check_loglevel(struct timer_list *timer)
+{
+ if (console_loglevel < initial_loglevel)
+ panic("Console loglevel changed (%d->%d)!", initial_loglevel,
+ console_loglevel);
+ mod_timer(timer, jiffies + HZ);
+}
+static int __init loglevelcheck_init(void)
+{
+ static DEFINE_TIMER(timer, check_loglevel);
+
+ initial_loglevel = console_loglevel;
+ mod_timer(&timer, jiffies + HZ);
+ return 0;
+}
+late_initcall(loglevelcheck_init);
+#endif
By the way, recently we are hitting false positives caused by "WARNING:"
string from not WARN() messages but plain printk() messages (e.g.
https://syzkaller.appspot.com/bug?id=31bdef63e48688854fde93e6edf390922b70f8a4
https://syzkaller.appspot.com/bug?id=faae4720a75cadb8cd0dbda5c4d3542228d37340
) and we need to avoid emitting "WARNING:" string from plain printk() messages
during fuzzing testing. I guess we want to add something like
CONFIG_DEBUG_AID_FOR_SYZBOT to all kernels in order to mask such string...
next prev parent reply other threads:[~2019-05-08 10:31 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-16 2:09 [syzbot? printk?] no WARN_ON() messages printed before "Kernel panic - not syncing: panic_on_warn set ..." Tetsuo Handa
2019-03-16 9:11 ` Dmitry Vyukov
2019-03-16 10:18 ` Tetsuo Handa
2019-03-16 14:14 ` Sergey Senozhatsky
2019-03-16 14:16 ` Dmitry Vyukov
2019-03-16 14:40 ` Sergey Senozhatsky
2019-03-16 14:53 ` Tetsuo Handa
2019-03-16 14:57 ` Dmitry Vyukov
2019-03-16 15:02 ` Tetsuo Handa
2019-03-16 15:10 ` Dmitry Vyukov
2019-03-18 5:27 ` Tetsuo Handa
2019-03-18 12:07 ` Dmitry Vyukov
2019-03-18 12:32 ` Dmitry Vyukov
2019-03-18 12:39 ` Dmitry Vyukov
2019-03-19 0:41 ` Tetsuo Handa
2019-03-18 12:50 ` Sergey Senozhatsky
2019-03-18 13:42 ` Dmitry Vyukov
2019-03-18 14:09 ` Sergey Senozhatsky
2019-03-19 8:10 ` Dmitry Vyukov
2019-03-19 12:35 ` Sergey Senozhatsky
2019-03-19 13:35 ` Dmitry Vyukov
2019-05-08 10:31 ` Tetsuo Handa [this message]
2019-05-09 9:58 ` Sergey Senozhatsky
2019-05-09 10:18 ` Sergey Senozhatsky
2019-05-09 10:40 ` Tetsuo Handa
2019-05-09 10:26 ` Tetsuo Handa
2019-05-09 10:36 ` Sergey Senozhatsky
2019-05-10 14:12 ` Petr Mladek
2019-05-10 14:53 ` Tetsuo Handa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=127c9c3b-f878-174f-7065-66dc50fcabcf@i-love.sakura.ne.jp \
--to=penguin-kernel@i-love.sakura.ne.jp \
--cc=dvyukov@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=syzkaller@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).