linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Carlos Bilbao <bilbao@vt.edu>
To: davem@davemloft.net, Joe Perches <joe@perches.com>
Cc: kuba@kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, andrew@lunn.ch,
	gregkh@linuxfoundation.org
Subject: [PATCH net-next v2] drivers: net: Remove undefined XXXDEBUG on driver sb1000
Date: Thu, 08 Jul 2021 13:53:07 -0400	[thread overview]
Message-ID: <12806725.dW097sEU6C@iron-maiden> (raw)
In-Reply-To: <ccf9f07a72c911652d24ceb6c6e925f834f1d338.camel@perches.com>

XXXDEBUG isn't defined anywhere so these can be deleted from this file.

Signed-off-by: Carlos Bilbao <bilbao@vt.edu>
---
 drivers/net/sb1000.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/net/sb1000.c b/drivers/net/sb1000.c
index e88af978f63c..a7a6bd7ef015 100644
--- a/drivers/net/sb1000.c
+++ b/drivers/net/sb1000.c
@@ -759,9 +759,6 @@ sb1000_rx(struct net_device *dev)
 	ioaddr = dev->base_addr;
 
 	insw(ioaddr, (unsigned short*) st, 1);
-#ifdef XXXDEBUG
-printk("cm0: received: %02x %02x\n", st[0], st[1]);
-#endif /* XXXDEBUG */
 	lp->rx_frames++;
 
 	/* decide if it is a good or bad frame */
@@ -804,9 +801,6 @@ printk("cm0: received: %02x %02x\n", st[0], st[1]);
 	if (st[0] & 0x40) {
 		/* get data length */
 		insw(ioaddr, buffer, NewDatagramHeaderSize / 2);
-#ifdef XXXDEBUG
-printk("cm0: IP identification: %02x%02x  fragment offset: %02x%02x\n", buffer[30], buffer[31], buffer[32], buffer[33]);
-#endif /* XXXDEBUG */
 		if (buffer[0] != NewDatagramHeaderSkip) {
 			if (sb1000_debug > 1)
 				printk(KERN_WARNING "%s: new datagram header skip error: "
-- 
2.25.1




      parent reply	other threads:[~2021-07-08 17:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-08 15:23 [PATCH] drivers: net: Follow the indentation coding standard on printks Carlos Bilbao
2021-07-08 16:40 ` Joe Perches
2021-07-08 17:33   ` [PATCH net-next v2] " Carlos Bilbao
2021-07-08 17:38     ` Joe Perches
2021-07-08 17:43       ` Carlos Bilbao
2021-07-08 17:48       ` [PATCH net-next v2] drivers: ethernet: tulip: Fix indentation of printk Carlos Bilbao
2021-07-08 17:59         ` Andrew Lunn
2021-07-08 17:53       ` Carlos Bilbao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12806725.dW097sEU6C@iron-maiden \
    --to=bilbao@vt.edu \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=joe@perches.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --subject='Re: [PATCH net-next v2] drivers: net: Remove undefined XXXDEBUG on driver sb1000' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).