linux-next: build warnings in Linus' tree

linux-next: build warnings in Linus' tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 2738 bytes --]

Hi all,

Today's linux-next build (x86_64 allmodconfig) produced these warnings:

drivers/acpi/sysfs.c:152: warning: passing argument 1 of '__check_old_set_param' from incompatible pointer type
include/linux/moduleparam.h:165: note: expected 'int (*)(const char *, struct kernel_param *)' but argument is of type 'int (*)(const char *, const struct kernel_param *)'
drivers/acpi/sysfs.c:152: warning: passing argument 1 of '__check_old_set_param' from incompatible pointer type
include/linux/moduleparam.h:165: note: expected 'int (*)(const char *, struct kernel_param *)' but argument is of type 'int (*)(const char *, const struct kernel_param *)'
drivers/acpi/sysfs.c:152: warning: passing argument 1 of '__check_old_set_param' from incompatible pointer type
include/linux/moduleparam.h:165: note: expected 'int (*)(const char *, struct kernel_param *)' but argument is of type 'int (*)(const char *, const struct kernel_param *)'
drivers/acpi/sysfs.c:152: warning: passing argument 1 of '__check_old_set_param' from incompatible pointer type
include/linux/moduleparam.h:165: note: expected 'int (*)(const char *, struct kernel_param *)' but argument is of type 'int (*)(const char *, const struct kernel_param *)'
drivers/acpi/sysfs.c:154: warning: passing argument 1 of '__check_old_set_param' from incompatible pointer type
include/linux/moduleparam.h:165: note: expected 'int (*)(const char *, struct kernel_param *)' but argument is of type 'int (*)(const char *, const struct kernel_param *)'
drivers/acpi/sysfs.c:154: warning: passing argument 1 of '__check_old_set_param' from incompatible pointer type
include/linux/moduleparam.h:165: note: expected 'int (*)(const char *, struct kernel_param *)' but argument is of type 'int (*)(const char *, const struct kernel_param *)'
drivers/acpi/sysfs.c:154: warning: passing argument 1 of '__check_old_set_param' from incompatible pointer type
include/linux/moduleparam.h:165: note: expected 'int (*)(const char *, struct kernel_param *)' but argument is of type 'int (*)(const char *, const struct kernel_param *)'
drivers/acpi/sysfs.c:154: warning: passing argument 1 of '__check_old_set_param' from incompatible pointer type
include/linux/moduleparam.h:165: note: expected 'int (*)(const char *, struct kernel_param *)' but argument is of type 'int (*)(const char *, const struct kernel_param *)'

Introduced by commit 1c8fce27e275fd7c6b75bc6455745f02d3903ee6 ("ACPI:
introduce drivers/acpi/sysfs.c") interacting with commit
9bbb9e5a33109b2832e2e63dcc7a132924ab374b ("param: use ops in struct
kernel_param, rather than get and set fns directly").

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build warnings in Linus' tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 2903 bytes --]

Hi Len,

On Tue, 17 Aug 2010 11:24:39 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Today's linux-next build (x86_64 allmodconfig) produced these warnings:
> 
> drivers/acpi/sysfs.c:152: warning: passing argument 1 of '__check_old_set_param' from incompatible pointer type
> include/linux/moduleparam.h:165: note: expected 'int (*)(const char *, struct kernel_param *)' but argument is of type 'int (*)(const char *, const struct kernel_param *)'
> drivers/acpi/sysfs.c:152: warning: passing argument 1 of '__check_old_set_param' from incompatible pointer type
> include/linux/moduleparam.h:165: note: expected 'int (*)(const char *, struct kernel_param *)' but argument is of type 'int (*)(const char *, const struct kernel_param *)'
> drivers/acpi/sysfs.c:152: warning: passing argument 1 of '__check_old_set_param' from incompatible pointer type
> include/linux/moduleparam.h:165: note: expected 'int (*)(const char *, struct kernel_param *)' but argument is of type 'int (*)(const char *, const struct kernel_param *)'
> drivers/acpi/sysfs.c:152: warning: passing argument 1 of '__check_old_set_param' from incompatible pointer type
> include/linux/moduleparam.h:165: note: expected 'int (*)(const char *, struct kernel_param *)' but argument is of type 'int (*)(const char *, const struct kernel_param *)'
> drivers/acpi/sysfs.c:154: warning: passing argument 1 of '__check_old_set_param' from incompatible pointer type
> include/linux/moduleparam.h:165: note: expected 'int (*)(const char *, struct kernel_param *)' but argument is of type 'int (*)(const char *, const struct kernel_param *)'
> drivers/acpi/sysfs.c:154: warning: passing argument 1 of '__check_old_set_param' from incompatible pointer type
> include/linux/moduleparam.h:165: note: expected 'int (*)(const char *, struct kernel_param *)' but argument is of type 'int (*)(const char *, const struct kernel_param *)'
> drivers/acpi/sysfs.c:154: warning: passing argument 1 of '__check_old_set_param' from incompatible pointer type
> include/linux/moduleparam.h:165: note: expected 'int (*)(const char *, struct kernel_param *)' but argument is of type 'int (*)(const char *, const struct kernel_param *)'
> drivers/acpi/sysfs.c:154: warning: passing argument 1 of '__check_old_set_param' from incompatible pointer type
> include/linux/moduleparam.h:165: note: expected 'int (*)(const char *, struct kernel_param *)' but argument is of type 'int (*)(const char *, const struct kernel_param *)'
> 
> Introduced by commit 1c8fce27e275fd7c6b75bc6455745f02d3903ee6 ("ACPI:
> introduce drivers/acpi/sysfs.c") interacting with commit
> 9bbb9e5a33109b2832e2e63dcc7a132924ab374b ("param: use ops in struct
> kernel_param, rather than get and set fns directly").

Can we have this fixed, please?
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build warnings in Linus' tree

[Zhang Rui]

On Mon, 2010-08-30 at 09:42 +0800, Stephen Rothwell wrote:
> Hi Len,
> 
> On Tue, 17 Aug 2010 11:24:39 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > Today's linux-next build (x86_64 allmodconfig) produced these warnings:
> > 
> > drivers/acpi/sysfs.c:152: warning: passing argument 1 of '__check_old_set_param' from incompatible pointer type
> > include/linux/moduleparam.h:165: note: expected 'int (*)(const char *, struct kernel_param *)' but argument is of type 'int (*)(const char *, const struct kernel_param *)'
> > drivers/acpi/sysfs.c:152: warning: passing argument 1 of '__check_old_set_param' from incompatible pointer type
> > include/linux/moduleparam.h:165: note: expected 'int (*)(const char *, struct kernel_param *)' but argument is of type 'int (*)(const char *, const struct kernel_param *)'
> > drivers/acpi/sysfs.c:152: warning: passing argument 1 of '__check_old_set_param' from incompatible pointer type
> > include/linux/moduleparam.h:165: note: expected 'int (*)(const char *, struct kernel_param *)' but argument is of type 'int (*)(const char *, const struct kernel_param *)'
> > drivers/acpi/sysfs.c:152: warning: passing argument 1 of '__check_old_set_param' from incompatible pointer type
> > include/linux/moduleparam.h:165: note: expected 'int (*)(const char *, struct kernel_param *)' but argument is of type 'int (*)(const char *, const struct kernel_param *)'
> > drivers/acpi/sysfs.c:154: warning: passing argument 1 of '__check_old_set_param' from incompatible pointer type
> > include/linux/moduleparam.h:165: note: expected 'int (*)(const char *, struct kernel_param *)' but argument is of type 'int (*)(const char *, const struct kernel_param *)'
> > drivers/acpi/sysfs.c:154: warning: passing argument 1 of '__check_old_set_param' from incompatible pointer type
> > include/linux/moduleparam.h:165: note: expected 'int (*)(const char *, struct kernel_param *)' but argument is of type 'int (*)(const char *, const struct kernel_param *)'
> > drivers/acpi/sysfs.c:154: warning: passing argument 1 of '__check_old_set_param' from incompatible pointer type
> > include/linux/moduleparam.h:165: note: expected 'int (*)(const char *, struct kernel_param *)' but argument is of type 'int (*)(const char *, const struct kernel_param *)'
> > drivers/acpi/sysfs.c:154: warning: passing argument 1 of '__check_old_set_param' from incompatible pointer type
> > include/linux/moduleparam.h:165: note: expected 'int (*)(const char *, struct kernel_param *)' but argument is of type 'int (*)(const char *, const struct kernel_param *)'
> > 
> > Introduced by commit 1c8fce27e275fd7c6b75bc6455745f02d3903ee6 ("ACPI:
> > introduce drivers/acpi/sysfs.c") interacting with commit
> > 9bbb9e5a33109b2832e2e63dcc7a132924ab374b ("param: use ops in struct
> > kernel_param, rather than get and set fns directly").
> 
> Can we have this fixed, please?
patch attached. :)

Use module_param_cb instead of the obsoleted module_param_call to fix a build warning.

Signed-off-by: Zhang Rui <rui.zhang@intel.com>
---
 drivers/acpi/sysfs.c |   20 ++++++++++++++------
 1 file changed, 14 insertions(+), 6 deletions(-)

Index: linux-2.6/drivers/acpi/sysfs.c
===================================================================
--- linux-2.6.orig/drivers/acpi/sysfs.c
+++ linux-2.6/drivers/acpi/sysfs.c
@@ -100,7 +100,7 @@ static const struct acpi_dlevel acpi_deb
 	ACPI_DEBUG_INIT(ACPI_LV_EVENTS),
 };
 
-static int param_get_debug_layer(char *buffer, struct kernel_param *kp)
+static int param_get_debug_layer(char *buffer, const struct kernel_param *kp)
 {
 	int result = 0;
 	int i;
@@ -128,7 +128,7 @@ static int param_get_debug_layer(char *b
 	return result;
 }
 
-static int param_get_debug_level(char *buffer, struct kernel_param *kp)
+static int param_get_debug_level(char *buffer, const struct kernel_param *kp)
 {
 	int result = 0;
 	int i;
@@ -149,10 +149,18 @@ static int param_get_debug_level(char *b
 	return result;
 }
 
-module_param_call(debug_layer, param_set_uint, param_get_debug_layer,
-		  &acpi_dbg_layer, 0644);
-module_param_call(debug_level, param_set_uint, param_get_debug_level,
-		  &acpi_dbg_level, 0644);
+static struct kernel_param_ops param_ops_debug_layer = {
+	.set = param_set_uint,
+	.get = param_get_debug_layer,
+};
+
+static struct kernel_param_ops param_ops_debug_level = {
+	.set = param_set_uint,
+	.get = param_get_debug_level,
+};
+
+module_param_cb(debug_layer, &param_ops_debug_layer, &acpi_dbg_layer, 0644);
+module_param_cb(debug_level, &param_ops_debug_level, &acpi_dbg_level, 0644);
 
 static char trace_method_name[6];
 module_param_string(trace_method_name, trace_method_name, 6, 0644);

Re: linux-next: build warnings in Linus' tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 377 bytes --]

Hi Len,

On Mon, 30 Aug 2010 14:08:02 +0800 Zhang Rui <rui.zhang@intel.com> wrote:
>
> patch attached. :)
> 
> Use module_param_cb instead of the obsoleted module_param_call to fix a build warning.
> 
> Signed-off-by: Zhang Rui <rui.zhang@intel.com>

Ping?

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build warnings in Linus' tree

[Len Brown]

applied

thanks,
Len Brown, Intel Open Source Technology Center

Re: linux-next: build warnings in Linus' tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1502 bytes --]

Hi Len,

On Mon, 30 Aug 2010 14:08:02 +0800 Zhang Rui <rui.zhang@intel.com> wrote:
>
> On Mon, 2010-08-30 at 09:42 +0800, Stephen Rothwell wrote:
> > Hi Len,
> > 
> > On Tue, 17 Aug 2010 11:24:39 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > >
> > > Today's linux-next build (x86_64 allmodconfig) produced these warnings:
> > > 
> > > drivers/acpi/sysfs.c:152: warning: passing argument 1 of '__check_old_set_param' from incompatible pointer type
> > > include/linux/moduleparam.h:165: note: expected 'int (*)(const char *, struct kernel_param *)' but argument is of type 'int (*)(const char *, const struct kernel_param *)'

[several more elided]

> > > Introduced by commit 1c8fce27e275fd7c6b75bc6455745f02d3903ee6 ("ACPI:
> > > introduce drivers/acpi/sysfs.c") interacting with commit
> > > 9bbb9e5a33109b2832e2e63dcc7a132924ab374b ("param: use ops in struct
> > > kernel_param, rather than get and set fns directly").
> > 
> > Can we have this fixed, please?
> patch attached. :)
> 
> Use module_param_cb instead of the obsoleted module_param_call to fix a build warning.
> 
> Signed-off-by: Zhang Rui <rui.zhang@intel.com>

Now that this has been in linux-next since Sep 6, can you please send it
to Linus.  It removes quite a few warnings that were introduced during
this merge window - and I think we already have too many warnings.

Thanks.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build warnings in Linus' tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1642 bytes --]

Hi Len,

On Fri, 17 Sep 2010 14:26:30 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> On Mon, 30 Aug 2010 14:08:02 +0800 Zhang Rui <rui.zhang@intel.com> wrote:
> >
> > On Mon, 2010-08-30 at 09:42 +0800, Stephen Rothwell wrote:
> > > Hi Len,
> > > 
> > > On Tue, 17 Aug 2010 11:24:39 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > > >
> > > > Today's linux-next build (x86_64 allmodconfig) produced these warnings:
> > > > 
> > > > drivers/acpi/sysfs.c:152: warning: passing argument 1 of '__check_old_set_param' from incompatible pointer type
> > > > include/linux/moduleparam.h:165: note: expected 'int (*)(const char *, struct kernel_param *)' but argument is of type 'int (*)(const char *, const struct kernel_param *)'
> 
> [several more elided]
> 
> > > > Introduced by commit 1c8fce27e275fd7c6b75bc6455745f02d3903ee6 ("ACPI:
> > > > introduce drivers/acpi/sysfs.c") interacting with commit
> > > > 9bbb9e5a33109b2832e2e63dcc7a132924ab374b ("param: use ops in struct
> > > > kernel_param, rather than get and set fns directly").
> > > 
> > > Can we have this fixed, please?
> > patch attached. :)
> > 
> > Use module_param_cb instead of the obsoleted module_param_call to fix a build warning.
> > 
> > Signed-off-by: Zhang Rui <rui.zhang@intel.com>
> 
> Now that this has been in linux-next since Sep 6, can you please send it
> to Linus.  It removes quite a few warnings that were introduced during
> this merge window - and I think we already have too many warnings.

Ping?
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

linux-next: build warnings in Linus' tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 459 bytes --]

Hi all,

Building Linus' tree, today's linux-next build (htmldocs) produced
these warnings:

include/linux/netfs.h:314: warning: Function parameter or member 'ctx' not described in 'netfs_inode_init'
include/linux/netfs.h:314: warning: Excess function parameter 'inode' description in 'netfs_inode_init'

Introduced by commit

  e81fb4198e27 ("netfs: Further cleanups after struct netfs_inode wrapper introduced")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warnings in Linus' tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 383 bytes --]

Hi all,

building Linus' tree, today's linux-next build (htmldocs) produced
these warnings:

Documentation/output/lirc.h.rst:X: WARNING: undefined label: lirc-can-notify-decode
Documentation/output/lirc.h.rst:X: WARNING: undefined l

Presumably introduced by commit

  e5499dd7253c ("media: lirc: revert removal of unused feature flags")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warnings in Linus' tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 445 bytes --]

Hi all,

Building Linus' tree, today's linux-next build (htmldocs) produced
these warnings:

include/linux/blkdev.h:1533: warning: Function parameter or member 'start_time' not described in 'bio_end_io_acct'
include/linux/blkdev.h:1533: warning: Excess function parameter 'start' description in 'bio_end_io_acct'

Introduced by commit

  956d510ee78c ("block: add disk/bio-based accounting helpers")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warnings in Linus' tree

[Christoph Hellwig]

On Thu, Jan 27, 2022 at 03:30:55PM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> Building Linus' tree, today's linux-next build (htmldocs) produced
> these warnings:
> 
> include/linux/blkdev.h:1533: warning: Function parameter or member 'start_time' not described in 'bio_end_io_acct'
> include/linux/blkdev.h:1533: warning: Excess function parameter 'start' description in 'bio_end_io_acct'
> 
> Introduced by commit
> 
>   956d510ee78c ("block: add disk/bio-based accounting helpers")

The warning looks correct, but that commit is rather old, so something
else must have caused it to be emitted now?

> 
> -- 
> Cheers,
> Stephen Rothwell


---end quoted text---

Re: linux-next: build warnings in Linus' tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 812 bytes --]

Hi Christoph,

On Thu, 27 Jan 2022 07:01:41 +0100 Christoph Hellwig <hch@lst.de> wrote:
>
> On Thu, Jan 27, 2022 at 03:30:55PM +1100, Stephen Rothwell wrote:
> > 
> > Building Linus' tree, today's linux-next build (htmldocs) produced
> > these warnings:
> > 
> > include/linux/blkdev.h:1533: warning: Function parameter or member 'start_time' not described in 'bio_end_io_acct'
> > include/linux/blkdev.h:1533: warning: Excess function parameter 'start' description in 'bio_end_io_acct'
> > 
> > Introduced by commit
> > 
> >   956d510ee78c ("block: add disk/bio-based accounting helpers")  
> 
> The warning looks correct, but that commit is rather old, so something
> else must have caused it to be emitted now?

Yeah, but I couldn't see anything obvious.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warnings in Linus' tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 622 bytes --]

Hi all,

Building Linus' tree, today's linux-next build (htmldocs) produced these
warnings (these have been around for a while):

Documentation/dev-tools/kunit/architecture.rst:3: WARNING: Duplicate C declaration, also defined at dev-tools/kunit/api/test:138.
Declaration is '.. c:struct:: kunit_case'.
Documentation/dev-tools/kunit/architecture.rst:1508: WARNING: Duplicate C declaration, also defined at dev-tools/kunit/api/test:1508.
Declaration is '.. c:macro:: KUNIT_ARRAY_PARAM'.

Introduced by commit

  bc145b370c11 ("Documentation: KUnit: Added KUnit Architecture")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warnings in Linus' tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 6363 bytes --]

Hi all,

Building Linus' tree, today's linux-next build (x86_64 allmodconfig)
produced these warnings:

WARNING: modpost: vmlinux.o(.text.unlikely+0x63df): Section mismatch in reference from the function prepare_command_line() to the variable .init.data:builtin_cmdline
The function prepare_command_line() references
the variable __initdata builtin_cmdline.
This is often because prepare_command_line lacks a __initdata 
annotation or the annotation of builtin_cmdline is wrong.

WARNING: modpost: vmlinux.o(.text.unlikely+0x63fa): Section mismatch in reference from the function prepare_command_line() to the variable .init.data:builtin_cmdline
The function prepare_command_line() references
the variable __initdata builtin_cmdline.
This is often because prepare_command_line lacks a __initdata 
annotation or the annotation of builtin_cmdline is wrong.

WARNING: modpost: vmlinux.o(.text.unlikely+0x640b): Section mismatch in reference from the function prepare_command_line() to the variable .init.data:boot_command_line
The function prepare_command_line() references
the variable __initdata boot_command_line.
This is often because prepare_command_line lacks a __initdata 
annotation or the annotation of boot_command_line is wrong.

WARNING: modpost: vmlinux.o(.text.unlikely+0x6412): Section mismatch in reference from the function prepare_command_line() to the variable .init.data:builtin_cmdline
The function prepare_command_line() references
the variable __initdata builtin_cmdline.
This is often because prepare_command_line lacks a __initdata 
annotation or the annotation of builtin_cmdline is wrong.

WARNING: modpost: vmlinux.o(.text.unlikely+0x6423): Section mismatch in reference from the function prepare_command_line() to the variable .init.data:builtin_cmdline
The function prepare_command_line() references
the variable __initdata builtin_cmdline.
This is often because prepare_command_line lacks a __initdata 
annotation or the annotation of builtin_cmdline is wrong.

WARNING: modpost: vmlinux.o(.text.unlikely+0x6461): Section mismatch in reference from the function prepare_command_line() to the variable .init.data:builtin_cmdline
The function prepare_command_line() references
the variable __initdata builtin_cmdline.
This is often because prepare_command_line lacks a __initdata 
annotation or the annotation of builtin_cmdline is wrong.

WARNING: modpost: vmlinux.o(.text.unlikely+0x6468): Section mismatch in reference from the function prepare_command_line() to the variable .init.data:boot_command_line
The function prepare_command_line() references
the variable __initdata boot_command_line.
This is often because prepare_command_line lacks a __initdata 
annotation or the annotation of boot_command_line is wrong.

WARNING: modpost: vmlinux.o(.text.unlikely+0x6474): Section mismatch in reference from the function prepare_command_line() to the variable .init.data:boot_command_line
The function prepare_command_line() references
the variable __initdata boot_command_line.
This is often because prepare_command_line lacks a __initdata 
annotation or the annotation of boot_command_line is wrong.

WARNING: modpost: vmlinux.o(.text.unlikely+0x647f): Section mismatch in reference from the function prepare_command_line() to the variable .init.data:boot_command_line
The function prepare_command_line() references
the variable __initdata boot_command_line.
This is often because prepare_command_line lacks a __initdata 
annotation or the annotation of boot_command_line is wrong.

WARNING: modpost: vmlinux.o(.text.unlikely+0x6487): Section mismatch in reference from the function prepare_command_line() to the variable .init.data:boot_command_line
The function prepare_command_line() references
the variable __initdata boot_command_line.
This is often because prepare_command_line lacks a __initdata 
annotation or the annotation of boot_command_line is wrong.

WARNING: modpost: vmlinux.o(.text.unlikely+0x6498): Section mismatch in reference from the function prepare_command_line() to the variable .init.data:boot_command_line
The function prepare_command_line() references
the variable __initdata boot_command_line.
This is often because prepare_command_line lacks a __initdata 
annotation or the annotation of boot_command_line is wrong.

WARNING: modpost: vmlinux.o(.text.unlikely+0x649f): Section mismatch in reference from the function prepare_command_line() to the variable .init.data:command_line
The function prepare_command_line() references
the variable __initdata command_line.
This is often because prepare_command_line lacks a __initdata 
annotation or the annotation of command_line is wrong.

WARNING: modpost: vmlinux.o(.text.unlikely+0x64b8): Section mismatch in reference from the function prepare_command_line() to the variable .init.data:command_line
The function prepare_command_line() references
the variable __initdata command_line.
This is often because prepare_command_line lacks a __initdata 
annotation or the annotation of command_line is wrong.

WARNING: modpost: vmlinux.o(.text.unlikely+0x64c3): Section mismatch in reference from the function prepare_command_line() to the variable .init.data:command_line
The function prepare_command_line() references
the variable __initdata command_line.
This is often because prepare_command_line lacks a __initdata 
annotation or the annotation of command_line is wrong.

WARNING: modpost: vmlinux.o(.text.unlikely+0x64c9): Section mismatch in reference from the function prepare_command_line() to the function .init.text:parse_early_param()
The function prepare_command_line() references
the function __init parse_early_param().
This is often because prepare_command_line lacks a __init 
annotation or the annotation of parse_early_param is wrong.

WARNING: modpost: vmlinux.o(.text.unlikely+0x64d0): Section mismatch in reference from the function prepare_command_line() to the variable .init.data:command_line
The function prepare_command_line() references
the variable __initdata command_line.
This is often because prepare_command_line lacks a __initdata 
annotation or the annotation of command_line is wrong.

Introduced by commit

  8d48bf8206f7 ("x86/boot: Pull up cmdline preparation and early param parsing")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warnings in Linus' tree

[Borislav Petkov]

On Tue, Nov 23, 2021 at 09:44:19AM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> Building Linus' tree, today's linux-next build (x86_64 allmodconfig)
> produced these warnings:
> 
> WARNING: modpost: vmlinux.o(.text.unlikely+0x63df): Section mismatch in reference from the function prepare_command_line() to the variable .init.data:builtin_cmdline
> The function prepare_command_line() references
> the variable __initdata builtin_cmdline.
> This is often because prepare_command_line lacks a __initdata 
> annotation or the annotation of builtin_cmdline is wrong.

Doesn't trigger with my toolchain, because it simply inlines that
function.

Anyway, fix is trivial, thanks for reporting.

---
From 4f4226a7dce0c5b6d911574f7fa5870c4ee693ff Mon Sep 17 00:00:00 2001
From: Borislav Petkov <bp@suse.de>
Date: Tue, 23 Nov 2021 07:53:57 +0100
Subject: [PATCH] x86/boot: Mark prepare_command_line() __init

Fix:

  WARNING: modpost: vmlinux.o(.text.unlikely+0x64d0): Section mismatch in reference \
   from the function prepare_command_line() to the variable .init.data:command_line
  The function prepare_command_line() references
  the variable __initdata command_line.
  This is often because prepare_command_line lacks a __initdata
  annotation or the annotation of command_line is wrong.

Apparently some toolchains do different inlining decisions.

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Borislav Petkov <bp@suse.de>
Link: https://lore.kernel.org/r/20211123094419.08000327@canb.auug.org.au
---
 arch/x86/kernel/setup.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
index c410be738ae7..6a190c7f4d71 100644
--- a/arch/x86/kernel/setup.c
+++ b/arch/x86/kernel/setup.c
@@ -742,7 +742,7 @@ dump_kernel_offset(struct notifier_block *self, unsigned long v, void *p)
 	return 0;
 }
 
-static char *prepare_command_line(void)
+static char * __init prepare_command_line(void)
 {
 #ifdef CONFIG_CMDLINE_BOOL
 #ifdef CONFIG_CMDLINE_OVERRIDE
-- 
2.29.2

-- 
Regards/Gruss,
    Boris.

SUSE Software Solutions Germany GmbH, GF: Ivo Totev, HRB 36809, AG Nürnberg

linux-next: build warnings in Linus' tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 690 bytes --]

Hi all,

After merging the origin tree, today's linux-next build (arc
haps_hs_smp_defconfig+kselftest) produced these warnings:

arch/arc/include/asm/perf_event.h:126:27: warning: 'arc_pmu_cache_map' defined but not used [-Wunused-const-variable=]
arch/arc/include/asm/perf_event.h:91:27: warning: 'arc_pmu_ev_hw_map' defined but not used [-Wunused-const-variable=]

Introduced by commit

  0dd450fe13da ("ARC: Add perf support for ARC700 cores")

The 2 static arrays should be moved into arch/arc/kernel/perf_event.c
(the only place that uses them).  We get the warning because perf_event.h
is also included by arch/arc/kernel/unaligned.c.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warnings in Linus' tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 472 bytes --]

Hi all,

When building Linus' tree, today's linux-next build (htmldocs) produced
these warnings:

Error: Cannot open file drivers/counter/counter.c
Error: Cannot open file drivers/counter/counter.c

Introduced by commit

  d70e46af7531 ("counter: Internalize sysfs interface code")

$ git grep -w drivers/counter/counter.c Documentation
Documentation/driver-api/generic-counter.rst:.. kernel-doc:: drivers/counter/counter.c

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warnings in Linus' tree

[Randy Dunlap]

On 10/12/21 3:56 AM, Stephen Rothwell wrote:
> Hi all,
> 
> When building Linus' tree, today's linux-next build (htmldocs) produced
> these warnings:
> 
> Error: Cannot open file drivers/counter/counter.c
> Error: Cannot open file drivers/counter/counter.c
> 
> Introduced by commit
> 
>    d70e46af7531 ("counter: Internalize sysfs interface code")
> 
> $ git grep -w drivers/counter/counter.c Documentation
> Documentation/driver-api/generic-counter.rst:.. kernel-doc:: drivers/counter/counter.c
> 

Jonathan has already accepted my patch for this docs error.
Hopefully it will show up in mainline soonish.

thanks.
-- 
~Randy

linux-next: build warnings in Linus' tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 2696 bytes --]

Hi all,

After merging the origin tree, today's linux-next build (powerpc
allyesconfig) produced these warnings (along with many others):

arch/powerpc/boot/dts/mpc5200b.dtsi:267.20-280.4: Warning (pci_bridge): /pci@f0000d00: missing ranges for PCI bridge (or not a bridge)
arch/powerpc/boot/dts/mpc5200b.dtsi:267.20-280.4: Warning (pci_bridge): /pci@f0000d00: missing ranges for PCI bridge (or not a bridge)
arch/powerpc/boot/dts/mpc5200b.dtsi:267.20-280.4: Warning (pci_bridge): /pci@f0000d00: missing ranges for PCI bridge (or not a bridge)
arch/powerpc/boot/dts/mpc5200b.dtsi:267.20-280.4: Warning (pci_bridge): /pci@f0000d00: missing ranges for PCI bridge (or not a bridge)
arch/powerpc/boot/dts/mpc5200b.dtsi:182.18-186.5: Warning (spi_bus_bridge): /soc5200@f0000000/psc@2000: node name for SPI buses should be 'spi'
arch/powerpc/boot/dts/mpc5200b.dtsi:267.20-280.4: Warning (pci_bridge): /pci@f0000d00: missing ranges for PCI bridge (or not a bridge)
arch/powerpc/boot/dts/mpc5200b.dtsi:182.18-186.5: Warning (spi_bus_bridge): /soc5200@f0000000/psc@2000: node name for SPI buses should be 'spi'
arch/powerpc/boot/dts/mpc5200b.dtsi:267.20-280.4: Warning (pci_bridge): /pci@f0000d00: missing ranges for PCI bridge (or not a bridge)
arch/powerpc/boot/dts/mpc5200b.dtsi:182.18-186.5: Warning (spi_bus_bridge): /soc5200@f0000000/psc@2000: node name for SPI buses should be 'spi'
arch/powerpc/boot/dts/mpc5200b.dtsi:267.20-280.4: Warning (pci_bridge): /pci@f0000d00: missing ranges for PCI bridge (or not a bridge)
arch/powerpc/boot/dts/mpc5200b.dtsi:182.18-186.5: Warning (spi_bus_bridge): /soc5200@f0000000/psc@2000: node name for SPI buses should be 'spi'
arch/powerpc/boot/dts/mpc5200b.dtsi:267.20-280.4: Warning (pci_bridge): /pci@f0000d00: missing ranges for PCI bridge (or not a bridge)
arch/powerpc/boot/dts/mpc5200b.dtsi:182.18-186.5: Warning (spi_bus_bridge): /soc5200@f0000000/psc@2000: node name for SPI buses should be 'spi'
arch/powerpc/boot/dts/mpc5200b.dtsi:267.20-280.4: Warning (pci_bridge): /pci@f0000d00: missing ranges for PCI bridge (or not a bridge)
arch/powerpc/boot/dts/mpc5200b.dtsi:182.18-186.5: Warning (spi_bus_bridge): /soc5200@f0000000/psc@2000: node name for SPI buses should be 'spi'
arch/powerpc/boot/dts/mpc5200b.dtsi:267.20-280.4: Warning (pci_bridge): /pci@f0000d00: missing ranges for PCI bridge (or not a bridge)

Given that arch/powerpc/boot/dts/mpc5200b.dtsi is oncluded by several
other dts files, fixing this one file would go quite a long way to
silencing our allyesoncig build.  Unfotunatley, I have no idea how to
fix this file (ad maybe some fo the interactions it has with other files).

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warnings in Linus' tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 2919 bytes --]

Hi all,

[Cc'ing Rob]

Rob: these warnings have been there for a long time ...

On Fri, 8 Oct 2021 16:47:28 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
> 
> After merging the origin tree, today's linux-next build (powerpc
> allyesconfig) produced these warnings (along with many others):
> 
> arch/powerpc/boot/dts/mpc5200b.dtsi:267.20-280.4: Warning (pci_bridge): /pci@f0000d00: missing ranges for PCI bridge (or not a bridge)
> arch/powerpc/boot/dts/mpc5200b.dtsi:267.20-280.4: Warning (pci_bridge): /pci@f0000d00: missing ranges for PCI bridge (or not a bridge)
> arch/powerpc/boot/dts/mpc5200b.dtsi:267.20-280.4: Warning (pci_bridge): /pci@f0000d00: missing ranges for PCI bridge (or not a bridge)
> arch/powerpc/boot/dts/mpc5200b.dtsi:267.20-280.4: Warning (pci_bridge): /pci@f0000d00: missing ranges for PCI bridge (or not a bridge)
> arch/powerpc/boot/dts/mpc5200b.dtsi:182.18-186.5: Warning (spi_bus_bridge): /soc5200@f0000000/psc@2000: node name for SPI buses should be 'spi'
> arch/powerpc/boot/dts/mpc5200b.dtsi:267.20-280.4: Warning (pci_bridge): /pci@f0000d00: missing ranges for PCI bridge (or not a bridge)
> arch/powerpc/boot/dts/mpc5200b.dtsi:182.18-186.5: Warning (spi_bus_bridge): /soc5200@f0000000/psc@2000: node name for SPI buses should be 'spi'
> arch/powerpc/boot/dts/mpc5200b.dtsi:267.20-280.4: Warning (pci_bridge): /pci@f0000d00: missing ranges for PCI bridge (or not a bridge)
> arch/powerpc/boot/dts/mpc5200b.dtsi:182.18-186.5: Warning (spi_bus_bridge): /soc5200@f0000000/psc@2000: node name for SPI buses should be 'spi'
> arch/powerpc/boot/dts/mpc5200b.dtsi:267.20-280.4: Warning (pci_bridge): /pci@f0000d00: missing ranges for PCI bridge (or not a bridge)
> arch/powerpc/boot/dts/mpc5200b.dtsi:182.18-186.5: Warning (spi_bus_bridge): /soc5200@f0000000/psc@2000: node name for SPI buses should be 'spi'
> arch/powerpc/boot/dts/mpc5200b.dtsi:267.20-280.4: Warning (pci_bridge): /pci@f0000d00: missing ranges for PCI bridge (or not a bridge)
> arch/powerpc/boot/dts/mpc5200b.dtsi:182.18-186.5: Warning (spi_bus_bridge): /soc5200@f0000000/psc@2000: node name for SPI buses should be 'spi'
> arch/powerpc/boot/dts/mpc5200b.dtsi:267.20-280.4: Warning (pci_bridge): /pci@f0000d00: missing ranges for PCI bridge (or not a bridge)
> arch/powerpc/boot/dts/mpc5200b.dtsi:182.18-186.5: Warning (spi_bus_bridge): /soc5200@f0000000/psc@2000: node name for SPI buses should be 'spi'
> arch/powerpc/boot/dts/mpc5200b.dtsi:267.20-280.4: Warning (pci_bridge): /pci@f0000d00: missing ranges for PCI bridge (or not a bridge)
> 
> Given that arch/powerpc/boot/dts/mpc5200b.dtsi is oncluded by several
> other dts files, fixing this one file would go quite a long way to
> silencing our allyesoncig build.  Unfotunatley, I have no idea how to
> fix this file (ad maybe some fo the interactions it has with other files).

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warnings in Linus' tree

[Rob Herring]

+Arnd in regards to removing platforms.

On Sun, Oct 10, 2021 at 4:27 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> [Cc'ing Rob]
>
> Rob: these warnings have been there for a long time ...

If anyone cares about these platforms, then the warnings should be
fixed by folks that care. If not, then perhaps the DT files should
just get removed.

FYI, u-boot removed mpc5xxx support in 2017, so maybe there's
similarly not a need to keep them in the kernel? It does appear NXP
will still sell you the parts though the last BSP was 2009.

Rob

Re: linux-next: build warnings in Linus' tree

[Arnd Bergmann]

On Mon, Oct 11, 2021 at 10:42 PM Rob Herring <robh+dt@kernel.org> wrote:
> On Sun, Oct 10, 2021 at 4:27 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> FYI, u-boot removed mpc5xxx support in 2017, so maybe there's
> similarly not a need to keep them in the kernel? It does appear NXP
> will still sell you the parts though the last BSP was 2009.

Specifically, MPC5200B has a 15 year lifetime, which ends in
11 months from now. The original bplan/Genesi Efika 5K2 was
quite popular at the time it came out, and there are probably
still some of those hanging around, but they came with Open
Firmware rather than relying on the dts files that ship with the
kernel.

Grant Likely was the original maintainer for MPC52xx until 2011,
Anatolij Gustschin is still listed as maintainer since then but hasn't
been active in it for a while either. Anatolij can probably best judge
which of these boards are still in going to be used with future kernels,
but I suspect once you start removing bits from 52xx, the newer
but less common 512x platform can go away as well.

         Arnd

Re: linux-next: build warnings in Linus' tree

[Anatolij Gustschin]

Hi Arnd, Rob,

On Tue, 12 Oct 2021 16:39:56 +0200
Arnd Bergmann arnd@arndb.de wrote:
...
>Grant Likely was the original maintainer for MPC52xx until 2011,
>Anatolij Gustschin is still listed as maintainer since then but hasn't
>been active in it for a while either. Anatolij can probably best judge
>which of these boards are still in going to be used with future kernels,
>but I suspect once you start removing bits from 52xx, the newer
>but less common 512x platform can go away as well.

many of these boards are still used, i.e. o2d*, digsy_mtc, tqm5200.
I've sent first series to fix some warnings. Other dts fixes
require driver changes, so it will take some time to fix them.

Anatolij

Re: linux-next: build warnings in Linus' tree

[Rob Herring]

On Wed, Oct 13, 2021 at 5:12 PM Anatolij Gustschin <agust@denx.de> wrote:
>
> Hi Arnd, Rob,
>
> On Tue, 12 Oct 2021 16:39:56 +0200
> Arnd Bergmann arnd@arndb.de wrote:
> ...
> >Grant Likely was the original maintainer for MPC52xx until 2011,
> >Anatolij Gustschin is still listed as maintainer since then but hasn't
> >been active in it for a while either. Anatolij can probably best judge
> >which of these boards are still in going to be used with future kernels,
> >but I suspect once you start removing bits from 52xx, the newer
> >but less common 512x platform can go away as well.
>
> many of these boards are still used, i.e. o2d*, digsy_mtc, tqm5200.
> I've sent first series to fix some warnings. Other dts fixes
> require driver changes, so it will take some time to fix them.

In general, you shouldn't need to be changing the drivers. Can you
tell me which warnings need driver changes?

Rob

Re: linux-next: build warnings in Linus' tree

[Anatolij Gustschin]

On Wed, 13 Oct 2021 17:17:25 -0500
Rob Herring robh+dt@kernel.org wrote:
...
>In general, you shouldn't need to be changing the drivers. Can you
>tell me which warnings need driver changes?

ethernet and mdio drivers share registers, so they use same unit-address:

arch/powerpc/boot/dts/tqm5200.dts:127.17-133.5: Warning (unique_unit_address): /soc5200@f0000000/ethernet@3000: duplicate unit-address (also used in node /soc5200@f0000000/mdio@3000)

arch/powerpc/boot/dts/mpc5200b.dtsi:218.23-223.5: Warning (unique_unit_address): /soc5200@f0000000/ethernet@3000: duplicate unit-address (also used in node /soc5200@f0000000/mdio@3000)
  also defined at arch/powerpc/boot/dts/digsy_mtc.dts:60.17-62.5

Anatolij

Re: linux-next: build warnings in Linus' tree

[Rob Herring]

On Wed, Oct 13, 2021 at 5:28 PM Anatolij Gustschin <agust@denx.de> wrote:
>
> On Wed, 13 Oct 2021 17:17:25 -0500
> Rob Herring robh+dt@kernel.org wrote:
> ...
> >In general, you shouldn't need to be changing the drivers. Can you
> >tell me which warnings need driver changes?
>
> ethernet and mdio drivers share registers, so they use same unit-address:
>
> arch/powerpc/boot/dts/tqm5200.dts:127.17-133.5: Warning (unique_unit_address): /soc5200@f0000000/ethernet@3000: duplicate unit-address (also used in node /soc5200@f0000000/mdio@3000)
>
> arch/powerpc/boot/dts/mpc5200b.dtsi:218.23-223.5: Warning (unique_unit_address): /soc5200@f0000000/ethernet@3000: duplicate unit-address (also used in node /soc5200@f0000000/mdio@3000)
>   also defined at arch/powerpc/boot/dts/digsy_mtc.dts:60.17-62.5

Those are W=1 warnings and off by default. You shouldn't fix them if
it breaks compatibility with the driver.

Rob

Re: linux-next: build warnings in Linus' tree

[Arnd Bergmann]

On Thu, Oct 14, 2021 at 12:12 AM Anatolij Gustschin <agust@denx.de> wrote:
> On Tue, 12 Oct 2021 16:39:56 +0200
> Arnd Bergmann arnd@arndb.de wrote:
> ...
> >Grant Likely was the original maintainer for MPC52xx until 2011,
> >Anatolij Gustschin is still listed as maintainer since then but hasn't
> >been active in it for a while either. Anatolij can probably best judge
> >which of these boards are still in going to be used with future kernels,
> >but I suspect once you start removing bits from 52xx, the newer
> >but less common 512x platform can go away as well.
>
> many of these boards are still used, i.e. o2d*, digsy_mtc, tqm5200.

Just for clarification, I assume when you say "still used" that implies
getting updated to new kernels rather than just running the old BSPs,
right?

What are the typical distro release cycles for those machines
you list: do you move from one LTS kernel to the next each year,
or are they getting more sporadic over time?

Do you expect the machines with the lowest memory such as the
32MB digsy to stop getting kernel updates before the others?

> I've sent first series to fix some warnings. Other dts fixes
> require driver changes, so it will take some time to fix them.

Thanks!

      Arnd

Re: linux-next: build warnings in Linus' tree

[Anatolij Gustschin]

On Thu, 14 Oct 2021 10:44:46 +0200
Arnd Bergmann arnd@arndb.de wrote:

>On Thu, Oct 14, 2021 at 12:12 AM Anatolij Gustschin <agust@denx.de> wrote:
>> On Tue, 12 Oct 2021 16:39:56 +0200
>> Arnd Bergmann arnd@arndb.de wrote:
>> ...  
>> >Grant Likely was the original maintainer for MPC52xx until 2011,
>> >Anatolij Gustschin is still listed as maintainer since then but hasn't
>> >been active in it for a while either. Anatolij can probably best judge
>> >which of these boards are still in going to be used with future kernels,
>> >but I suspect once you start removing bits from 52xx, the newer
>> >but less common 512x platform can go away as well.  
>>
>> many of these boards are still used, i.e. o2d*, digsy_mtc, tqm5200.  
>
>Just for clarification, I assume when you say "still used" that implies
>getting updated to new kernels rather than just running the old BSPs,
>right?

yes, at least some of them. I used v5.4 kernel on digsy_mtc and
tqm5200 last year, and v5.10 kernel is also known to work.

>What are the typical distro release cycles for those machines
>you list: do you move from one LTS kernel to the next each year,
>or are they getting more sporadic over time?

these machines are in embedded systems and do not get regular
distro updates, therefore more sporadic over time.

>Do you expect the machines with the lowest memory such as the
>32MB digsy to stop getting kernel updates before the others?

No. There are also digsy variants with 256MiB DRAM.

Thanks,

Anatolij

linux-next: build warnings in Linus' tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1646 bytes --]

Hi all,

Building Linus' tree, today's linux-next build (x86_64 allmodconfig)
produced these warnings:

arch/x86/kernel/cpu/mce/core.o: warning: objtool: mce_panic()+0x2a3: unreachable instruction
net/core/skbuff.o: warning: objtool: skb_push.cold()+0x1b: unreachable instruction
arch/x86/mm/mmio-mod.o: warning: objtool: pre()+0x21a: unreachable instruction
arch/x86/kvm/vmx/vmx.o: warning: objtool: vmx_handle_exit_irqoff()+0x142: unreachable instruction
kernel/exit.o: warning: objtool: __x64_sys_exit_group()+0x26: unreachable instruction
kernel/cred.o: warning: objtool: get_task_cred.cold()+0x19: unreachable instruction
drivers/misc/sgi-gru/grukservices.o: warning: objtool: gru_wait_abort_proc()+0x97: unreachable instruction
drivers/scsi/pcmcia/aha152x_core.o: warning: objtool: is_complete()+0x6c6: unreachable instruction
drivers/message/fusion/mptbase.o: warning: objtool: mpt_SoftResetHandler()+0x4a5: unreachable instruction
drivers/scsi/aic7xxx/aic79xx_core.o: warning: objtool: ahd_intr()+0x2a9: unreachable instruction
drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.o: warning: objtool: otx2_sq_append_tso()+0xab6: unreachable instruction
fs/btrfs/extent_io.o: warning: objtool: __set_extent_bit.cold()+0x12: unreachable instruction
fs/btrfs/backref.o: warning: objtool: btrfs_backref_finish_upper_links()+0x818: unreachable instruction
fs/btrfs/relocation.o: warning: objtool: update_backref_cache.isra.0()+0x3bf: unreachable instruction
drivers/atm/horizon.o: warning: objtool: rx_data_av_handler()+0x452: unreachable instruction

I have not idea what caused them.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warnings in Linus' tree

[Josh Poimboeuf]

On Tue, Sep 08, 2020 at 09:11:02AM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> Building Linus' tree, today's linux-next build (x86_64 allmodconfig)
> produced these warnings:
> 
> arch/x86/kernel/cpu/mce/core.o: warning: objtool: mce_panic()+0x2a3: unreachable instruction
> net/core/skbuff.o: warning: objtool: skb_push.cold()+0x1b: unreachable instruction
> arch/x86/mm/mmio-mod.o: warning: objtool: pre()+0x21a: unreachable instruction
> arch/x86/kvm/vmx/vmx.o: warning: objtool: vmx_handle_exit_irqoff()+0x142: unreachable instruction
> kernel/exit.o: warning: objtool: __x64_sys_exit_group()+0x26: unreachable instruction
> kernel/cred.o: warning: objtool: get_task_cred.cold()+0x19: unreachable instruction
> drivers/misc/sgi-gru/grukservices.o: warning: objtool: gru_wait_abort_proc()+0x97: unreachable instruction
> drivers/scsi/pcmcia/aha152x_core.o: warning: objtool: is_complete()+0x6c6: unreachable instruction
> drivers/message/fusion/mptbase.o: warning: objtool: mpt_SoftResetHandler()+0x4a5: unreachable instruction
> drivers/scsi/aic7xxx/aic79xx_core.o: warning: objtool: ahd_intr()+0x2a9: unreachable instruction
> drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.o: warning: objtool: otx2_sq_append_tso()+0xab6: unreachable instruction
> fs/btrfs/extent_io.o: warning: objtool: __set_extent_bit.cold()+0x12: unreachable instruction
> fs/btrfs/backref.o: warning: objtool: btrfs_backref_finish_upper_links()+0x818: unreachable instruction
> fs/btrfs/relocation.o: warning: objtool: update_backref_cache.isra.0()+0x3bf: unreachable instruction
> drivers/atm/horizon.o: warning: objtool: rx_data_av_handler()+0x452: unreachable instruction

I suspect these will all be fixed by this livepatching pull request:

  https://lkml.kernel.org/r/20200907082036.GC8084@alley

-- 
Josh

Re: linux-next: build warnings in Linus' tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 2054 bytes --]

Hi Josh,

On Tue, 8 Sep 2020 08:14:39 -0500 Josh Poimboeuf <jpoimboe@redhat.com> wrote:
>
> On Tue, Sep 08, 2020 at 09:11:02AM +1000, Stephen Rothwell wrote:
> > 
> > Building Linus' tree, today's linux-next build (x86_64 allmodconfig)
> > produced these warnings:
> > 
> > arch/x86/kernel/cpu/mce/core.o: warning: objtool: mce_panic()+0x2a3: unreachable instruction
> > net/core/skbuff.o: warning: objtool: skb_push.cold()+0x1b: unreachable instruction
> > arch/x86/mm/mmio-mod.o: warning: objtool: pre()+0x21a: unreachable instruction
> > arch/x86/kvm/vmx/vmx.o: warning: objtool: vmx_handle_exit_irqoff()+0x142: unreachable instruction
> > kernel/exit.o: warning: objtool: __x64_sys_exit_group()+0x26: unreachable instruction
> > kernel/cred.o: warning: objtool: get_task_cred.cold()+0x19: unreachable instruction
> > drivers/misc/sgi-gru/grukservices.o: warning: objtool: gru_wait_abort_proc()+0x97: unreachable instruction
> > drivers/scsi/pcmcia/aha152x_core.o: warning: objtool: is_complete()+0x6c6: unreachable instruction
> > drivers/message/fusion/mptbase.o: warning: objtool: mpt_SoftResetHandler()+0x4a5: unreachable instruction
> > drivers/scsi/aic7xxx/aic79xx_core.o: warning: objtool: ahd_intr()+0x2a9: unreachable instruction
> > drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.o: warning: objtool: otx2_sq_append_tso()+0xab6: unreachable instruction
> > fs/btrfs/extent_io.o: warning: objtool: __set_extent_bit.cold()+0x12: unreachable instruction
> > fs/btrfs/backref.o: warning: objtool: btrfs_backref_finish_upper_links()+0x818: unreachable instruction
> > fs/btrfs/relocation.o: warning: objtool: update_backref_cache.isra.0()+0x3bf: unreachable instruction
> > drivers/atm/horizon.o: warning: objtool: rx_data_av_handler()+0x452: unreachable instruction  
> 
> I suspect these will all be fixed by this livepatching pull request:
> 
>   https://lkml.kernel.org/r/20200907082036.GC8084@alley

Yep, all but the vmx_handle_exit_irqoff() one as Linus noted.

Thanks.
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warnings in Linus' tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 2656 bytes --]

Hi all,

Today's linux-next build of Linus' tree (arm multi_v7_defconfig) produced
these warnings:

arch/arm/boot/dts/bcm2835-rpi.dtsi:18.4-15: Warning (dma_ranges_format): /soc/firmware:dma-ranges: empty "dma-ranges" property but its #address-cells (2) differs from /soc (1)
arch/arm/boot/dts/bcm2835-rpi.dtsi:18.4-15: Warning (dma_ranges_format): /soc/firmware:dma-ranges: empty "dma-ranges" property but its #address-cells (2) differs from /soc (1)
arch/arm/boot/dts/bcm2835-rpi.dtsi:18.4-15: Warning (dma_ranges_format): /soc/firmware:dma-ranges: empty "dma-ranges" property but its #address-cells (2) differs from /soc (1)
arch/arm/boot/dts/bcm2835-rpi.dtsi:18.4-15: Warning (dma_ranges_format): /soc/firmware:dma-ranges: empty "dma-ranges" property but its #address-cells (2) differs from /soc (1)
arch/arm/boot/dts/bcm2835-rpi.dtsi:18.4-15: Warning (dma_ranges_format): /soc/firmware:dma-ranges: empty "dma-ranges" property but its #address-cells (2) differs from /soc (1)
arch/arm/boot/dts/bcm2835-rpi.dtsi:18.4-15: Warning (dma_ranges_format): /soc/firmware:dma-ranges: empty "dma-ranges" property but its #address-cells (2) differs from /soc (1)
arch/arm/boot/dts/bcm2835-rpi.dtsi:18.4-15: Warning (dma_ranges_format): /soc/firmware:dma-ranges: empty "dma-ranges" property but its #address-cells (2) differs from /soc (1)
arch/arm/boot/dts/bcm2835-rpi.dtsi:18.4-15: Warning (dma_ranges_format): /soc/firmware:dma-ranges: empty "dma-ranges" property but its #address-cells (2) differs from /soc (1)
arch/arm/boot/dts/bcm2835-rpi.dtsi:18.4-15: Warning (dma_ranges_format): /soc/firmware:dma-ranges: empty "dma-ranges" property but its #address-cells (2) differs from /soc (1)
arch/arm/boot/dts/bcm2835-rpi.dtsi:18.4-15: Warning (dma_ranges_format): /soc/firmware:dma-ranges: empty "dma-ranges" property but its #address-cells (2) differs from /soc (1)
arch/arm/boot/dts/bcm2835-rpi.dtsi:18.4-15: Warning (dma_ranges_format): /soc/firmware:dma-ranges: empty "dma-ranges" property but its #address-cells (2) differs from /soc (1)
arch/arm/boot/dts/bcm2835-rpi.dtsi:18.4-15: Warning (dma_ranges_format): /soc/firmware:dma-ranges: empty "dma-ranges" property but its #address-cells (2) differs from /soc (1)
arch/arm/boot/dts/bcm2835-rpi.dtsi:18.4-15: Warning (dma_ranges_format): /soc/firmware:dma-ranges: empty "dma-ranges" property but its #address-cells (2) differs from /soc (1)
arch/arm/boot/dts/bcm2835-rpi.dtsi:18.4-15: Warning (dma_ranges_format): /soc/firmware:dma-ranges: empty "dma-ranges" property but its #address-cells (2) differs from /soc (1)

I have no idea what caused this :-(

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warnings in Linus' tree

[Rob Herring]

+Nicolas

On Fri, Apr 3, 2020 at 4:19 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> Today's linux-next build of Linus' tree (arm multi_v7_defconfig) produced
> these warnings:
>
> arch/arm/boot/dts/bcm2835-rpi.dtsi:18.4-15: Warning (dma_ranges_format): /soc/firmware:dma-ranges: empty "dma-ranges" property but its #address-cells (2) differs from /soc (1)
> arch/arm/boot/dts/bcm2835-rpi.dtsi:18.4-15: Warning (dma_ranges_format): /soc/firmware:dma-ranges: empty "dma-ranges" property but its #address-cells (2) differs from /soc (1)
> arch/arm/boot/dts/bcm2835-rpi.dtsi:18.4-15: Warning (dma_ranges_format): /soc/firmware:dma-ranges: empty "dma-ranges" property but its #address-cells (2) differs from /soc (1)
> arch/arm/boot/dts/bcm2835-rpi.dtsi:18.4-15: Warning (dma_ranges_format): /soc/firmware:dma-ranges: empty "dma-ranges" property but its #address-cells (2) differs from /soc (1)
> arch/arm/boot/dts/bcm2835-rpi.dtsi:18.4-15: Warning (dma_ranges_format): /soc/firmware:dma-ranges: empty "dma-ranges" property but its #address-cells (2) differs from /soc (1)
> arch/arm/boot/dts/bcm2835-rpi.dtsi:18.4-15: Warning (dma_ranges_format): /soc/firmware:dma-ranges: empty "dma-ranges" property but its #address-cells (2) differs from /soc (1)
> arch/arm/boot/dts/bcm2835-rpi.dtsi:18.4-15: Warning (dma_ranges_format): /soc/firmware:dma-ranges: empty "dma-ranges" property but its #address-cells (2) differs from /soc (1)
> arch/arm/boot/dts/bcm2835-rpi.dtsi:18.4-15: Warning (dma_ranges_format): /soc/firmware:dma-ranges: empty "dma-ranges" property but its #address-cells (2) differs from /soc (1)
> arch/arm/boot/dts/bcm2835-rpi.dtsi:18.4-15: Warning (dma_ranges_format): /soc/firmware:dma-ranges: empty "dma-ranges" property but its #address-cells (2) differs from /soc (1)
> arch/arm/boot/dts/bcm2835-rpi.dtsi:18.4-15: Warning (dma_ranges_format): /soc/firmware:dma-ranges: empty "dma-ranges" property but its #address-cells (2) differs from /soc (1)
> arch/arm/boot/dts/bcm2835-rpi.dtsi:18.4-15: Warning (dma_ranges_format): /soc/firmware:dma-ranges: empty "dma-ranges" property but its #address-cells (2) differs from /soc (1)
> arch/arm/boot/dts/bcm2835-rpi.dtsi:18.4-15: Warning (dma_ranges_format): /soc/firmware:dma-ranges: empty "dma-ranges" property but its #address-cells (2) differs from /soc (1)
> arch/arm/boot/dts/bcm2835-rpi.dtsi:18.4-15: Warning (dma_ranges_format): /soc/firmware:dma-ranges: empty "dma-ranges" property but its #address-cells (2) differs from /soc (1)
> arch/arm/boot/dts/bcm2835-rpi.dtsi:18.4-15: Warning (dma_ranges_format): /soc/firmware:dma-ranges: empty "dma-ranges" property but its #address-cells (2) differs from /soc (1)
>
> I have no idea what caused this :-(

A dtc update combined with changes that landed in the above file after
I tested and fixed the new warnings.

Rob

Re: linux-next: build warnings in Linus' tree

[Nicolas Saenz Julienne]

[-- Attachment #1: Type: text/plain, Size: 3358 bytes --]

Hi Rob, Stephen,

On Fri, 2020-04-03 at 17:16 -0600, Rob Herring wrote:
> +Nicolas
> 
> On Fri, Apr 3, 2020 at 4:19 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > Hi all,
> > 
> > Today's linux-next build of Linus' tree (arm multi_v7_defconfig) produced
> > these warnings:
> > 
> > arch/arm/boot/dts/bcm2835-rpi.dtsi:18.4-15: Warning (dma_ranges_format):
> > /soc/firmware:dma-ranges: empty "dma-ranges" property but its #address-
cells 
> > (2) differs from /soc (1)
> > arch/arm/boot/dts/bcm2835-rpi.dtsi:18.4-15: Warning (dma_ranges_format):
> > /soc/firmware:dma-ranges: empty "dma-ranges" property but its #address-
cells 
> > (2) differs from /soc (1)
> > arch/arm/boot/dts/bcm2835-rpi.dtsi:18.4-15: Warning (dma_ranges_format):
> > /soc/firmware:dma-ranges: empty "dma-ranges" property but its #address-
cells 
> > (2) differs from /soc (1)
> > arch/arm/boot/dts/bcm2835-rpi.dtsi:18.4-15: Warning (dma_ranges_format):
> > /soc/firmware:dma-ranges: empty "dma-ranges" property but its #address-
cells 
> > (2) differs from /soc (1)
> > arch/arm/boot/dts/bcm2835-rpi.dtsi:18.4-15: Warning (dma_ranges_format):
> > /soc/firmware:dma-ranges: empty "dma-ranges" property but its #address-
cells 
> > (2) differs from /soc (1)
> > arch/arm/boot/dts/bcm2835-rpi.dtsi:18.4-15: Warning (dma_ranges_format):
> > /soc/firmware:dma-ranges: empty "dma-ranges" property but its #address-
cells 
> > (2) differs from /soc (1)
> > arch/arm/boot/dts/bcm2835-rpi.dtsi:18.4-15: Warning (dma_ranges_format):
> > /soc/firmware:dma-ranges: empty "dma-ranges" property but its #address-
cells 
> > (2) differs from /soc (1)
> > arch/arm/boot/dts/bcm2835-rpi.dtsi:18.4-15: Warning (dma_ranges_format):
> > /soc/firmware:dma-ranges: empty "dma-ranges" property but its #address-
cells 
> > (2) differs from /soc (1)
> > arch/arm/boot/dts/bcm2835-rpi.dtsi:18.4-15: Warning (dma_ranges_format):
> > /soc/firmware:dma-ranges: empty "dma-ranges" property but its #address-
cells 
> > (2) differs from /soc (1)
> > arch/arm/boot/dts/bcm2835-rpi.dtsi:18.4-15: Warning (dma_ranges_format):
> > /soc/firmware:dma-ranges: empty "dma-ranges" property but its #address-
cells 
> > (2) differs from /soc (1)
> > arch/arm/boot/dts/bcm2835-rpi.dtsi:18.4-15: Warning (dma_ranges_format):
> > /soc/firmware:dma-ranges: empty "dma-ranges" property but its #address-
cells 
> > (2) differs from /soc (1)
> > arch/arm/boot/dts/bcm2835-rpi.dtsi:18.4-15: Warning (dma_ranges_format):
> > /soc/firmware:dma-ranges: empty "dma-ranges" property but its #address-
cells 
> > (2) differs from /soc (1)
> > arch/arm/boot/dts/bcm2835-rpi.dtsi:18.4-15: Warning (dma_ranges_format):
> > /soc/firmware:dma-ranges: empty "dma-ranges" property but its #address-
cells 
> > (2) differs from /soc (1)
> > arch/arm/boot/dts/bcm2835-rpi.dtsi:18.4-15: Warning (dma_ranges_format):
> > /soc/firmware:dma-ranges: empty "dma-ranges" property but its #address-
cells 
> > (2) differs from /soc (1)
> > 
> > I have no idea what caused this :-(
> 
> A dtc update combined with changes that landed in the above file after
> I tested and fixed the new warnings.

Sorry for the warnings. A fix is already making its way into the soc fixes
tree.

Here's the commit for reference: https://lkml.org/lkml/2020/3/26/445

Regards,
Nicolas


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warnings in Linus' tree

[Stephen Rothwell]

Hi Linus,

Today's linux-next build (x86_64 allmodconfig) produced these warnings:

WARNING: modpost: missing MODULE_LICENSE() in net/9p/9pnet_xen.o
WARNING: modpost: missing MODULE_LICENSE() in drivers/media/platform/mtk-vcodec/mtk-vcodec-common.o
WARNING: modpost: missing MODULE_LICENSE() in sound/soc/codecs/snd-soc-pcm512x-spi.o
WARNING: modpost: missing MODULE_LICENSE() in drivers/auxdisplay/img-ascii-lcd.o
WARNING: modpost: missing MODULE_LICENSE() in drivers/gpio/gpio-ath79.o
WARNING: modpost: missing MODULE_LICENSE() in drivers/gpio/gpio-iop.o
WARNING: modpost: missing MODULE_LICENSE() in drivers/iio/accel/kxsd9-i2c.o
WARNING: modpost: missing MODULE_LICENSE() in drivers/iio/adc/qcom-vadc-common.o
WARNING: modpost: missing MODULE_LICENSE() in drivers/media/platform/mtk-vcodec/mtk-vcodec-common.o
WARNING: modpost: missing MODULE_LICENSE() in drivers/media/platform/soc_camera/soc_scale_crop.o
WARNING: modpost: missing MODULE_LICENSE() in drivers/mtd/nand/denali_pci.o
WARNING: modpost: missing MODULE_LICENSE() in drivers/net/phy/cortina.o
WARNING: modpost: missing MODULE_LICENSE() in drivers/pinctrl/pxa/pinctrl-pxa2xx.o
WARNING: modpost: missing MODULE_LICENSE() in drivers/power/reset/zx-reboot.o
WARNING: modpost: missing MODULE_LICENSE() in drivers/rpmsg/qcom_glink_native.o
WARNING: modpost: missing MODULE_LICENSE() in drivers/staging/comedi/drivers/ni_atmio.o
WARNING: modpost: missing MODULE_LICENSE() in net/9p/9pnet_xen.o
WARNING: modpost: missing MODULE_LICENSE() in sound/soc/codecs/snd-soc-pcm512x-spi.o

Introduced by commit

  ba1029c9cbc5 ("modpost: detect modules without a MODULE_LICENSE")

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warnings in Linus' tree

[Linus Torvalds]

On Mon, Nov 13, 2017 at 1:52 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Linus,
>
> Today's linux-next build (x86_64 allmodconfig) produced these warnings:
>
> WARNING: modpost: missing MODULE_LICENSE() in net/9p/9pnet_xen.o
...

Yes. Very much expected. Hopefully the involved modules will get fixed
thanks to the warning.

At worst, we'll just match up the files in the SPDX database and just
add them before rc1. But I'd much rather see the actual maintainers
react to this.

               Linus

linux-next: build warnings in Linus' tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 697 bytes --]

Hi all,

Building Linus' tree, today's linux-next build (x86_64 allmodconfig)
produced this warning (these have been around for a while):

drivers/infiniband/hw/nes/nes_hw.c:81:23: warning: 'nes_iwarp_state_str' defined but not used [-Wunused-variable]
 static unsigned char *nes_iwarp_state_str[] = {
                       ^
drivers/infiniband/hw/nes/nes_hw.c:92:23: warning: 'nes_tcp_state_str' defined but not used [-Wunused-variable]
 static unsigned char *nes_tcp_state_str[] = {
                       ^

Introduced by commit bca1935ccdec ("RDMA/nes: Fix compilation error when
nes_debug is enabled").

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

RE: linux-next: build warnings in Linus' tree

[Nikolova, Tatyana E]

Hello Stephen,

Thank you for reporting the error. I removed these variables from the debug statement, because I didn't see that they were defined. It is possible that I manually enabled the nes_debug and the #ifdef CONFIG_INFINIBAND_NES_DEBUG statement these variables are enclosed in wasn't true, so I saw a compilation issue.

Feel free to revert the commit bca1935ccdec ("RDMA/nes: Fix compilation error when nes_debug is enabled") or I will submit a patch to address the issue next week.

Regards,
Tatyana

-----Original Message-----
From: Stephen Rothwell [mailto:sfr@canb.auug.org.au] 
Sent: Wednesday, July 03, 2013 11:59 PM
To: Roland Dreier
Cc: linux-next@vger.kernel.org; linux-kernel@vger.kernel.org; Nikolova, Tatyana E
Subject: linux-next: build warnings in Linus' tree

Hi all,

Building Linus' tree, today's linux-next build (x86_64 allmodconfig) produced this warning (these have been around for a while):

drivers/infiniband/hw/nes/nes_hw.c:81:23: warning: 'nes_iwarp_state_str' defined but not used [-Wunused-variable]  static unsigned char *nes_iwarp_state_str[] = {
                       ^
drivers/infiniband/hw/nes/nes_hw.c:92:23: warning: 'nes_tcp_state_str' defined but not used [-Wunused-variable]  static unsigned char *nes_tcp_state_str[] = {
                       ^

Introduced by commit bca1935ccdec ("RDMA/nes: Fix compilation error when nes_debug is enabled").

--
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

linux-next: build warnings in Linus' tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 593 bytes --]

Hi all,

After merging the fixes tree, today's linux-next build (powerpc
ppc64_defconfig) produced these warnings:

scripts/dtc/flattree.c: In function 'flat_read_mem_reserve':
scripts/dtc/flattree.c:700:14: warning: variable 'p' set but not used [-Wunused-but-set-variable]
scripts/dtc/dtc.c: In function 'main':
scripts/dtc/dtc.c:102:17: warning: variable 'check' set but not used [-Wunused-but-set-variable]

I am not sure why these have suddenly starting being reported.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

linux-next: build warnings in Linus' tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 641 bytes --]

Hi all,

After merging the origin tree, today's linux-next build (x86_64
allmodconfig) produced these warnings:

arch/x86/kernel/ftrace.c: In function 'ftrace_make_nop':
arch/x86/kernel/ftrace.c:308: warning: assignment discards qualifiers from pointer target type
arch/x86/kernel/ftrace.c: In function 'ftrace_make_call':
arch/x86/kernel/ftrace.c:318: warning: assignment discards qualifiers from pointer target type

Introduced by commit dc326fca2b64 ("x86, cpu: Clean up and unify the NOP
selection infrastructure").

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build warnings in Linus' tree

[Eduardo Silva]

On Sun, May 22, 2011 at 9:25 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi all,
>
> After merging the origin tree, today's linux-next build (x86_64
> allmodconfig) produced these warnings:
>
> arch/x86/kernel/ftrace.c: In function 'ftrace_make_nop':
> arch/x86/kernel/ftrace.c:308: warning: assignment discards qualifiers from pointer target type
> arch/x86/kernel/ftrace.c: In function 'ftrace_make_call':
> arch/x86/kernel/ftrace.c:318: warning: assignment discards qualifiers from pointer target type

discussing ftrace.c warnings on this thread:

   https://lkml.org/lkml/2011/5/22/158

regards,


>
> Introduced by commit dc326fca2b64 ("x86, cpu: Clean up and unify the NOP
> selection infrastructure").
>
> --
> Cheers,
> Stephen Rothwell                    sfr@canb.auug.org.au
> http://www.canb.auug.org.au/~sfr/
>



-- 
Eduardo Silva
http://edsiper.linuxchile.cl
http://www.monkey-project.com

linux-next: build warnings in Linus' tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 784 bytes --]

Hi all,

After merging the Linus tree, today's linux-next build (x86_64
allmodconfig) produced these warnings:

drivers/nfc/pn544.c: In function 'pn544_read':
drivers/nfc/pn544.c:356: warning: comparison of distinct pointer types lacks a cast
drivers/nfc/pn544.c:377: warning: comparison of distinct pointer types lacks a cast
drivers/nfc/pn544.c: In function 'pn544_write':
drivers/nfc/pn544.c:463: warning: comparison of distinct pointer types lacks a cast
drivers/nfc/pn544.c:485: warning: comparison of distinct pointer types lacks a cast

Introduced by commit 0329326e85aaa30fb8d427828c718d565c287385 ("NFC:
Driver for NXP Semiconductors PN544 NFC chip").

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

linux-next: build warnings in Linus' tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 9253 bytes --]

Hi all,

[This is deliberately long ...]

While building Linus' tree, today's linux-next build (x86_64
allmodconfig) produced these warnings:

drivers/i2c/muxes/gpio-i2cmux.c: In function 'gpiomux_probe':
drivers/i2c/muxes/gpio-i2cmux.c:101: warning: ignoring return value of 'gpio_direction_output', declared with attribute warn_unused_result
drivers/leds/leds-bd2802.c: In function 'bd2802_probe':
drivers/leds/leds-bd2802.c:700: warning: ignoring return value of 'gpio_request', declared with attribute warn_unused_result
drivers/leds/leds-bd2802.c:701: warning: ignoring return value of 'gpio_direction_output', declared with attribute warn_unused_result
drivers/input/mouse/gpio_mouse.c: In function 'gpio_mouse_probe':
drivers/input/mouse/gpio_mouse.c:93: warning: ignoring return value of 'gpio_direction_input', declared with attribute warn_unused_result
sound/soc/codecs/tlv320aic3x.c: In function 'aic3x_probe':
sound/soc/codecs/tlv320aic3x.c:1385: warning: ignoring return value of 'gpio_direction_output', declared with attribute warn_unused_result
drivers/i2c/busses/i2c-gpio.c: In function 'i2c_gpio_setsda_dir':
drivers/i2c/busses/i2c-gpio.c:26: warning: ignoring return value of 'gpio_direction_input', declared with attribute warn_unused_result
drivers/i2c/busses/i2c-gpio.c:28: warning: ignoring return value of 'gpio_direction_output', declared with attribute warn_unused_result
drivers/i2c/busses/i2c-gpio.c: In function 'i2c_gpio_setscl_dir':
drivers/i2c/busses/i2c-gpio.c:49: warning: ignoring return value of 'gpio_direction_input', declared with attribute warn_unused_result
drivers/i2c/busses/i2c-gpio.c:51: warning: ignoring return value of 'gpio_direction_output', declared with attribute warn_unused_result
drivers/i2c/busses/i2c-gpio.c: In function 'i2c_gpio_probe':
drivers/i2c/busses/i2c-gpio.c:108: warning: ignoring return value of 'gpio_direction_output', declared with attribute warn_unused_result
drivers/i2c/busses/i2c-gpio.c:111: warning: ignoring return value of 'gpio_direction_input', declared with attribute warn_unused_result
drivers/i2c/busses/i2c-gpio.c:116: warning: ignoring return value of 'gpio_direction_output', declared with attribute warn_unused_result
drivers/i2c/busses/i2c-gpio.c:119: warning: ignoring return value of 'gpio_direction_input', declared with attribute warn_unused_result
drivers/input/keyboard/matrix_keypad.c: In function '__activate_col':
drivers/input/keyboard/matrix_keypad.c:54: warning: ignoring return value of 'gpio_direction_output', declared with attribute warn_unused_result
drivers/input/keyboard/matrix_keypad.c:57: warning: ignoring return value of 'gpio_direction_input', declared with attribute warn_unused_result
drivers/input/keyboard/matrix_keypad.c: In function 'init_matrix_gpio':
drivers/input/keyboard/matrix_keypad.c:317: warning: ignoring return value of 'gpio_direction_output', declared with attribute warn_unused_result
drivers/input/keyboard/matrix_keypad.c:329: warning: ignoring return value of 'gpio_direction_input', declared with attribute warn_unused_result
sound/soc/codecs/tlv320dac33.c: In function 'dac33_i2c_probe':
sound/soc/codecs/tlv320dac33.c:1563: warning: ignoring return value of 'gpio_direction_output', declared with attribute warn_unused_result
drivers/input/touchscreen/cy8ctmg110_ts.c: In function 'cy8ctmg110_power':
drivers/input/touchscreen/cy8ctmg110_ts.c:71: warning: ignoring return value of 'gpio_direction_output', declared with attribute warn_unused_result
sound/soc/codecs/tpa6130a2.c: In function 'tpa6130a2_probe':
sound/soc/codecs/tpa6130a2.c:402: warning: ignoring return value of 'gpio_direction_output', declared with attribute warn_unused_result
drivers/i2c/busses/i2c-pca-platform.c: In function 'i2c_pca_pf_probe':
drivers/i2c/busses/i2c-pca-platform.c:216: warning: ignoring return value of 'gpio_direction_output', declared with attribute warn_unused_result
drivers/media/radio/si4713-i2c.c: In function 'si4713_probe':
drivers/media/radio/si4713-i2c.c:2018: warning: ignoring return value of 'gpio_direction_output', declared with attribute warn_unused_result
drivers/hwmon/sht15.c: In function 'sht15_connection_reset':
drivers/hwmon/sht15.c:128: warning: ignoring return value of 'gpio_direction_output', declared with attribute warn_unused_result
drivers/hwmon/sht15.c: In function 'sht15_transmission_start':
drivers/hwmon/sht15.c:166: warning: ignoring return value of 'gpio_direction_output', declared with attribute warn_unused_result
drivers/hwmon/sht15.c: In function 'sht15_wait_for_response':
drivers/hwmon/sht15.c:202: warning: ignoring return value of 'gpio_direction_input', declared with attribute warn_unused_result
drivers/hwmon/sht15.c: In function 'sht15_update_single_val':
drivers/hwmon/sht15.c:248: warning: ignoring return value of 'gpio_direction_input', declared with attribute warn_unused_result
drivers/hwmon/sht15.c: In function 'sht15_ack':
drivers/hwmon/sht15.c:414: warning: ignoring return value of 'gpio_direction_output', declared with attribute warn_unused_result
drivers/hwmon/sht15.c:422: warning: ignoring return value of 'gpio_direction_input', declared with attribute warn_unused_result
drivers/hwmon/sht15.c: In function 'sht15_end_transmission':
drivers/hwmon/sht15.c:432: warning: ignoring return value of 'gpio_direction_output', declared with attribute warn_unused_result
drivers/hwmon/sht15.c: In function 'sht15_probe':
drivers/hwmon/sht15.c:563: warning: ignoring return value of 'gpio_direction_output', declared with attribute warn_unused_result
drivers/regulator/max8952.c: In function 'max8952_pmic_probe':
drivers/regulator/max8952.c:228: warning: ignoring return value of 'gpio_direction_output', declared with attribute warn_unused_result
drivers/regulator/max8952.c:246: warning: ignoring return value of 'gpio_direction_output', declared with attribute warn_unused_result
drivers/regulator/max8952.c:252: warning: ignoring return value of 'gpio_direction_output', declared with attribute warn_unused_result
drivers/rtc/rtc-v3020.c: In function 'v3020_gpio_map':
drivers/rtc/rtc-v3020.c:132: warning: ignoring return value of 'gpio_direction_output', declared with attribute warn_unused_result
drivers/rtc/rtc-v3020.c: In function 'v3020_gpio_write_bit':
drivers/rtc/rtc-v3020.c:156: warning: ignoring return value of 'gpio_direction_output', declared with attribute warn_unused_result
drivers/rtc/rtc-v3020.c: In function 'v3020_gpio_read_bit':
drivers/rtc/rtc-v3020.c:168: warning: ignoring return value of 'gpio_direction_input', declared with attribute warn_unused_result
drivers/usb/otg/gpio_vbus.c: In function 'gpio_vbus_probe':
drivers/usb/otg/gpio_vbus.c:249: warning: ignoring return value of 'gpio_direction_input', declared with attribute warn_unused_result
drivers/usb/otg/gpio_vbus.c:270: warning: ignoring return value of 'gpio_direction_output', declared with attribute warn_unused_result
drivers/w1/masters/w1-gpio.c: In function 'w1_gpio_write_bit_dir':
drivers/w1/masters/w1-gpio.c:27: warning: ignoring return value of 'gpio_direction_input', declared with attribute warn_unused_result
drivers/w1/masters/w1-gpio.c:29: warning: ignoring return value of 'gpio_direction_output', declared with attribute warn_unused_result
drivers/w1/masters/w1-gpio.c: In function 'w1_gpio_probe':
drivers/w1/masters/w1-gpio.c:67: warning: ignoring return value of 'gpio_direction_output', declared with attribute warn_unused_result
drivers/w1/masters/w1-gpio.c:70: warning: ignoring return value of 'gpio_direction_input', declared with attribute warn_unused_result
drivers/net/phy/mdio-gpio.c: In function 'mdio_dir':
drivers/net/phy/mdio-gpio.c:48: warning: ignoring return value of 'gpio_direction_output', declared with attribute warn_unused_result
drivers/net/phy/mdio-gpio.c:50: warning: ignoring return value of 'gpio_direction_input', declared with attribute warn_unused_result
drivers/net/phy/mdio-gpio.c: In function 'mdio_gpio_bus_init':
drivers/net/phy/mdio-gpio.c:126: warning: ignoring return value of 'gpio_direction_output', declared with attribute warn_unused_result
drivers/media/video/via-camera.c: In function 'via_sensor_power_setup':
drivers/media/video/via-camera.c:208: warning: ignoring return value of 'gpio_direction_output', declared with attribute warn_unused_result
drivers/media/video/via-camera.c:209: warning: ignoring return value of 'gpio_direction_output', declared with attribute warn_unused_result
drivers/net/wireless/p54/p54spi.c: In function 'p54spi_probe':
drivers/net/wireless/p54/p54spi.c:641: warning: ignoring return value of 'gpio_direction_output', declared with attribute warn_unused_result
drivers/net/wireless/p54/p54spi.c:642: warning: ignoring return value of 'gpio_direction_input', declared with attribute warn_unused_result

Introduced by commit 0fdae42d361bbb431ca0ab0efed5126a94821177 ("gpiolib:
annotate gpio-intialization with __must_check").

We used to try to fix most of the bad code *before* introducing these
warnings ... this is just making it much harder to see "real" warnings.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build warnings in Linus' tree

[Andrew Morton]

On Fri, 14 Jan 2011 11:09:52 +1100
Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> drivers/net/wireless/p54/p54spi.c:642: warning: ignoring return value of 'gpio_direction_input', declared with attribute warn_unused_result
> 
> Introduced by commit 0fdae42d361bbb431ca0ab0efed5126a94821177 ("gpiolib:
> annotate gpio-intialization with __must_check").

Complete brainfart - I meant to drop that patch ages ago.

Re: linux-next: build warnings in Linus' tree

[Greg KH]

On Thu, Jan 13, 2011 at 04:17:00PM -0800, Andrew Morton wrote:
> On Fri, 14 Jan 2011 11:09:52 +1100
> Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> 
> > drivers/net/wireless/p54/p54spi.c:642: warning: ignoring return value of 'gpio_direction_input', declared with attribute warn_unused_result
> > 
> > Introduced by commit 0fdae42d361bbb431ca0ab0efed5126a94821177 ("gpiolib:
> > annotate gpio-intialization with __must_check").
> 
> Complete brainfart - I meant to drop that patch ages ago.

Ick, yeah, that patch isn't ok to go in as-is, all of the callers need
to be fixed up first, which is what I thought we had agreed on...

thanks,

greg k-h

linux-next: build warnings in Linus' tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 768 bytes --]

Hi all,

today's linux-next build (x86_64 allmodconfig) of Linus' tree produced
these warnings:

drivers/scsi/qla4xxx/ql4_nx.c: In function 'qla4_8xxx_get_flash_info':
drivers/scsi/qla4xxx/ql4_nx.c:1952: warning: 'mid' may be used uninitialized in this function
drivers/scsi/qla4xxx/ql4_nx.c:1952: note: 'mid' was declared here
drivers/scsi/qla4xxx/ql4_nx.c:1952: warning: 'fid' may be used uninitialized in this function
drivers/scsi/qla4xxx/ql4_nx.c:1952: note: 'fid' was declared here

Introduced by commit f4f5df23bf72208d0c2f1d8be629839924c2f4c2 ("[SCSI]
qla4xxx: Added support for ISP82XX").  I don't think that these are false
positives.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

RE: linux-next: build warnings in Linus' tree

[Vikas Chaudhary]

>-----Original Message-----
>From: Stephen Rothwell [mailto:sfr@canb.auug.org.au]
>Sent: Saturday, August 07, 2010 7:51 AM
>To: Vikas Chaudhary
>Cc: linux-next@vger.kernel.org; linux-kernel@vger.kernel.org; Karen
>Higgins; Ravi Anand; James Bottomley
>Subject: linux-next: build warnings in Linus' tree
>
>Hi all,
>
>today's linux-next build (x86_64 allmodconfig) of Linus' tree produced
>these warnings:
>
>drivers/scsi/qla4xxx/ql4_nx.c: In function 'qla4_8xxx_get_flash_info':
>drivers/scsi/qla4xxx/ql4_nx.c:1952: warning: 'mid' may be used
>uninitialized in this function
>drivers/scsi/qla4xxx/ql4_nx.c:1952: note: 'mid' was declared here
>drivers/scsi/qla4xxx/ql4_nx.c:1952: warning: 'fid' may be used
>uninitialized in this function
>drivers/scsi/qla4xxx/ql4_nx.c:1952: note: 'fid' was declared here
>
>Introduced by commit f4f5df23bf72208d0c2f1d8be629839924c2f4c2 ("[SCSI]
>qla4xxx: Added support for ISP82XX").  I don't think that these are false
>positives.
>

Yes, Sorry. I am sending patch in next mail on top of latest
scsi-misc-2.6 tree to fix this warning. 

>--
>Cheers,
>Stephen Rothwell                    sfr@canb.auug.org.au
>http://www.canb.auug.org.au/~sfr/