From: Julien Thierry <jthierry@redhat.com>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: linux-kernel@vger.kernel.org, peterz@infradead.org,
mbenes@suse.cz, raphael.gault@arm.com, benh@kernel.crashing.org
Subject: Re: [PATCH v2 1/3] objtool: check: Fully validate the stack frame
Date: Tue, 13 Oct 2020 13:12:37 +0100 [thread overview]
Message-ID: <1283e5a8-67e3-090c-0904-3d03ae10a178@redhat.com> (raw)
In-Reply-To: <20201012153500.owcyvgjv4m3t3nh3@treble>
On 10/12/20 4:35 PM, Josh Poimboeuf wrote:
> On Mon, Oct 12, 2020 at 11:21:49AM +0100, Julien Thierry wrote:
>> On 9/29/20 8:18 PM, Josh Poimboeuf wrote:
>>> "Stack frame" has more than one meaning now, I suppose. i.e. it could
>>> also include the callee-saved registers and any other stack space
>>> allocated by the function.
>>>
>>> Would "call frame" be clearer?
>>>
>>> CALL_FRAME_BP_OFFSET
>>> CALL_FRAME_RA_OFFSET
>>>
>>> ?
>>
>> I would've thought that the call-frame could include the stackframe + other
>> callee saved regs.
>
> Hm, probably so.
>
>> Whereas stackframe tends to used for the caller's frame pointer +
>> return address (i.e. what allows unwinding). Unless I'm getting lost
>> with things.
>
> I've always seen "stack frame" used to indicate the function's entire
> stack.
>
>> And if call frame is associated with the region starting from the stack
>> pointer at the parent call point (since this is what CFA is), then it
>> shouldn't be associated with the framepointer + return address structure
>> since this could be anywhere on the call frame (not at a fixed offset) as
>> long as the new frame pointer points to the structure.
>
> I suppose "call frame" and "stack frame" probably mean the same thing,
> in which case neither is appropriate here...
>
> In fact, maybe we could forget the concept of a frame (or even a struct)
> here.
>
> If cfa.base is CFI_BP, then is regs[CFI_BP].offset always the same as
> -cfa.offset? i.e. could the BP checks could it just be a simple
>
> regs[CFI_BP].offset == -cfa.offset
>
> check?
>
I guess that makes sense. If the above was no true it would mean that BP
is not pointing to the unwind information.
> And then is RA at regs[CFI_BP].offset + 8?
>
In the case of aarch64, the saved frame pointer and return address
appear in the same order as on x86_64. So that would work. If that can
make things simpler for now I can go with that.
Thanks for the suggestion.
--
Julien Thierry
next prev parent reply other threads:[~2020-10-13 12:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-28 9:36 [PATCH v2 0/3] objtool: Extend CFA updating/checking Julien Thierry
2020-09-28 9:36 ` [PATCH v2 1/3] objtool: check: Fully validate the stack frame Julien Thierry
2020-09-29 19:18 ` Josh Poimboeuf
2020-10-12 10:21 ` Julien Thierry
2020-10-12 15:35 ` Josh Poimboeuf
2020-10-13 12:12 ` Julien Thierry [this message]
2020-09-28 9:36 ` [PATCH v2 2/3] objtool: check: Support addition to set CFA base Julien Thierry
2020-09-28 9:36 ` [PATCH v2 3/3] objtool: check: Make SP memory operation match PUSH/POP semantics Julien Thierry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1283e5a8-67e3-090c-0904-3d03ae10a178@redhat.com \
--to=jthierry@redhat.com \
--cc=benh@kernel.crashing.org \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=peterz@infradead.org \
--cc=raphael.gault@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).