From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: linaro-kernel@lists.linaro.org, patches@linaro.org,
cpufreq@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 00/35] cpufreq: Introduce cpufreq_table_validate_and_show()
Date: Thu, 08 Aug 2013 16:00:50 +0200 [thread overview]
Message-ID: <12886440.vo6SHbG01c@vostro.rjw.lan> (raw)
In-Reply-To: <cover.1375964117.git.viresh.kumar@linaro.org>
On Thursday, August 08, 2013 07:18:02 PM Viresh Kumar wrote:
> This is actually part of a bigger patchset which will change declaration of
> cpufreq_driver->target() to include index instead of target_freq and relation
> and hence cpufreq drivers wouldn't require to cpufreq_frequency_table_target()
> anymore.
>
> Almost every cpufreq driver is required to validate its frequency table with:
> cpufreq_frequency_table_cpuinfo() and then expose it to cpufreq core with:
> cpufreq_frequency_table_get_attr().
>
> This patch creates another helper routine cpufreq_table_validate_and_show() that
> will do both these steps in a single call and will return 0 for success, error
> otherwise.
>
> This also fixes potential bugs in cpufreq drivers where people have called
> cpufreq_frequency_table_get_attr() before calling
> cpufreq_frequency_table_cpuinfo(), as the later may fail.
>
> Viresh Kumar (35):
> cpufreq: Add new helper cpufreq_table_validate_and_show()
> cpufreq: pxa: call cpufreq_frequency_table_get_attr()
> cpufreq: s3cx4xx: call cpufreq_frequency_table_get_attr()
> cpufreq: sparc: call cpufreq_frequency_table_get_attr()
> cpufreq: acpi-cpufreq: use cpufreq_table_validate_and_show()
> cpufreq: arm_big_little: use cpufreq_table_validate_and_show()
> cpufreq: blackfin: use cpufreq_table_validate_and_show()
> cpufreq: cpufreq-cpu0: use cpufreq_table_validate_and_show()
> cpufreq: cris: use cpufreq_table_validate_and_show()
> cpufreq: davinci: use cpufreq_table_validate_and_show()
> cpufreq: dbx500: use cpufreq_table_validate_and_show()
> cpufreq: e_powersaver: use cpufreq_table_validate_and_show()
> cpufreq: elanfreq: use cpufreq_table_validate_and_show()
> cpufreq: exynos: use cpufreq_table_validate_and_show()
> cpufreq: ia64-acpi: use cpufreq_table_validate_and_show()
> cpufreq: imx6q: use cpufreq_table_validate_and_show()
> cpufreq: kirkwood: use cpufreq_table_validate_and_show()
> cpufreq: longhaul: use cpufreq_table_validate_and_show()
> cpufreq: loongson2: use cpufreq_table_validate_and_show()
> cpufreq: maple: use cpufreq_table_validate_and_show()
> cpufreq: omap: use cpufreq_table_validate_and_show()
> cpufreq: p4-clockmod: use cpufreq_table_validate_and_show()
> cpufreq: pasemi: use cpufreq_table_validate_and_show()
> cpufreq: pmac: use cpufreq_table_validate_and_show()
> cpufreq: powernow: use cpufreq_table_validate_and_show()
> cpufreq: ppc: use cpufreq_table_validate_and_show()
> cpufreq: pxa: use cpufreq_table_validate_and_show()
> cpufreq: s3cx4xx: use cpufreq_table_validate_and_show()
> cpufreq: s5pv210: use cpufreq_table_validate_and_show()
> cpufreq: sc520: use cpufreq_table_validate_and_show()
> cpufreq: sh: use cpufreq_table_validate_and_show()
> cpufreq: sparc: use cpufreq_table_validate_and_show()
> cpufreq: spear: use cpufreq_table_validate_and_show()
> cpufreq: speedstep: use cpufreq_table_validate_and_show()
> cpufreq: tegra: use cpufreq_table_validate_and_show()
>
> drivers/cpufreq/acpi-cpufreq.c | 4 +---
> drivers/cpufreq/arm_big_little.c | 4 +---
> drivers/cpufreq/blackfin-cpufreq.c | 3 +--
> drivers/cpufreq/cpufreq-cpu0.c | 4 +---
> drivers/cpufreq/cris-artpec3-cpufreq.c | 10 +---------
> drivers/cpufreq/cris-etraxfs-cpufreq.c | 10 +---------
> drivers/cpufreq/davinci-cpufreq.c | 6 ++----
> drivers/cpufreq/dbx500-cpufreq.c | 6 ++----
> drivers/cpufreq/e_powersaver.c | 3 +--
> drivers/cpufreq/elanfreq.c | 8 +-------
> drivers/cpufreq/exynos-cpufreq.c | 4 +---
> drivers/cpufreq/exynos5440-cpufreq.c | 4 +---
> drivers/cpufreq/freq_table.c | 12 ++++++++++++
> drivers/cpufreq/ia64-acpi-cpufreq.c | 4 +---
> drivers/cpufreq/imx6q-cpufreq.c | 3 +--
> drivers/cpufreq/kirkwood-cpufreq.c | 10 +---------
> drivers/cpufreq/longhaul.c | 8 +-------
> drivers/cpufreq/loongson2_cpufreq.c | 5 +----
> drivers/cpufreq/maple-cpufreq.c | 4 +---
> drivers/cpufreq/omap-cpufreq.c | 4 +---
> drivers/cpufreq/p4-clockmod.c | 3 +--
> drivers/cpufreq/pasemi-cpufreq.c | 4 +---
> drivers/cpufreq/pmac32-cpufreq.c | 3 +--
> drivers/cpufreq/pmac64-cpufreq.c | 4 +---
> drivers/cpufreq/powernow-k6.c | 9 +--------
> drivers/cpufreq/powernow-k7.c | 4 +---
> drivers/cpufreq/powernow-k8.c | 4 +---
> drivers/cpufreq/ppc-corenet-cpufreq.c | 3 +--
> drivers/cpufreq/ppc_cbe_cpufreq.c | 4 +---
> drivers/cpufreq/pxa2xx-cpufreq.c | 8 +++++---
> drivers/cpufreq/pxa3xx-cpufreq.c | 2 +-
> drivers/cpufreq/s3c2416-cpufreq.c | 4 +---
> drivers/cpufreq/s3c24xx-cpufreq.c | 2 +-
> drivers/cpufreq/s3c64xx-cpufreq.c | 2 +-
> drivers/cpufreq/s5pv210-cpufreq.c | 4 +---
> drivers/cpufreq/sc520_freq.c | 9 +--------
> drivers/cpufreq/sh-cpufreq.c | 6 +++---
> drivers/cpufreq/sparc-us2e-cpufreq.c | 2 +-
> drivers/cpufreq/sparc-us3-cpufreq.c | 2 +-
> drivers/cpufreq/spear-cpufreq.c | 5 ++---
> drivers/cpufreq/speedstep-centrino.c | 10 +---------
> drivers/cpufreq/speedstep-ich.c | 9 +--------
> drivers/cpufreq/speedstep-smi.c | 8 +-------
> drivers/cpufreq/tegra-cpufreq.c | 4 +---
> include/linux/cpufreq.h | 2 ++
> 45 files changed, 66 insertions(+), 167 deletions(-)
I'm not going to take this for 3.12, sorry. Please resend in the 3.12-rc1 /
3.12-rc2 time frame.
Thanks,
Rafael
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
next prev parent reply other threads:[~2013-08-08 13:50 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-08 13:48 [PATCH 00/35] cpufreq: Introduce cpufreq_table_validate_and_show() Viresh Kumar
2013-08-08 13:48 ` [PATCH 01/35] cpufreq: Add new helper cpufreq_table_validate_and_show() Viresh Kumar
2013-08-08 13:48 ` [PATCH 02/35] cpufreq: pxa: call cpufreq_frequency_table_get_attr() Viresh Kumar
2013-08-08 13:48 ` [PATCH 03/35] cpufreq: s3cx4xx: " Viresh Kumar
2013-08-08 13:48 ` [PATCH 04/35] cpufreq: sparc: " Viresh Kumar
2013-08-08 13:48 ` [PATCH 05/35] cpufreq: acpi-cpufreq: use cpufreq_table_validate_and_show() Viresh Kumar
2013-08-08 13:48 ` [PATCH 06/35] cpufreq: arm_big_little: " Viresh Kumar
2013-08-08 13:48 ` [PATCH 07/35] cpufreq: blackfin: " Viresh Kumar
2013-08-08 13:48 ` [PATCH 08/35] cpufreq: cpufreq-cpu0: " Viresh Kumar
2013-08-12 7:35 ` Shawn Guo
2013-08-12 7:49 ` Viresh Kumar
2013-08-08 13:48 ` [PATCH 09/35] cpufreq: cris: " Viresh Kumar
2013-08-08 13:48 ` [PATCH 10/35] cpufreq: davinci: " Viresh Kumar
2013-08-08 13:48 ` [PATCH 11/35] cpufreq: dbx500: " Viresh Kumar
2013-08-14 19:36 ` Linus Walleij
2013-08-08 13:48 ` [PATCH 12/35] cpufreq: e_powersaver: " Viresh Kumar
2013-08-08 13:48 ` [PATCH 13/35] cpufreq: elanfreq: " Viresh Kumar
2013-08-08 13:48 ` [PATCH 14/35] cpufreq: exynos: " Viresh Kumar
2013-08-08 13:48 ` [PATCH 15/35] cpufreq: ia64-acpi: " Viresh Kumar
2013-08-08 13:48 ` [PATCH 16/35] cpufreq: imx6q: " Viresh Kumar
2013-08-08 13:48 ` [PATCH 17/35] cpufreq: kirkwood: " Viresh Kumar
2013-08-08 14:16 ` Andrew Lunn
2013-08-08 13:48 ` [PATCH 18/35] cpufreq: longhaul: " Viresh Kumar
2013-08-08 13:48 ` [PATCH 19/35] cpufreq: loongson2: " Viresh Kumar
2013-08-08 13:48 ` [PATCH 20/35] cpufreq: maple: " Viresh Kumar
2013-08-08 13:48 ` [PATCH 21/35] cpufreq: omap: " Viresh Kumar
2013-08-08 14:19 ` Santosh Shilimkar
2013-08-08 13:48 ` [PATCH 22/35] cpufreq: p4-clockmod: " Viresh Kumar
2013-08-08 13:48 ` [PATCH 23/35] cpufreq: pasemi: " Viresh Kumar
2013-08-08 13:48 ` [PATCH 24/35] cpufreq: pmac: " Viresh Kumar
2013-08-08 13:48 ` [PATCH 25/35] cpufreq: powernow: " Viresh Kumar
2013-08-08 13:48 ` [PATCH 26/35] cpufreq: ppc: " Viresh Kumar
2013-08-08 13:48 ` [PATCH 27/35] cpufreq: pxa: " Viresh Kumar
2013-08-08 13:48 ` [PATCH 28/35] cpufreq: s3cx4xx: " Viresh Kumar
2013-08-08 13:48 ` [PATCH 29/35] cpufreq: s5pv210: " Viresh Kumar
2013-08-08 13:48 ` [PATCH 30/35] cpufreq: sc520: " Viresh Kumar
2013-08-08 13:48 ` [PATCH 31/35] cpufreq: sh: " Viresh Kumar
2013-08-08 13:48 ` [PATCH 32/35] cpufreq: sparc: " Viresh Kumar
2013-08-08 13:48 ` [PATCH 33/35] cpufreq: spear: " Viresh Kumar
2013-08-08 13:48 ` [PATCH 34/35] cpufreq: speedstep: " Viresh Kumar
2013-08-08 13:48 ` [PATCH 35/35] cpufreq: tegra: " Viresh Kumar
2013-08-08 15:44 ` Stephen Warren
2013-08-08 16:07 ` Viresh Kumar
2013-08-09 4:04 ` Viresh Kumar
2013-08-09 16:19 ` Stephen Warren
2013-08-09 17:09 ` Viresh Kumar
2013-08-09 22:08 ` Stephen Warren
2013-08-10 2:53 ` Viresh Kumar
2013-08-12 16:33 ` Stephen Warren
2013-08-12 17:01 ` Viresh Kumar
2013-08-08 14:00 ` Rafael J. Wysocki [this message]
2013-08-08 13:53 ` [PATCH 00/35] cpufreq: Introduce cpufreq_table_validate_and_show() Viresh Kumar
2013-08-08 14:06 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12886440.vo6SHbG01c@vostro.rjw.lan \
--to=rjw@sisk.pl \
--cc=cpufreq@vger.kernel.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=patches@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).