From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932141Ab0KJR3I (ORCPT ); Wed, 10 Nov 2010 12:29:08 -0500 Received: from canuck.infradead.org ([134.117.69.58]:49340 "EHLO canuck.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932115Ab0KJR27 convert rfc822-to-8bit (ORCPT ); Wed, 10 Nov 2010 12:28:59 -0500 Subject: Re: [RFC][PATCH 02/22] sched: add extended scheduling interface From: Peter Zijlstra To: Raistlin Cc: Ingo Molnar , Thomas Gleixner , Steven Rostedt , Chris Friesen , oleg@redhat.com, Frederic Weisbecker , Darren Hart , Johan Eker , "p.faure" , linux-kernel , Claudio Scordino , michael trimarchi , Fabio Checconi , Tommaso Cucinotta , Juri Lelli , Nicola Manica , Luca Abeni , Dhaval Giani , Harald Gustafsson , paulmck In-Reply-To: <1288333622.8661.141.camel@Palantir> References: <1288333128.8661.137.camel@Palantir> <1288333622.8661.141.camel@Palantir> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Date: Wed, 10 Nov 2010 18:28:34 +0100 Message-ID: <1289410114.2084.23.camel@laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2010-10-29 at 08:27 +0200, Raistlin wrote: > +struct sched_param_ex { > + int sched_priority; > + struct timespec sched_runtime; > + struct timespec sched_deadline; > + struct timespec sched_period; > + unsigned int sched_flags; > + > + struct timespec curr_runtime; > + struct timespec used_runtime; > + struct timespec curr_deadline; > +}; It would be better for alignment reasons to move the sched_flags field next to the sched_priority field. I would suggest we add at least one more field so we can implement the stochastic model from UNC, sched_runtime_dev or sched_runtime_var or somesuch.