From: Samuel Ortiz <samuel@sortiz.org>
To: Joe Perches <joe@perches.com>
Cc: Jiri Kosina <trivial@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 05/11] drivers/net/irda: Remove unnecessary casts of pci_get_drvdata
Date: Tue, 16 Nov 2010 12:27:55 +0100 [thread overview]
Message-ID: <1289906875.7016.1.camel@sortiz-mobl> (raw)
In-Reply-To: <11b30b9512bf0438efaf70d6c0a819756dbf0e2f.1289851770.git.joe@perches.com>
Hi Joe,
On Mon, 2010-11-15 at 12:13 -0800, Joe Perches wrote:
> Signed-off-by: Joe Perches <joe@perches.com>
Thanks, I'll apply it to my irda tree.
Cheers,
Samuel.
> ---
> drivers/net/irda/donauboe.c | 6 +++---
> drivers/net/irda/vlsi_ir.c | 2 +-
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/irda/donauboe.c b/drivers/net/irda/donauboe.c
> index b626ccc..bee5ccc 100644
> --- a/drivers/net/irda/donauboe.c
> +++ b/drivers/net/irda/donauboe.c
> @@ -1488,7 +1488,7 @@ static void
> toshoboe_close (struct pci_dev *pci_dev)
> {
> int i;
> - struct toshoboe_cb *self = (struct toshoboe_cb*)pci_get_drvdata(pci_dev);
> + struct toshoboe_cb *self = pci_get_drvdata(pci_dev);
>
> IRDA_DEBUG (4, "%s()\n", __func__);
>
> @@ -1698,7 +1698,7 @@ freeself:
> static int
> toshoboe_gotosleep (struct pci_dev *pci_dev, pm_message_t crap)
> {
> - struct toshoboe_cb *self = (struct toshoboe_cb*)pci_get_drvdata(pci_dev);
> + struct toshoboe_cb *self = pci_get_drvdata(pci_dev);
> unsigned long flags;
> int i = 10;
>
> @@ -1727,7 +1727,7 @@ toshoboe_gotosleep (struct pci_dev *pci_dev, pm_message_t crap)
> static int
> toshoboe_wakeup (struct pci_dev *pci_dev)
> {
> - struct toshoboe_cb *self = (struct toshoboe_cb*)pci_get_drvdata(pci_dev);
> + struct toshoboe_cb *self = pci_get_drvdata(pci_dev);
> unsigned long flags;
>
> IRDA_DEBUG (4, "%s()\n", __func__);
> diff --git a/drivers/net/irda/vlsi_ir.c b/drivers/net/irda/vlsi_ir.c
> index c3d0738..62f2d12 100644
> --- a/drivers/net/irda/vlsi_ir.c
> +++ b/drivers/net/irda/vlsi_ir.c
> @@ -542,7 +542,7 @@ static int vlsi_process_rx(struct vlsi_ring *r, struct ring_descr *rd)
> int crclen, len = 0;
> struct sk_buff *skb;
> int ret = 0;
> - struct net_device *ndev = (struct net_device *)pci_get_drvdata(r->pdev);
> + struct net_device *ndev = pci_get_drvdata(r->pdev);
> vlsi_irda_dev_t *idev = netdev_priv(ndev);
>
> pci_dma_sync_single_for_cpu(r->pdev, rd_get_addr(rd), r->len, r->dir);
next prev parent reply other threads:[~2010-11-16 11:28 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-15 20:13 [PATCH 00/11] Remove unnecessary casts of pci_get_drvdata Joe Perches
2010-11-15 20:13 ` [PATCH 01/11] drivers/i2c/busses/i2c-nforce2.c: " Joe Perches
2010-11-15 21:06 ` Jean Delvare
2010-11-15 20:13 ` [PATCH 02/11] drivers/ide/pmac.c: " Joe Perches
2010-11-22 19:38 ` David Miller
2010-11-15 20:13 ` [PATCH 03/11] drivers/media/dvb/ngene/ngene-core.c: " Joe Perches
2010-11-15 20:13 ` [PATCH 04/11] drivers/misc/ibmasm/module.c: " Joe Perches
2010-11-15 20:13 ` [PATCH 05/11] drivers/net/irda: " Joe Perches
2010-11-16 11:27 ` Samuel Ortiz [this message]
2010-11-15 20:13 ` [PATCH 06/11] drivers/net/s2io.c: " Joe Perches
2010-11-17 20:28 ` David Miller
2010-11-15 20:13 ` [PATCH 07/11] drivers/net/vxge/vxge-main.c: " Joe Perches
2010-11-15 22:50 ` Jon Mason
2010-11-17 20:28 ` David Miller
2010-11-15 20:13 ` [PATCH 08/11] drivers/scsi/be2iscsi/be_main.c: " Joe Perches
2010-11-15 20:14 ` [PATCH 09/11] drivers/staging: " Joe Perches
2010-11-15 20:14 ` [PATCH 10/11] drivers/usb/host/uhci-hcd.c: " Joe Perches
2010-11-15 20:54 ` Alan Stern
2010-11-15 20:14 ` [PATCH 11/11] sound/pci/asihpi/hpioctl.c: " Joe Perches
2010-11-22 6:44 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1289906875.7016.1.camel@sortiz-mobl \
--to=samuel@sortiz.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).