From: Peter Zijlstra <peterz@infradead.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Huang Ying <ying.huang@intel.com>, Len Brown <lenb@kernel.org>,
linux-kernel@vger.kernel.org, Andi Kleen <andi@firstfloor.org>,
linux-acpi@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
Mauro Carvalho Chehab <mchehab@redhat.com>,
Chris Mason <chris.mason@oracle.com>,
Jens Axboe <jaxboe@fusionio.com>
Subject: Re: [PATCH -v4 0/2] Lockless memory allocator and list
Date: Tue, 16 Nov 2010 19:04:09 +0100 [thread overview]
Message-ID: <1289930649.2109.640.camel@laptop> (raw)
In-Reply-To: <AANLkTime3Sh2TbgCGKir=t_TBNsd5fHipEqQwa4bVJuY@mail.gmail.com>
On Tue, 2010-11-16 at 08:38 -0800, Linus Torvalds wrote:
>
> I kind of like the lock-less list implementation (it could easily be
> useful for random things, and it's very simple).
Yes, there's various implementations floating around, and we already
have one in-kernel ( net/rds/xlist.h ), mason and axboe and me have been
kicking around various patches using that thing in other circumstances
as well.
[ At some point we had perf -- what now is kernel/irq_work.c -- using
it as well, but the new code grew too complex due to requirements
from Huang ]
> And I don't think the
> notion of a lockless memory allocator is wrong either, although it
> looks a lot more specialized than the list thing (the solution to
> lockless allocations is generally simply to do them ahead of time).
>
Right, I don't generally object to lockless things, but they either need
to be 1) faster than the existing code, and/or 2) have a very convincing
use-case (other than performance) for their added complexity.
Afaict the proposed patch adds lots more LOCK'ed instructions into that
allocator path than it removes, ie its a slow down for existing users.
next prev parent reply other threads:[~2010-11-16 18:04 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-16 0:53 [PATCH -v4 0/2] Lockless memory allocator and list Huang Ying
2010-11-16 0:53 ` [PATCH -v4 1/2] lib, Make gen_pool memory allocator lockless Huang Ying
2010-11-16 21:50 ` Andrew Morton
2010-11-17 2:18 ` Huang Ying
2010-11-17 2:35 ` Andrew Morton
2010-11-17 3:03 ` Huang Ying
2010-11-17 3:57 ` Andrew Morton
2010-11-17 6:05 ` Huang Ying
2010-11-17 10:49 ` Peter Zijlstra
2010-11-17 11:16 ` huang ying
2010-11-17 11:38 ` Peter Zijlstra
2010-11-17 10:40 ` Peter Zijlstra
2010-11-17 11:47 ` huang ying
2010-11-17 11:53 ` Peter Zijlstra
2010-11-18 1:14 ` Huang Ying
2010-11-18 8:34 ` Peter Zijlstra
2010-11-18 8:43 ` Paul Mundt
2010-11-18 8:57 ` Peter Zijlstra
2010-11-18 9:03 ` Paul Mundt
2010-11-16 0:53 ` [PATCH -v4 2/2] lib, Add lock-less NULL terminated single list Huang Ying
2010-11-16 11:50 ` Peter Zijlstra
2010-11-16 16:33 ` Linus Torvalds
2010-11-16 11:49 ` [PATCH -v4 0/2] Lockless memory allocator and list Peter Zijlstra
2010-11-16 16:38 ` Linus Torvalds
2010-11-16 18:04 ` Peter Zijlstra [this message]
2010-11-17 1:45 ` Huang Ying
2010-11-17 1:03 ` Huang Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1289930649.2109.640.camel@laptop \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=chris.mason@oracle.com \
--cc=jaxboe@fusionio.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@redhat.com \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).