[RFC][PATCH v2] irq_work: Drop cmpxchg result

* [RFC][PATCH v2] irq_work: Drop cmpxchg result
@ 2010-11-16 18:02 Sergio Aguirre
  2010-11-16 18:16 ` Eric Dumazet
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Sergio Aguirre @ 2010-11-16 18:02 UTC (permalink / raw)
  To: LKML
  Cc: Sergio Aguirre, Huang Ying, Martin Schwidefsky, Ingo Molnar,
	Kyle McMartin, Peter Zijlstra

This solves this compilation warning:

kernel/irq_work.c: In function 'irq_work_run':
kernel/irq_work.c:148: warning: value computed is not used

Signed-off-by: Sergio Aguirre <saaguirre@ti.com>
Cc: Huang Ying <ying.huang@intel.com>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Kyle McMartin <kyle@mcmartin.ca>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
---

Changelog:
v2 - Keep ignoring the cmpxchg return value, as pointed
     out by Peter Zijlstra, and update patch subject/description

v1 - Initial version
     (found here: https://patchwork.kernel.org/patch/328662/)

 kernel/irq_work.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/kernel/irq_work.c b/kernel/irq_work.c
index f16763f..90f8819 100644
--- a/kernel/irq_work.c
+++ b/kernel/irq_work.c
@@ -145,7 +145,9 @@ void irq_work_run(void)
 		 * Clear the BUSY bit and return to the free state if
 		 * no-one else claimed it meanwhile.
 		 */
-		cmpxchg(&entry->next, next_flags(NULL, IRQ_WORK_BUSY), NULL);
+		(void)cmpxchg(&entry->next,
+			      next_flags(NULL, IRQ_WORK_BUSY),
+			      NULL);
 	}
 }
 EXPORT_SYMBOL_GPL(irq_work_run);
-- 
1.7.0.4


^ permalink raw reply related	[flat|nested] 5+ messages in thread