From: Yicong Yang <yangyicong@hisilicon.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: <gregkh@linuxfoundation.org>, <jdelvare@suse.com>,
<giometti@enneenne.com>, <abbotti@mev.co.uk>,
<hsweeten@visionengravers.com>, <kw@linux.com>,
<helgaas@kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-pm@vger.kernel.org>, <linux-hwmon@vger.kernel.org>,
<devel@driverdev.osuosl.org>, <linux-kbuild@vger.kernel.org>,
<masahiroy@kernel.org>, <michal.lkml@markovi.net>,
<prime.zeng@huawei.com>, <linuxarm@openeuler.org>
Subject: Re: [PATCH v2 2/4] hwmon: Use subdir-ccflags-* to inherit debug flag
Date: Wed, 10 Feb 2021 17:42:01 +0800 [thread overview]
Message-ID: <128d71da-b07b-237c-d6a5-205513f3b093@hisilicon.com> (raw)
In-Reply-To: <20210209150658.GA31002@roeck-us.net>
On 2021/2/9 23:06, Guenter Roeck wrote:
> On Tue, Feb 09, 2021 at 07:08:17PM +0800, Yicong Yang wrote:
>> From: Junhao He <hejunhao2@hisilicon.com>
>>
>> We use ccflags-$(CONFIG_HWMON_DEBUG_CHIP) for the debug
>> message in drivers/hwmon, but the DEBUG flag will not pass to
>> the subdirectory.
>>
>> Considering CONFIG_HWMON_DEBUG_CHIP intends to have DEBUG
>> recursively in driver/hwmon. It will be clearer
>> to use subdir-ccflags-* instead of ccflags-* to inherit
>> the debug settings from Kconfig when traversing subdirectories,
>> and it will avoid omittance of DEBUG define when debug messages
>> added in the subdirectories.
>>
>
> The above paragraph doesn't add clarity and may as well be dropped.
> On the other side, the commit message still doesn't mention that
> pr_debug depends on DEBUG, which I am sure many people don't know
> or remember. This is the prime reason why this patch is acceptable,
> so it most definitely needs to be mentioned here.
sorry, i didn't realize that you mean this. will impove this in the next
version after the lunar new year holiday over.
Thanks,
Yicong
>
> Guenter
>
>> Suggested-by: Bjorn Helgaas <bhelgaas@google.com>
>> Signed-off-by: Junhao He <hejunhao2@hisilicon.com>
>> Signed-off-by: Yicong Yang <yangyicong@hisilicon.com>
>> ---
>> drivers/hwmon/Makefile | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/hwmon/Makefile b/drivers/hwmon/Makefile
>> index 09a86c5..1c0c089 100644
>> --- a/drivers/hwmon/Makefile
>> +++ b/drivers/hwmon/Makefile
>> @@ -201,5 +201,5 @@ obj-$(CONFIG_SENSORS_XGENE) += xgene-hwmon.o
>> obj-$(CONFIG_SENSORS_OCC) += occ/
>> obj-$(CONFIG_PMBUS) += pmbus/
>>
>> -ccflags-$(CONFIG_HWMON_DEBUG_CHIP) := -DDEBUG
>> +subdir-ccflags-$(CONFIG_HWMON_DEBUG_CHIP) := -DDEBUG
>>
>> --
>> 2.8.1
>>
>
> .
>
next prev parent reply other threads:[~2021-02-10 9:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-09 11:08 [PATCH v2 0/4] Use subdir-ccflags-* to inherit debug flag Yicong Yang
2021-02-09 11:08 ` [PATCH v2 1/4] driver core: " Yicong Yang
2021-02-09 11:08 ` [PATCH v2 2/4] hwmon: " Yicong Yang
2021-02-09 15:06 ` Guenter Roeck
2021-02-10 9:42 ` Yicong Yang [this message]
2021-02-09 11:08 ` [PATCH v2 3/4] pps: " Yicong Yang
2021-02-09 12:26 ` Rodolfo Giometti
2021-02-09 11:08 ` [PATCH v2 4/4] staging: comedi: " Yicong Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=128d71da-b07b-237c-d6a5-205513f3b093@hisilicon.com \
--to=yangyicong@hisilicon.com \
--cc=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=giometti@enneenne.com \
--cc=gregkh@linuxfoundation.org \
--cc=helgaas@kernel.org \
--cc=hsweeten@visionengravers.com \
--cc=jdelvare@suse.com \
--cc=kw@linux.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=linuxarm@openeuler.org \
--cc=masahiroy@kernel.org \
--cc=michal.lkml@markovi.net \
--cc=prime.zeng@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).