From: Joe Perches <joe@perches.com>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Nick Piggin <npiggin@kernel.dk>, Rik van Riel <riel@redhat.com>,
Lee Schermerhorn <Lee.Schermerhorn@hp.com>
Subject: Re: [RFC][PATCH 02/10] mm: Remove likely() from mapping_unevictable()
Date: Thu, 09 Dec 2010 23:06:32 -0800 [thread overview]
Message-ID: <1291964792.24978.3.camel@Joe-Laptop> (raw)
In-Reply-To: <20101210160115.C7C4.A69D9226@jp.fujitsu.com>
On Fri, 2010-12-10 at 16:00 +0900, KOSAKI Motohiro wrote:
> > [ Resending to Nick's real email ]
> >
> >
> > From: Steven Rostedt <srostedt@redhat.com>
> >
> > The mapping_unevictable() has a likely() around the mapping parameter.
> > diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h
[]
> > static inline int mapping_unevictable(struct address_space *mapping)
> > {
> > - if (likely(mapping))
> > + if (mapping)
> > return test_bit(AS_UNEVICTABLE, &mapping->flags);
> > return !!mapping;
> > }
> I think you are right.
> Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
It'd be better to use
if (!mapping)
return 0;
return test_bit(AS_UNEVICTABLE, &mapping->flags);
to avoid the unnecessary !!
next prev parent reply other threads:[~2010-12-10 7:06 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-07 1:58 [RFC][PATCH 00/10] incorrect unlikely() and likely() cleanups Steven Rostedt
2010-12-07 1:58 ` [RFC][PATCH 01/10] sched: Change rt_task(prev) in pre_schedule_rt to likely Steven Rostedt
2010-12-07 3:25 ` Yong Zhang
2010-12-07 3:32 ` Steven Rostedt
2010-12-07 1:58 ` [RFC][PATCH 02/10] mm: Remove likely() from mapping_unevictable() Steven Rostedt
2010-12-07 2:22 ` Steven Rostedt
2010-12-07 7:02 ` Nick Piggin
2010-12-07 13:06 ` Steven Rostedt
2010-12-07 16:26 ` Rik van Riel
2010-12-10 7:00 ` KOSAKI Motohiro
2010-12-10 7:06 ` Joe Perches [this message]
2010-12-10 8:08 ` Miles Bader
2010-12-11 0:09 ` Steven Rostedt
2010-12-07 1:58 ` [RFC][PATCH 03/10] workqueue: It is likely that WORKER_NOT_RUNNING is true Steven Rostedt
2010-12-07 9:49 ` Tejun Heo
2010-12-07 13:07 ` Steven Rostedt
2010-12-11 0:08 ` Steven Rostedt
2010-12-11 0:09 ` Tejun Heo
2010-12-11 0:12 ` Steven Rostedt
2010-12-07 1:58 ` [RFC][PATCH 04/10] sched: Change pick_next_task_rt from unlikely to likely Steven Rostedt
2010-12-07 2:46 ` Gregory Haskins
2010-12-07 2:59 ` Steven Rostedt
2010-12-11 0:07 ` Steven Rostedt
2010-12-07 1:58 ` [RFC][PATCH 05/10] mm: Remove likely() from grab_cache_page_write_begin() Steven Rostedt
2010-12-07 2:24 ` Steven Rostedt
2010-12-07 6:56 ` Nick Piggin
2010-12-07 1:58 ` [RFC][PATCH 06/10] sched: Remove unlikely() from rt_policy() in sched.c Steven Rostedt
2010-12-07 1:58 ` [RFC][PATCH 07/10] x86: Remove unlikey()s from sched_switch segment tests Steven Rostedt
2010-12-07 1:58 ` [RFC][PATCH 08/10] fs: Remove unlikely() from fput_light() Steven Rostedt
2010-12-07 1:58 ` [RFC][PATCH 09/10] fs: Remove unlikely() from fget_light() Steven Rostedt
2010-12-07 1:58 ` [RFC][PATCH 10/10] sched: Remove unlikely() from ttwu_post_activation Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1291964792.24978.3.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=Lee.Schermerhorn@hp.com \
--cc=akpm@linux-foundation.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=npiggin@kernel.dk \
--cc=riel@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).