From: Vivek Goyal <vgoyal@redhat.com>
To: linux-kernel@vger.kernel.org, jaxboe@fusionio.com,
paulmck@linux.vnet.ibm.com
Cc: vgoyal@redhat.com, oleg@redhat.com
Subject: [PATCH 0/2] blk-throttle: Couple of more fixes
Date: Wed, 15 Dec 2010 16:07:33 -0500 [thread overview]
Message-ID: <1292447255-10698-1-git-send-email-vgoyal@redhat.com> (raw)
Hi Jens,
Please find attached couple of more fixes for blk-throttle code. These are
based on top of "for-linus" branch of your block tree.
Oleg had pointed out couple of race conditions in cgroup weight update code.
I think these race conditions are hard to hit and not disastrous so I would
not be too concerned about pushing these patches in 2.6.37 and can queue
up for 2.6.38.
Paul,
Based on discussion in other mail thread, I have used xchg() based
implementation for updating and processing limtis. Can you please have a look
if it is correct implementation and do I need any ACCESS_ONCE() or barriers
somewhere. If this implementation is not correct then I can go back to atomic
variable based implementation as suggested by you in other mail thread.
Appreciate the help.
Thanks
Vivek
Vivek Goyal (2):
blk-throttle: process limit change only through one function
blk-throttle: Some cleanups and race fixes in limit update code
block/blk-throttle.c | 104 ++++++++++++++++++++------------------------------
1 files changed, 41 insertions(+), 63 deletions(-)
next reply other threads:[~2010-12-15 21:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-15 21:07 Vivek Goyal [this message]
2010-12-15 21:07 ` [PATCH 1/2] blk-throttle: process limit change only through one function Vivek Goyal
2010-12-15 21:07 ` [PATCH 2/2] blk-throttle: Some cleanups and race fixes in limit update code Vivek Goyal
2010-12-16 14:49 ` Oleg Nesterov
2010-12-17 22:28 ` Paul E. McKenney
2010-12-17 22:34 ` Vivek Goyal
2011-03-29 23:14 ` [PATCH] blk-throttle: don't call xchg on bool Andreas Schwab
2011-03-30 10:21 ` Jens Axboe
2011-03-30 13:19 ` Vivek Goyal
2011-03-30 13:51 ` Andreas Schwab
2011-03-30 16:53 ` Vivek Goyal
2011-03-30 16:06 ` Andreas Schwab
2010-12-21 16:05 ` [PATCH 0/2] blk-throttle: Couple of more fixes Vivek Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1292447255-10698-1-git-send-email-vgoyal@redhat.com \
--to=vgoyal@redhat.com \
--cc=jaxboe@fusionio.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).