From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751612AbdINOH6 (ORCPT <rfc822;w@1wt.eu>);
        Thu, 14 Sep 2017 10:07:58 -0400
Received: from aserp1040.oracle.com ([141.146.126.69]:43132 "EHLO
        aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751366AbdINOH5 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 14 Sep 2017 10:07:57 -0400
Subject: Re: [PATCH] xen: don't compile pv-specific parts if XEN_PV isn't
 configured
To: Juergen Gross <jgross@suse.com>, linux-kernel@vger.kernel.org,
        xen-devel@lists.xenproject.org
References: <20170914123858.1167-1-jgross@suse.com>
 <fa4b3a38-7447-0168-0afd-4a9aa1c98050@oracle.com>
 <c9aa6af9-9314-653e-b2a4-0581bef5f55a@suse.com>
Cc: julien.grall@arm.com, tycho@docker.com
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Message-ID: <1295de3b-efa9-538f-6afd-c1d0b1849dea@oracle.com>
Date: Thu, 14 Sep 2017 10:07:34 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <c9aa6af9-9314-653e-b2a4-0581bef5f55a@suse.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-Source-IP: aserv0022.oracle.com [141.146.126.234]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


>> Did you make any changes in xenbus_map_ring_valloc_pv()? I don't see any
>> but the diff looks pretty big --- I'd expect only the preprocessor
>> directives to show up.
> I moved the functions to require only one #ifdef (plus 1 for setting
> the pv variants).

Oh, OK, I didn't notice that.

Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>