From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01F8DC4321D for ; Mon, 20 Aug 2018 08:56:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B454C213A2 for ; Mon, 20 Aug 2018 08:56:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B454C213A2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=windriver.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726481AbeHTMLj (ORCPT ); Mon, 20 Aug 2018 08:11:39 -0400 Received: from mail5.windriver.com ([192.103.53.11]:44734 "EHLO mail5.wrs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726010AbeHTMLi (ORCPT ); Mon, 20 Aug 2018 08:11:38 -0400 Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail5.wrs.com (8.15.2/8.15.2) with ESMTPS id w7K8uT24006167 (version=TLSv1 cipher=AES128-SHA bits=128 verify=FAIL); Mon, 20 Aug 2018 01:56:29 -0700 Received: from [128.224.162.216] (128.224.162.216) by ALA-HCA.corp.ad.wrs.com (147.11.189.50) with Microsoft SMTP Server (TLS) id 14.3.399.0; Mon, 20 Aug 2018 01:56:28 -0700 Subject: Re: [PATCH v2 1/2] x86: corruption-check: Passing memory_corruption_check to command line causes panic To: , , , , , , , References: <1534260823-87917-1-git-send-email-zhe.he@windriver.com> From: He Zhe Message-ID: <129aaffb-7f8d-cf84-cf2d-8e95e303908a@windriver.com> Date: Mon, 20 Aug 2018 16:56:22 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1534260823-87917-1-git-send-email-zhe.he@windriver.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [128.224.162.216] Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Could you please provide your input? Thanks. Zhe On 2018年08月14日 23:33, zhe.he@windriver.com wrote: > From: He Zhe > > memory_corruption_check[{_period|_size}]'s handlers do not check input > argument before passing it to kstrtoul or simple_strtoull. The argument > would be a NULL pointer if each of the kernel parameters, without its > value, is set in command line and thus cause the following panic. > > PANIC: early exception 0xe3 IP 10:ffffffff73587c22 error 0 cr2 0x0 > [ 0.000000] CPU: 0 PID: 0 Comm: swapper Not tainted 4.18-rc8+ #2 > [ 0.000000] RIP: 0010:kstrtoull+0x2/0x10 > ... > [ 0.000000] Call Trace > [ 0.000000] ? set_corruption_check+0x21/0x49 > [ 0.000000] ? do_early_param+0x4d/0x82 > [ 0.000000] ? parse_args+0x212/0x330 > [ 0.000000] ? rdinit_setup+0x26/0x26 > [ 0.000000] ? parse_early_options+0x20/0x23 > [ 0.000000] ? rdinit_setup+0x26/0x26 > [ 0.000000] ? parse_early_param+0x2d/0x39 > [ 0.000000] ? setup_arch+0x2f7/0xbf4 > [ 0.000000] ? start_kernel+0x5e/0x4c2 > [ 0.000000] ? load_ucode_bsp+0x113/0x12f > [ 0.000000] ? secondary_startup_64+0xa5/0xb0 > > This patch adds checks to prevent the panic. > > Cc: stable@vger.kernel.org > Signed-off-by: He Zhe > --- > v2: > - Split out printk cleanups > - Add cc to stable@vger.kernel.org > - Use more meaningful error message > > arch/x86/kernel/check.c | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/arch/x86/kernel/check.c b/arch/x86/kernel/check.c > index 3339942..cc8258a 100644 > --- a/arch/x86/kernel/check.c > +++ b/arch/x86/kernel/check.c > @@ -31,6 +31,11 @@ static __init int set_corruption_check(char *arg) > ssize_t ret; > unsigned long val; > > + if (!arg) { > + pr_err("memory_corruption_check config string not provided\n"); > + return -EINVAL; > + } > + > ret = kstrtoul(arg, 10, &val); > if (ret) > return ret; > @@ -45,6 +50,11 @@ static __init int set_corruption_check_period(char *arg) > ssize_t ret; > unsigned long val; > > + if (!arg) { > + pr_err("memory_corruption_check_period config string not provided\n"); > + return -EINVAL; > + } > + > ret = kstrtoul(arg, 10, &val); > if (ret) > return ret; > @@ -59,6 +69,11 @@ static __init int set_corruption_check_size(char *arg) > char *end; > unsigned size; > > + if (!arg) { > + pr_err("memory_corruption_check_size config string not provided\n"); > + return -EINVAL; > + } > + > size = memparse(arg, &end); > > if (*end == '\0')