From: Sibi Sankar <sibis@codeaurora.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: sboyd@kernel.org, georgi.djakov@linaro.org, saravanak@google.com,
mka@chromium.org, nm@ti.com, bjorn.andersson@linaro.org,
agross@kernel.org, rjw@rjwysocki.net,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, dianders@chromium.org,
vincent.guittot@linaro.org, amit.kucheria@linaro.org,
lukasz.luba@arm.com, sudeep.holla@arm.com,
smasetty@codeaurora.org, linux-arm-msm-owner@vger.kernel.org,
linux-kernel-owner@vger.kernel.org
Subject: Re: [PATCH v5 4/5] cpufreq: qcom: Update the bandwidth levels on frequency change
Date: Tue, 02 Jun 2020 12:27:20 +0530 [thread overview]
Message-ID: <129d8c6c7099ca49dd465b34a6c5fa34@codeaurora.org> (raw)
In-Reply-To: <20200601110116.jteoalg3yjhsbkpw@vireshk-i7>
On 2020-06-01 16:31, Viresh Kumar wrote:
> On 29-05-20, 17:00, Sibi Sankar wrote:
>> > > +static int qcom_cpufreq_update_opp(struct device *cpu_dev,
>> > > + unsigned long freq_khz,
>> > > + unsigned long volt)
>> > > +{
>> > > + unsigned long freq_hz = freq_khz * 1000;
>> > > +
>> > > + if (dev_pm_opp_adjust_voltage(cpu_dev, freq_hz, volt, volt, volt))
>> > > + return dev_pm_opp_add(cpu_dev, freq_hz, volt);
>> >
>> > What's going on here ? Why add OPP here ?
>>
>> We update the voltage if opp were
>> initially added as part of
>> dev_pm_opp_of_add_table. However
>> if the cpu node does not have an
>> opp table associated with it, we
>> do a opp_add_v1 instead.
>
> Instead of depending on the failure of dev_pm_opp_adjust_voltage(),
> pass a flag to qcom_cpufreq_update_opp() which will decide if we want
> to adjust voltage or add an opp.
Sure will add it in the next
re-spin.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2020-06-02 6:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 20:21 [PATCH v5 0/5] DDR/L3 Scaling support on SDM845 and SC7180 SoCs Sibi Sankar
2020-05-27 20:21 ` [PATCH v5 1/5] cpufreq: blacklist SDM845 in cpufreq-dt-platdev Sibi Sankar
2020-05-27 20:21 ` [PATCH v5 2/5] cpufreq: blacklist SC7180 " Sibi Sankar
2020-05-27 20:21 ` [PATCH v5 3/5] OPP: Add and export helper to set bandwidth Sibi Sankar
2020-05-27 20:21 ` [PATCH v5 4/5] cpufreq: qcom: Update the bandwidth levels on frequency change Sibi Sankar
2020-05-29 10:00 ` Viresh Kumar
2020-05-29 11:30 ` Sibi Sankar
2020-06-01 11:01 ` Viresh Kumar
2020-06-02 6:57 ` Sibi Sankar [this message]
2020-05-27 20:21 ` [PATCH v5 5/5] cpufreq: qcom: Disable fast switch when scaling DDR/L3 Sibi Sankar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=129d8c6c7099ca49dd465b34a6c5fa34@codeaurora.org \
--to=sibis@codeaurora.org \
--cc=agross@kernel.org \
--cc=amit.kucheria@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=dianders@chromium.org \
--cc=georgi.djakov@linaro.org \
--cc=linux-arm-msm-owner@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel-owner@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=mka@chromium.org \
--cc=nm@ti.com \
--cc=rjw@rjwysocki.net \
--cc=saravanak@google.com \
--cc=sboyd@kernel.org \
--cc=smasetty@codeaurora.org \
--cc=sudeep.holla@arm.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).