From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Joerg Roedel <joro@8bytes.org>,
Robin Murphy <robin.murphy@arm.com>
Cc: iommu@lists.linux-foundation.org, devicetree@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 00/21] IOMMU: Tegra GART driver clean up and optimization
Date: Fri, 16 Nov 2018 15:13:31 +0300 [thread overview]
Message-ID: <12b55bb4-1a52-1045-cc99-f8e4eaf2bdf5@gmail.com> (raw)
In-Reply-To: <20180930224833.28809-1-digetx@gmail.com>
On 01.10.2018 1:48, Dmitry Osipenko wrote:
> Hello,
>
> This patch-series integrates the GART (IOMMU) driver with the Memory
> Controller driver, that allows to report the name of a faulty memory
> client on GART page fault. A major code clean up and performance
> optimization is performed in this series as well.
>
> Changelog:
>
> v5: Addressed review comments from Thierry Reding to v4. Added WARN_ON() to
> make sure that active domain isn't getting released, kept include headers
> where necessary, etc.. All changes are quite minor.
>
> Added new patch "memory: tegra: Use relaxed versions of readl/writel".
>
> v4: In the v3 Rob Herring requested to make device-tree binding changes
> backwards-compatible with the older kernels, that is achieved by
> changing the 'compatible' value of the DT node.
>
> The code-refactoring patches got some more (minor) polish.
>
> Added new patch "memory: tegra: Use of_device_get_match_data()".
>
> v3: Memory Controller integration part has been reworked and now GART's
> device-tree binding is changed. Adding Rob Herring for the device-tree
> changes reviewing.
>
> GART now disallows more than one active domain at a time.
>
> Fixed "spinlock recursion", "NULL pointer dereference" and "detaching
> of all devices from inactive domains".
>
> New code-refactoring patches.
>
> The previously standalone patch "memory: tegra: Don't invoke Tegra30+
> specific memory timing setup on Tegra20" is now included into this
> series because there is a dependency on that patch and it wasn't applied
> yet.
>
> v2: Addressed review comments from Robin Murphy to v1 by moving devices
> iommu_fwspec check to gart_iommu_add_device().
>
> Dropped the "Provide single domain and group for all devices" patch from
> the series for now because after some more considering it became not
> exactly apparent whether that is what we need, that was also suggested
> by Robin Murphy in the review comment. Maybe something like a runtime
> IOMMU usage for devices would be a better solution, allowing to implement
> transparent context switching of virtual IOMMU domains.
>
> Some very minor code cleanups, reworded commit messages.
>
> Dmitry Osipenko (21):
> iommu/tegra: gart: Remove pr_fmt and clean up includes
> iommu/tegra: gart: Clean up driver probe errors handling
> iommu/tegra: gart: Ignore devices without IOMMU phandle in DT
> iommu: Introduce iotlb_sync_map callback
> iommu/tegra: gart: Optimize mapping / unmapping performance
> dt-bindings: memory: tegra: Squash tegra20-gart into tegra20-mc
> ARM: dts: tegra20: Update Memory Controller node to the new binding
> memory: tegra: Don't invoke Tegra30+ specific memory timing setup on
> Tegra20
> memory: tegra: Adapt to Tegra20 device-tree binding changes
> memory: tegra: Read client ID on GART page fault
> memory: tegra: Use of_device_get_match_data()
> memory: tegra: Use relaxed versions of readl/writel
> iommu/tegra: gart: Integrate with Memory Controller driver
> iommu/tegra: gart: Fix spinlock recursion
> iommu/tegra: gart: Fix NULL pointer dereference
> iommu/tegra: gart: Allow only one active domain at a time
> iommu/tegra: gart: Don't use managed resources
> iommu/tegra: gart: Prepend error/debug messages with "gart:"
> iommu/tegra: gart: Don't detach devices from inactive domains
> iommu/tegra: gart: Simplify clients-tracking code
> iommu/tegra: gart: Perform code refactoring
>
> .../bindings/iommu/nvidia,tegra20-gart.txt | 14 -
> .../memory-controllers/nvidia,tegra20-mc.txt | 27 +-
> arch/arm/boot/dts/tegra20.dtsi | 15 +-
> drivers/iommu/Kconfig | 1 +
> drivers/iommu/iommu.c | 8 +-
> drivers/iommu/tegra-gart.c | 489 +++++++-----------
> drivers/memory/tegra/mc.c | 93 +++-
> drivers/memory/tegra/mc.h | 10 +-
> include/linux/iommu.h | 1 +
> include/soc/tegra/mc.h | 29 +-
> 10 files changed, 306 insertions(+), 381 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/iommu/nvidia,tegra20-gart.txt
>
Hello Thierry,
This patchset should be in a good shape, could you please take a look at the (minor) changes done in v5 and give r-b/ack to the remaining patches? Will be very nice if this series could finally land, especially in the light of upcoming DRM/HOST1x (re-)work.
prev parent reply other threads:[~2018-11-16 12:14 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-30 22:48 [PATCH v5 00/21] IOMMU: Tegra GART driver clean up and optimization Dmitry Osipenko
2018-09-30 22:48 ` [PATCH v5 01/21] iommu/tegra: gart: Remove pr_fmt and clean up includes Dmitry Osipenko
2018-09-30 22:48 ` [PATCH v5 02/21] iommu/tegra: gart: Clean up driver probe errors handling Dmitry Osipenko
2018-09-30 22:48 ` [PATCH v5 03/21] iommu/tegra: gart: Ignore devices without IOMMU phandle in DT Dmitry Osipenko
2018-09-30 22:48 ` [PATCH v5 04/21] iommu: Introduce iotlb_sync_map callback Dmitry Osipenko
2018-09-30 22:48 ` [PATCH v5 05/21] iommu/tegra: gart: Optimize mapping / unmapping performance Dmitry Osipenko
2018-09-30 22:48 ` [PATCH v5 06/21] dt-bindings: memory: tegra: Squash tegra20-gart into tegra20-mc Dmitry Osipenko
2018-09-30 22:48 ` [PATCH v5 07/21] ARM: dts: tegra20: Update Memory Controller node to the new binding Dmitry Osipenko
2018-09-30 22:48 ` [PATCH v5 08/21] memory: tegra: Don't invoke Tegra30+ specific memory timing setup on Tegra20 Dmitry Osipenko
2018-09-30 22:48 ` [PATCH v5 09/21] memory: tegra: Adapt to Tegra20 device-tree binding changes Dmitry Osipenko
2018-09-30 22:48 ` [PATCH v5 10/21] memory: tegra: Read client ID on GART page fault Dmitry Osipenko
2018-09-30 22:48 ` [PATCH v5 11/21] memory: tegra: Use of_device_get_match_data() Dmitry Osipenko
2018-09-30 22:48 ` [PATCH v5 12/21] memory: tegra: Use relaxed versions of readl/writel Dmitry Osipenko
2018-09-30 22:48 ` [PATCH v5 13/21] iommu/tegra: gart: Integrate with Memory Controller driver Dmitry Osipenko
2018-09-30 22:48 ` [PATCH v5 14/21] iommu/tegra: gart: Fix spinlock recursion Dmitry Osipenko
2018-09-30 22:48 ` [PATCH v5 15/21] iommu/tegra: gart: Fix NULL pointer dereference Dmitry Osipenko
2018-09-30 22:48 ` [PATCH v5 16/21] iommu/tegra: gart: Allow only one active domain at a time Dmitry Osipenko
2018-09-30 22:48 ` [PATCH v5 17/21] iommu/tegra: gart: Don't use managed resources Dmitry Osipenko
2018-09-30 22:48 ` [PATCH v5 18/21] iommu/tegra: gart: Prepend error/debug messages with "gart:" Dmitry Osipenko
2018-09-30 22:48 ` [PATCH v5 19/21] iommu/tegra: gart: Don't detach devices from inactive domains Dmitry Osipenko
2018-09-30 22:48 ` [PATCH v5 20/21] iommu/tegra: gart: Simplify clients-tracking code Dmitry Osipenko
2018-09-30 22:48 ` [PATCH v5 21/21] iommu/tegra: gart: Perform code refactoring Dmitry Osipenko
2018-11-16 12:13 ` Dmitry Osipenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12b55bb4-1a52-1045-cc99-f8e4eaf2bdf5@gmail.com \
--to=digetx@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jonathanh@nvidia.com \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).