From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752736AbcFJTSw (ORCPT ); Fri, 10 Jun 2016 15:18:52 -0400 Received: from mail-bl2on0092.outbound.protection.outlook.com ([65.55.169.92]:55396 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750848AbcFJTSu (ORCPT ); Fri, 10 Jun 2016 15:18:50 -0400 Authentication-Results: spf=pass (sender IP is 63.163.107.225) smtp.mailfrom=sandisk.com; linux-foundation.org; dkim=none (message not signed) header.d=none;linux-foundation.org; dmarc=bestguesspass action=none header.from=sandisk.com; X-AuditID: ac160c71-a17ff70000000efe-cd-575b0e2d1b32 Subject: Re: [PATCH] ibmvscsis: Initial commit of IBM VSCSI Tgt Driver To: Bryant G Ly References: <1464097978-88457-1-git-send-email-bryantly@linux.vnet.ibm.com> <3303bc98-ade7-62f0-71c7-11e7ef42b42d@sandisk.com> <20160524160047.Horde.M1bK0S-HUnY41nXa9ZoJ6w1@ltc.linux.ibm.com> CC: James Bottomley , , , , , , , , , , , , , , bgly From: Bart Van Assche Message-ID: <12c6229a-3188-b88c-523f-99219ed60c05@sandisk.com> Date: Fri, 10 Jun 2016 12:03:51 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <20160524160047.Horde.M1bK0S-HUnY41nXa9ZoJ6w1@ltc.linux.ibm.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrGIsWRmVeSWpSXmKPExsWyRoxnka4BX3S4QdceG4s569ewWSyfup/R YmK/psWe3c1sFnPOt7BYNC9ez2axsZ/DYvb9xywWUzZ8YLJYtHIhm8XlXXPYLLqv7wBqOv6P yWL1swqL1qVvmSzWN21jdRDwuNzXy+SxZeVNJo9pk06xeZyY8ZvF48GhzSwe++euYff4+PQW i8eW/rvsHl9WXWP2WL/lKovH5tPVHueu9TF7fN4kF8AbxWWTkpqTWZZapG+XwJWxr/cKW8Fs 0YrNnzazNzBu5e9i5OSQEDCRmHL/BXMXIxeHkMBcJom+L8sZIZwdjBIL9rUywlRN/9PAApFY yiixcvZcdpCEsICbxKKl38CKRAR0Ja4s+gLVfZhRYk7DD3YQh1lgI7PE5MufmUGq2ASMJL69 n8kCYvMK2Ensa5rMCmKzCKhK3OudAhYXFYiQ6P21BKpGUOLkzCdgNqeAr8SfzRvAtjELWEjM nH8eypaX2P52DtgTEgJ72CQa758DWyYkoC5xcsl8pgmMwrOQzJqFpH8Wkv4FjMyrGMVyM3OK c9NTCwxN9IoT81Iyi7P1kvNzNzFCYrtwB+Pr296HGAU4GJV4eBl2RIYLsSaWFVfmHmKU4GBW EuH14Y0OF+JNSaysSi3Kjy8qzUktPsQozcGiJM57MfpjmJBAemJJanZqakFqEUyWiYNTqoFR heO3lLv1pDVdr2YkVas43VxfNcfvbuwevXDbLfr5ydu1pxZlfGUJ1PN69v6BSN4HSwnJVR3u ig+Wz37JZLFmb9/98wt/57TN/LL8wG2udq3fKY3CqWE6kWUBP54++x13Tcwo93o21+/H377t PKqvuvZ1mgbbM8MXd6NFoi6tSkxzy5rfIDJFiaU4I9FQi7moOBEAmYgcfukCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrNLMWRmVeSWpSXmKPExsXCtZEjRVeKPzrcYOMKDYs569ewWSyfup/R YmK/psWe3c1sFnPOt7BYNC9ez2axsZ/DYvb9xywWUzZ8YLJYtHIhm8XlXXPYLLqv7wBqOv6P yWL1swqL1qVvmSzWN21jdRDwuNzXy+SxZeVNJo9pk06xeZyY8ZvF48GhzSwe++euYff4+PQW i8eW/rvsHl9WXWP2WL/lKovH5tPVHueu9TF7fN4kF8AbxWWTkpqTWZZapG+XwJWxr/cKW8Fs 0YrNnzazNzBu5e9i5OSQEDCRmP6ngaWLkYtDSGAxo8SB1vvsIAlhATeJRUu/MYLYIgK6ElcW fWGEKDrMKDGn4Qc7iMMsMJ1ZYnPrZrAqNgEjiW/vZ7KA2LwCdhL7miazgtgsAqoS93qngMVF BSIken8tgaoRlDg58wmYzSngK/Fn8wawOcwCZhLzNj9khrDlJba/ncM8gZFvFpKWWUjKZiEp W8DIvIpRLDczpzg3PbPA0FCvODEvJbM4Wy85P3cTIzi6OCN3MD6daH6IkYmDU6qBMfWKRee6 nnXcKvo2jKe+uB8WKYqvyFnPfIq7zS04gf/YDM7vtZuMOlsYzT5J/nkpUTNt+cE1+ZWzjy6T WL/oxpzXFhsdNGUe/7QoL7Sz778Xca3kYPFV3/97hPmM726X/bQjSlckZnLtxSDznn+iNRen ZjyNjzq3kJ+XK6NZkf3Rkby5jlozlFiKMxINtZiLihMBK+zGwF4CAAA= X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:63.163.107.225;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(7916002)(2980300002)(438002)(377454003)(189002)(24454002)(199003)(31686004)(36756003)(76176999)(54356999)(81156014)(81166006)(50986999)(53416004)(2270400002)(8936002)(92566002)(65956001)(65806001)(47776003)(4326007)(50466002)(2906002)(68736007)(8666004)(189998001)(586003)(23676002)(6806005)(83506001)(33646002)(5008740100001)(106466001)(4001350100001)(5003600100002)(64126003)(87936001)(97736004)(110136002)(11100500001)(19580405001)(19580395003)(69596002)(8676002)(2950100001)(31696002)(77096005)(230700001)(86362001)(356003)(65826006)(7059030)(217873001);DIR:OUT;SFP:1101;SCL:1;SRVR:SN1PR0201MB1776;H:milsmgep14.sandisk.com;FPR:;SPF:Pass;PTR:InfoDomainNonexistent;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BN1BFFO11FD005;1:YuRK5Y/YjmenemjKPCbOf5xrfnj6S/SKMB5zjRsPj4OcO4SbJs4W22G40y/GRBMRY6/7Qhrk5CRM011BtwbOD+yn53E+R15/52B6TH3gQ/F2xC0z0socSmniJVqjqVgZsSkEYxTO9mVhnNSIOJsW7GuxAup3pSFkcxJi3rpa0NWvepvnf6jpCuZ8ed5zeGFqO67CCQuceZBFcp+AyvFKNHDW58BBML2Fh4ol3oX5AHMGVXTlv51xg2pMTL1WYOTqqyBX0tkqwcsGSoC5x8bww1fbrbUT0Hyxm37FWhKQ5gbUAToiUwb2r6yrSRxhZMYeiLncWcE/J96cUOu3DmrlZ0xG6cq1VZmdMeICwpkE5vckzrmbJEmHKs3PaVTOXztK2tXx1hI2mIl70LBgBkJLunLN0Ufp7w60qF6c5D99rr5ANNtnxp2ueAbkzb2xkpDN5lvKmVn5wDVUtrE5PP4UEs5bIslHLUcOn5JD5QNqjGg= X-MS-Office365-Filtering-Correlation-Id: 87c87dd9-e424-45da-b6c8-08d39161fbec X-Microsoft-Exchange-Diagnostics: 1;SN1PR0201MB1776;2:tDBJ64tkwqxk/Yg+lQtu+2wxrc6heYo6H00qhxsnX2lBDp7SSpF+OAlj6WkzCyRY3RNBfyzIJLZQ1Mo/+rzghWLMyPNREnky9NgcnGbcTV/blcvx8a4Y/2+dG+CZmHyoKghWky0q7SGu/WyZoqxEKbXjQZuiFlZdK0KHaSi9AS/0uI4LYHZHnkv6GRAgb5Dt;3:Q6TbZAiM/cxXeksfury26LqqPRLqlY5URMs8JgICR9NNH7c5pQbi5YhtzVwQzcdVpJuwTTIXXdLLRpgtZFn23u8bZeiOw6rfd7HMLYRxSlEoxU68frX6DfEOKhC+TLTBJftiLmxhvJP/B1XDDK93XWF/5Ga0rtanOanQiuI4qC7BenfRtQ5RAvOAeAPNa3tt+tJSk0cbdFsLQiOdfcLo3PAlVFpePJinbDa8f6/3a8gUcAeGS4SSv4EncvrHnD/wXjMvosjGvlY8MvblITFTLg== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501002);SRVR:SN1PR0201MB1776; X-Microsoft-Exchange-Diagnostics: 1;SN1PR0201MB1776;25:tr3gBjOHr4c6KNmi9ZWjrZNa+eB65pwRNAVr118AqxpNHiRDyjWX0e+qvP9iHF6pbTuN8ZG8nG96xRBGvcar1HYlRKnooWQC6u+d9VvmMZCoGjD8tj4Ch1KEp0HOVnzqLLfG5XdqiexDN/uXT9QUvstuiX07R/n1vK4SgtR0u9GzzPOwLnQBPnEjEzGuR6zzjQzgwgntdz8xeMJOl8rqzMoQdRQCgiiEwomtF3KXMVOM97PE5vYoPRsXhZxFwyK6vb9Mms0FGNeKl+/UCcCgrO4fq3OC0tGKGoO6DucabYOgtVX/tHtrfdqKufgc2YHuUsEVjeXrz8mH+ztWbEU23IiXmcDy8q3iwtC3SNwJp5mLzyOMlWErVqtERC0l3rucaUnoRDF1NP0jvsjwU54dcgGEUp3isehe0csSKONgW/5wMdgiLSwF4XYCwQEMqokPUxAypgQ2a4IDS7Zg56Ww/KKrRdTOXsrepVkgr9p9WCVaUZtVrWzQmkYIcRN6fsJ6XAREzwm8fFyqDvb+UlKlzi3ciDuCj8enz6X5R9pZV3Z9tHGMNZATjmDjbwDB538GWs0PMMTswgbwumaKrqrqBu70kxz2SkzspmsmawS1ceBEoqLmnseNo5ZGUEGFoHHnd1pEKakdl8CUrGnuMt2P9Xeb7lyrtBKFlddFZD9Px1CDWAggzTs3+/gYDineng7bVJfwLGYKOoYRRUacjsYQzqhvaEw5iu+9+K8gj5gfMkm/J0bZMy2A2u/yrX+1q0xbeVgAwK28MR1CP52Cd/hVv2BF0CHt99R2Op2c40JbYMo= X-Microsoft-Exchange-Diagnostics: 1;SN1PR0201MB1776;20:gg4ihAClOLbXTTcvo5A4HyWnRo2F6G4RBQrtlW4uai8z5z8VKBQCevJtj54GWxuQIxYnqOGAAIUKO/1OTQZ8VeQ9mNT+GxgKI/ytvCDki28VZEFD5980uOTasqGmX//NWORqrw7+fZmmavb+Vue+ULuJ/kmfNEgcCkDr1Y6IpRIBvCyH5POzf64B7QSIxtEXtvQ9CAFMgcE9p8dK3CvDCnK36ZkDeRSS0hgMrpZ5JCbmHvbYfTxigbdBVlN9/0MrFu2EnrmIihLxZOZ3VEHbYeAR4uroW5m6KXXqPurD6IC3pt2hMKkR9eR7k02wdrksgjFfcJuw3+qQsnWusJ3tAocN4QCXEgLShyVIk34/mAnABoenrM9ZBzSaTCYijCVRo3+TjnuTs1tsQz9XQillI+rSzq5xNXnZRzTBcJ5S1w9+WI0COQjSpl4E6g6gqFA27GF2pVG3UYYHBV3Cle4BHwuYsP3JhJ99lUGzslpsKWtxGy5sZwu+sGXDHWMQFn7S X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(42932892334569); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(13018025)(13016025)(3002001)(10201501046)(6055026);SRVR:SN1PR0201MB1776;BCL:0;PCL:0;RULEID:;SRVR:SN1PR0201MB1776; X-Microsoft-Exchange-Diagnostics: 1;SN1PR0201MB1776;4:HlJ102NfVsDDsbxuC+WfFp439ZeLzH15BlJ3FArtVs+Ym/72m6rmLTcy4YZOCuNYlhEKmhw3c1t3bPNYr1hsdNWXY+9D7vpizQUeWwV4FPS+7S+/BWy4UvHlAFMAf+hD6U5pBv3R4T8Bo2az+4qGTBmyscIo2JVJq1yNKfP8Oqb30Nu+eYsVLrGucdwP7YBVSp+6ybGJkpwHezdg3yKtbhMnthKnuujyZdwPWjeuJbdoR9m3klSqp20vbiR3Yz41PlZ/99VGoxwVHM28wPBGv4d3n6F8k34AhDRlj6qIB7+AsArFEXVTURaaxi7Q0NZVPDrrEsASQKHjZWtZX4Q3h+SewxyeWD1IwjTsWe02dj6/Q+fo/ShuPTRjqraOkW3AoDbjBCrCHcIisH+WBQXkmkvo+4BXdThVeUJz7Ty0PDilQ3NbGtza4CupK99O/pOyowUncyTV+QaR7fDHsCnyGQ== X-Forefront-PRVS: 096943F07A X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtTTjFQUjAyMDFNQjE3NzY7MjM6cW5LdHVHMS9WeVZkSzcvT0dITDFWZTkr?= =?utf-8?B?dXpRYzZLYTVrRE5DT0FIbDF2NHdCZVloVXZIandzczBnYnYrVVJscTJCbW9i?= =?utf-8?B?S3dqdGtFb0R2b0prSjJqTHVzNW5QRjByWUgxanVCUU9rWVJDUG9EOHQremNP?= =?utf-8?B?YXNOKzNBUlIwRWhlS25PaEtYaitQb3RrOElVRUtVZmRHcGd5MWF3RUoybGdo?= =?utf-8?B?Z1BER0tqMENETEZseHZuaXZvSjJQVXVOazN4MVVzbVZtOENvaStGdjRMVXNO?= =?utf-8?B?bXpHOXBuV2lwdjR3b1poQXh4bEg0M2g2VUpOOXlKcEhUdUVLdGRtYS9TT25K?= =?utf-8?B?S2NzRUhRRnBwYkNsZWYyN3dBdXBUWEpVR3VGQ0Z5N0ZFY1FvRmlwWXRVN1Y0?= =?utf-8?B?am12TWpIT0EyeFBpbVc1ZlRoeDVtRks3aHdwcWVGemVrbzR4M1hNeEl5RVNk?= =?utf-8?B?dDBaZmNqVjc3Y3lwekliVm50N2h0dmFNUFVSc2VGR29FNzlpWmk0dTJoOVhy?= =?utf-8?B?OXBsYjlmVVhqd1F2UzlUTlphbUJLVnVPQWRJNlJCTEJqcTdtYkpoQmU2eUJ3?= =?utf-8?B?VXZ6blh1NGRLNDY1UVFDWGY1bURtNFFSQldEUU5QUElmaWdib3hrbEZ4RHhQ?= =?utf-8?B?OGdIUGs5V1Y0U2xzNks1NUp2S1lGY0lOWWJ3L0VWUWNpTDM1c05FUzVkWmV2?= =?utf-8?B?UENBRlJSVWFwN0lFZDdzWjlwZUkyQ2M2T1Y3Z2JrbkN0YXNmVHVpN3VpTTdX?= =?utf-8?B?VlNLQlNzZnJjd3ZoajBSV0tWd2FpRjVNS3prc2FGRXdlVVlLaXR3U3ArV3px?= =?utf-8?B?dElWMXdBeHBwU0trZFlYd2RJOHpHaTU0aWFzdUdNN3QyejhxVktqMkgvREN3?= =?utf-8?B?cytwcnhsaTBZM25yRHNJZWZHY0V6TFhrcFBYbUQ3M3NXR3EySDJIUFpkRVlL?= =?utf-8?B?dWd5anJ6a1pJM0U0YXpxMFVQS09kQ1dzYm12Mk5vb1VUTHBaclUvWXB1QkRN?= =?utf-8?B?bWdiN0E5RVVRQ09BL3VxZ1FFMFVNNXM5d2JaSDZQbHFTSWU5Yk1GNUQ0NEsv?= =?utf-8?B?RnFPNkxrNGtJMDFjNjBhcG0xUGx4WEFLcWlpM0s3SGxaK1ZLVFh2aGVyQzg3?= =?utf-8?B?MktKVVN4WlZycWRUd1E0UFlUNmhJQTFqWkNnQjFZWVlPTWl5TmVwYXkvbi93?= =?utf-8?B?aFNsdzcwMEJ3VWVVS0NYNXVnaUs3ZmszK3FXaHI4T3pBWHBJSUlSSTdsdytq?= =?utf-8?B?bDFvNUFvQmx2VDhiN0lhdDZUazV4SFJ2MTMvQXRUYkRmeG1HNkZrQ0pzNUJq?= =?utf-8?B?YklOclVKalRoQ0phNEdLMXF0NHAzOWRWaEtpVXIzR3E2ckJzeTNLbitONnJy?= =?utf-8?B?UlBON1kvMklxbW9IdFdlai9SWlZxTlcxakFxTG5tSzNlbnhFT2ZUM1JWcDk1?= =?utf-8?B?WkpXaW9acStGdnorN005bk0wUW5DUXVvcGZ6STFmaHdzMFNCd3UraEhNanE2?= =?utf-8?B?M1FFN0M3ZWZZY3NaaEZrSnA2b000UzVETVVybSttOU1WN2RMSkpvNm53MXZx?= =?utf-8?B?dnJtOXBQc1BIWGpMblVzbmUrUzJmTUh3RnpTWEU2UVdkYXl2cFF6M3lNMzYr?= =?utf-8?B?cDNSNi9jZlFYRnVHMTVqQ2xuV013S0h6WDdBRjB6SmQ5YnJmNTgvUm9qWFha?= =?utf-8?B?eHdGTWFpN2NFbGg1WUVuRGZwK09YMWhBaHYzMkg1SnpIY0UvbDczd3pIeE1j?= =?utf-8?B?dGdsV0JuU2NJVmR6WVZQN3pMcFpHS3lmYkE0TnNzTDZpMmRjYzY2dEdrTWRE?= =?utf-8?B?V2FnM0h2blZ1OVl4L25VcnN4UkhZMWRoWGlOU2h5UmNtdmsxQT09?= X-Microsoft-Exchange-Diagnostics: 1;SN1PR0201MB1776;5:bOwrx6zLohXBQNe2PzNijJsF3tL0Hj2RPXIGd+4qkqKmqCc2UZtros6QAxzuBJGBe+GpZG9BxozdWEUrh4U6ZybfYu6JdcM8cmrd53iww8Gp/FmvpoYilxqR1afqHh2Rd/susv+1SS4xT3Pad2gA/Q==;24:3leWzmUszC0SNVZT2OKnDfG1E+l1geIKnInksPpSW44ktd2wreWkMDHb0b+5jzJ7hdgxHcd9dUDoDKCD3TK0x7F55z1Arvlge7fb3UOq1hU=;7:6Gifb7A+D0FZakB0LxQtDEWwRm0xHmvnigNeVNh62Vqd7bPN3cpoMfJ3HH23oBtEMM/zP7wYoSKHoHTYNBgcG4jgmg9bLIVsPJ4ATEQSuZxVOdok8NZ8rNnCNrMWjH2JipP9rYStZ8GOpdGl42xNqK3HaFf7yzxWXX3cDrEYYglkYDXsfVKwXVzG3FdpYMAOK21BAnkbc22dJOmwTMZAif4BInkmQOj5yL2kTVoJdoU=;20:a7o6sBVxgYrEU+AbuLHWn3uCTUlCSH9m1CR9mc1TfMYoFmVNqz/Hngr4r3/O2jfHQLgTalhsMcZGHoiNX4oey19TGAw+7NhwGICKq/WZig6U/XTKAB1HKN19NXSUkEe4Ihdk7ISUZT2FpeMDpXe30qYjZr9A/sSUF7b+5OC7KCLEPj/7TWsFw8+QFxoDc1iJJfLzGDvXw29E+DiP/YH4R43ZeT9GoiSdpA9py0T3PboFFzR0bJCVwCSGj7xx/Ky6 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: sandisk.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jun 2016 19:03:59.2761 (UTC) X-MS-Exchange-CrossTenant-Id: fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d;Ip=[63.163.107.225];Helo=[milsmgep14.sandisk.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR0201MB1776 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/24/2016 01:00 PM, Bryant G Ly wrote: > Quoting Bart Van Assche : >> On 05/24/2016 06:52 AM, Bryant G. Ly wrote: >>> +static uint64_t ibmvscsis_unpack_lun(const uint8_t *lun, int len) >>> +{ >>> + uint64_t res = NO_SUCH_LUN; >>> + int addressing_method; >>> + >>> + if (unlikely(len < 2)) { >>> + pr_err("Illegal LUN length %d, expected 2 bytes or more\n", >>> + len); >>> + goto out; >>> + } >>> + >>> + switch (len) { >>> + case 8: >>> + if ((*((__be64 *)lun) & cpu_to_be64(0x0000FFFFFFFFFFFFLL)) >>> != 0) >>> + goto out_err; >>> + break; >>> + case 4: >>> + if (*((__be16 *)&lun[2]) != 0) >>> + goto out_err; >>> + break; >>> + case 6: >>> + if (*((__be32 *)&lun[2]) != 0) >>> + goto out_err; >>> + break; >>> + case 2: >>> + break; >>> + default: >>> + goto out_err; >>> + } >>> + >>> + addressing_method = (*lun) >> 6; /* highest two bits of byte 0 */ >>> + switch (addressing_method) { >>> + case SCSI_LUN_ADDR_METHOD_PERIPHERAL: >>> + case SCSI_LUN_ADDR_METHOD_FLAT: >>> + case SCSI_LUN_ADDR_METHOD_LUN: >>> + res = *(lun + 1) | (((*lun) & 0x3f) << 8); >>> + break; >>> + >>> + case SCSI_LUN_ADDR_METHOD_EXTENDED_LUN: >>> + default: >>> + pr_err("Unimplemented LUN addressing method %u\n", >>> + addressing_method); >>> + break; >>> + } >>> + >>> +out: >>> + return res; >>> +out_err: >>> + pr_err("Support for multi-level LUNs has not yet been >>> implemented\n"); >>> + goto out; >>> +} >> >> In the above function there is nothing that is specific to the VIO >> mechanism. Please consider to merge this function with >> scsilun_to_int(), e.g. by introducing a new function that accepts a >> SCSI LUN and the addressing method as arguments and by making >> scsilun_to_int() call that function with >> SCSI_LUN_ADDR_METHOD_PERIPHERAL as one of its arguments. >> > > We are going to keep this here atm, until we can make sure canonical can > pick up > these changes, since we have a deliverable for a 3rd party vendor who is > going to > fully utilize this driver. Once they can pick it up in 4.4 kernel I will > make the > change you recommended / move the scsi_lun_addr_method addressed below. > I will also > address the changes that ib_srpt needs to utilize this new function too. A much better approach would be to move this function into the SCSI core and to add a copy of that function to the backported driver that will be provided to Canonical. Thanks, Bart.