From: Rylan Dmello <mail@rylan.coffee>
To: Manish Chopra <manishc@marvell.com>,
GR-Linux-NIC-Dev@marvell.com,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
netdev@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, Joe Perches <joe@perches.com>
Subject: [PATCH v2 7/7] staging: qlge: Fix function argument alignment warning in ql_init_device
Date: Wed, 29 Apr 2020 21:35:15 -0400 [thread overview]
Message-ID: <12c7c34330b410e4ee8b9b5634f1a50ceb9c3590.1588209862.git.mail@rylan.coffee> (raw)
In-Reply-To: <cover.1588209862.git.mail@rylan.coffee>
Fix checkpatch.pl check:
CHECK: Alignment should match open parenthesis
Signed-off-by: Rylan Dmello <mail@rylan.coffee>
---
drivers/staging/qlge/qlge_main.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c
index fa708c722033..93df4f79b21d 100644
--- a/drivers/staging/qlge/qlge_main.c
+++ b/drivers/staging/qlge/qlge_main.c
@@ -4433,8 +4433,7 @@ static int ql_init_device(struct pci_dev *pdev, struct net_device *ndev,
pdev->needs_freset = 1;
pci_save_state(pdev);
qdev->reg_base =
- ioremap(pci_resource_start(pdev, 1),
- pci_resource_len(pdev, 1));
+ ioremap(pci_resource_start(pdev, 1), pci_resource_len(pdev, 1));
if (!qdev->reg_base) {
dev_err(&pdev->dev, "Register mapping failed.\n");
err = -ENOMEM;
@@ -4443,8 +4442,7 @@ static int ql_init_device(struct pci_dev *pdev, struct net_device *ndev,
qdev->doorbell_area_size = pci_resource_len(pdev, 3);
qdev->doorbell_area =
- ioremap(pci_resource_start(pdev, 3),
- pci_resource_len(pdev, 3));
+ ioremap(pci_resource_start(pdev, 3), pci_resource_len(pdev, 3));
if (!qdev->doorbell_area) {
dev_err(&pdev->dev, "Doorbell register mapping failed.\n");
err = -ENOMEM;
--
2.26.2
next prev parent reply other threads:[~2020-04-30 1:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-30 1:31 [PATCH v2 0/7] staging: qlge: Checkpatch.pl indentation fixes in qlge_main.c Rylan Dmello
2020-04-30 1:32 ` [PATCH v2 1/7] staging: qlge: Fix indentation in ql_set_mac_addr_reg Rylan Dmello
2020-04-30 1:33 ` [PATCH v2 2/7] staging: qlge: Remove gotos from ql_set_mac_addr_reg Rylan Dmello
2020-04-30 9:38 ` Dan Carpenter
2020-04-30 10:03 ` Joe Perches
2020-04-30 10:08 ` Dan Carpenter
2020-04-30 1:33 ` [PATCH v2 3/7] staging: qlge: Fix indentation in ql_get_mac_addr_reg Rylan Dmello
2020-04-30 1:33 ` [PATCH v2 4/7] staging: qlge: Remove goto statements from ql_get_mac_addr_reg Rylan Dmello
2020-04-30 1:34 ` [PATCH v2 5/7] staging: qlge: Remove multi-line dereference from ql_request_irq Rylan Dmello
2020-04-30 1:34 ` [PATCH v2 6/7] staging: qlge: Fix suspect code indent warning in ql_init_device Rylan Dmello
2020-04-30 1:35 ` Rylan Dmello [this message]
2020-04-30 1:51 ` [PATCH v2 0/7] staging: qlge: Checkpatch.pl indentation fixes in qlge_main.c Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12c7c34330b410e4ee8b9b5634f1a50ceb9c3590.1588209862.git.mail@rylan.coffee \
--to=mail@rylan.coffee \
--cc=GR-Linux-NIC-Dev@marvell.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=manishc@marvell.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).