From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFA9DC433E0 for ; Sun, 14 Mar 2021 13:33:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 77DA964EE2 for ; Sun, 14 Mar 2021 13:33:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231597AbhCNNcn (ORCPT ); Sun, 14 Mar 2021 09:32:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41186 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233208AbhCNNcF (ORCPT ); Sun, 14 Mar 2021 09:32:05 -0400 Received: from mail-pg1-x52e.google.com (mail-pg1-x52e.google.com [IPv6:2607:f8b0:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D51A6C061574; Sun, 14 Mar 2021 06:32:04 -0700 (PDT) Received: by mail-pg1-x52e.google.com with SMTP id w34so17812731pga.8; Sun, 14 Mar 2021 06:32:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=0kaE6kR4sHjhM9c/eCT2OCIGFKX0WfzwQmhXTp4l0yk=; b=Oj4eQCSCXi+pMIuc/L/u8CyDXsSj0mAKWIg5c2FKYS6nYF8nWaVkVgZzefPS4I1+8a m1/uftwnBHRt7tUGk8ZqRjASEED42c5+jr7ai/DvYh/GWOnosPSEcbjb0C5QPcv6ZdP1 GA93kGkm0992aaPNlcXaOx9TxKqa2fBakUudZBYJnlg32mogL4u+MVbT91eBYd/gMdyr o8H6gGArW2ntHxV+vmujmfx2kscTvbLt6q21KpMHk5gtNIATp2vX0wwh0ef32etcnIZb A3ZlyviU77EqD/Csm4Yo6i9GAANX+2y35OCp7pooJA/gILzZ2aiRliXL+cbEKC+OUkTI 6b2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=0kaE6kR4sHjhM9c/eCT2OCIGFKX0WfzwQmhXTp4l0yk=; b=KpZH9aF0uZ8cjI9WpXX6l+liuL1ug5DV2FAacY5ZeWs85RoaNvS2IXbEjs01Vodo7z daR5bxSEQdE0LZWh+ya53D2JMgU/vEFUMIqZNewIgZw1bGc8Z4WdQkQaciRJp6tn9ODH H1f9OmjGvLCvUVaE42lx4V6a/g5knrrhLvq650X8LpXa+oeVblWnwaLtQiC2v6MQn/4w xN40Bs9sQTeNDZlERgewGsKmjIeFWuuPNfnCJMBA8QjsXDGItbUNEbv8L/aNnazL7pY3 esKno1ysr/1aQ6QGT9eb7P5cCzXksjxDNGDbU5gYVf3XlMHKjKDq2b81DV8az5bXkpPh zKuA== X-Gm-Message-State: AOAM533RocoVbYNio18gggGDE3brDnkHyYN/VCJU9uvFQYsbq3sBv0Kd R+pi0idWuIOjEc2eUzlnW53OZfjG7IcO8dVT X-Google-Smtp-Source: ABdhPJxAk4LPUCxSr9evQo1pqAxgDmqUqp7JlzR67F0hseQOmldo6562Vct7ntSR8GLjkt0VOSDiIg== X-Received: by 2002:a63:792:: with SMTP id 140mr19484997pgh.200.1615728722496; Sun, 14 Mar 2021 06:32:02 -0700 (PDT) Received: from ?IPv6:2409:4072:61a:47fe:8a78:6024:43:5d7c? ([2409:4072:61a:47fe:8a78:6024:43:5d7c]) by smtp.gmail.com with ESMTPSA id g18sm10765056pfb.178.2021.03.14.06.31.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 14 Mar 2021 06:32:01 -0700 (PDT) Subject: Re: [PATCH] iio:dac:max517: Use devm_iio_device_register() To: Alexandru Ardelean Cc: Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , linux-iio , LKML References: <20210314093356.10609-1-dmugil2000@gmail.com> From: Mugilraj D Message-ID: <12cabd69-fcb4-2e01-3a48-c4327e839d3a@gmail.com> Date: Sun, 14 Mar 2021 19:01:57 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/03/21 4:37 pm, Alexandru Ardelean wrote: > On Sun, Mar 14, 2021 at 11:34 AM Mugilraj Dhavachelvan > wrote: >> >> Use devm_iio_device_register() to avoid remove function and >> drop explicit call to iio_device_unregister(). >> >> Signed-off-by: Mugilraj Dhavachelvan >> --- >> drivers/iio/dac/max517.c | 9 +-------- >> 1 file changed, 1 insertion(+), 8 deletions(-) >> >> diff --git a/drivers/iio/dac/max517.c b/drivers/iio/dac/max517.c >> index 7e01838ef4d0..5f72f126162d 100644 >> --- a/drivers/iio/dac/max517.c >> +++ b/drivers/iio/dac/max517.c >> @@ -189,13 +189,7 @@ static int max517_probe(struct i2c_client *client, >> data->vref_mv[chan] = platform_data->vref_mv[chan]; >> } >> >> - return iio_device_register(indio_dev); >> -} >> - > > In this case you can also remove the line with > i2c_set_clientdata(client, indio_dev); > > A lot of times, when functions like i2c_get_clientdata() get removed, > the i2c_set_clientdata() function becomes useless. > i.e. it stores some data that will never be used in the lifetime of the driver. > > It isn't always the case that you can do that; so, some care must be > taken to avoid special cases. > But in this case, you can remove the i2c_set_clientdata() call. > Ack, I'll send that in a while. I should send with [V2] tag right. > >> -static int max517_remove(struct i2c_client *client) >> -{ >> - iio_device_unregister(i2c_get_clientdata(client)); >> - return 0; >> + return devm_iio_device_register(&client->dev, indio_dev); >> } >> >> static const struct i2c_device_id max517_id[] = { >> @@ -214,7 +208,6 @@ static struct i2c_driver max517_driver = { >> .pm = &max517_pm_ops, >> }, >> .probe = max517_probe, >> - .remove = max517_remove, >> .id_table = max517_id, >> }; >> module_i2c_driver(max517_driver); >> -- >> 2.25.1 >>