From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E42AC433E0 for ; Thu, 11 Jun 2020 15:51:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CB153206A4 for ; Thu, 11 Jun 2020 15:51:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591890704; bh=buouFtbooRy71XGHmBWmTOUevELIfu0pjfzSCKPq8pY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=SjzhWNIVHIYVaRjb4dpKOO2RfG1+9sSO/wVWEbZhYhRT6GEEoqp4J/1Nmo0eCGrJi fvhIce9uuKvm1UvjY/j+Xw/nLZn7kYpwX3jdJUyI2ZOqGh4czaMb7dlkgohCNg+6/k ysuKT3N8ZCpB8JJD1EG2NaI++07KhUu5/rkfF9EQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728722AbgFKPvn (ORCPT ); Thu, 11 Jun 2020 11:51:43 -0400 Received: from mail.kernel.org ([198.145.29.99]:45318 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728605AbgFKPvm (ORCPT ); Thu, 11 Jun 2020 11:51:42 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8073D2075E; Thu, 11 Jun 2020 15:51:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591890701; bh=buouFtbooRy71XGHmBWmTOUevELIfu0pjfzSCKPq8pY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=bQbd4R8QZfbn7RGrBxQfn1ruYStXtOK6Z0q8MjEGMxIEzfjWZbv9wPvu4ao+MPfv8 1J7TGdGcixpukgrpdY6nm/py23a0nU82XzHB+uJdHGeGlNwL3pBL6dyV251JqldMNo uWAaERT1/kzBgRGTtto5IPIqD+QhtGoVipYhyA0Q= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jjPUR-0029gk-Lg; Thu, 11 Jun 2020 16:51:40 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 11 Jun 2020 16:51:39 +0100 From: Marc Zyngier To: Sean Christopherson Cc: Paul Mackerras , Christian Borntraeger , Janosch Frank , Paolo Bonzini , James Morse , Julien Thierry , Suzuki K Poulose , David Hildenbrand , Cornelia Huck , Claudio Imbrenda , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-mips@vger.kernel.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Feiner , Peter Shier , Junaid Shahid , Ben Gardon , Christoffer Dall Subject: Re: [PATCH 17/21] KVM: arm64: Use common code's approach for __GFP_ZERO with memory caches In-Reply-To: <20200611154359.GF29918@linux.intel.com> References: <20200605213853.14959-1-sean.j.christopherson@intel.com> <20200605213853.14959-18-sean.j.christopherson@intel.com> <6cc08074c289cbea7b9c1deeaf18c63f@kernel.org> <20200611154359.GF29918@linux.intel.com> User-Agent: Roundcube Webmail/1.4.4 Message-ID: <12ec535821111d503773d6f623047d27@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: sean.j.christopherson@intel.com, paulus@ozlabs.org, borntraeger@de.ibm.com, frankja@linux.ibm.com, pbonzini@redhat.com, james.morse@arm.com, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com, david@redhat.com, cohuck@redhat.com, imbrenda@linux.ibm.com, vkuznets@redhat.com, wanpengli@tencent.com, jmattson@google.com, joro@8bytes.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-mips@vger.kernel.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, linux-kernel@vger.kernel.org, pfeiner@google.com, pshier@google.com, junaids@google.com, bgardon@google.com, christoffer.dall@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-06-11 16:43, Sean Christopherson wrote: > On Thu, Jun 11, 2020 at 08:59:05AM +0100, Marc Zyngier wrote: >> >diff --git a/arch/arm64/kvm/mmu.c b/arch/arm64/kvm/mmu.c >> >index 9398b66f8a87..688213ef34f0 100644 >> >--- a/arch/arm64/kvm/mmu.c >> >+++ b/arch/arm64/kvm/mmu.c >> >@@ -131,7 +131,8 @@ static int mmu_topup_memory_cache(struct >> >kvm_mmu_memory_cache *cache, int min) >> > if (cache->nobjs >= min) >> > return 0; >> > while (cache->nobjs < ARRAY_SIZE(cache->objects)) { >> >- page = (void *)__get_free_page(GFP_PGTABLE_USER); >> >+ page = (void *)__get_free_page(GFP_KERNEL_ACCOUNT | >> >> This is definitely a change in the way we account for guest >> page tables allocation, although I find it bizarre that not >> all architectures account for it the same way. > > It's not intended to be a functional change, i.e. the allocations > should > still be accounted: > > #define GFP_PGTABLE_USER (GFP_PGTABLE_KERNEL | __GFP_ACCOUNT) > | > -> #define GFP_PGTABLE_KERNEL (GFP_KERNEL | __GFP_ZERO) > > == GFP_KERNEL | __GFP_ACCOUNT | __GFP_ZERO > > versus > > #define GFP_KERNEL_ACCOUNT (GFP_KERNEL | __GFP_ACCOUNT) > > with __GFP_ZERO explicitly OR'd in > > == GFP_KERNEL | __GFP_ACCOUNT | __GFP_ZERO > > I can put the above in the changelog, unless of course it's wrong and > I've > missed something. Ah, good point. Serves me right for judging the symbol at face value! ;-) I guess a quick mention in the changelog wouldn't hurt. Thanks, M. -- Jazz is not dead. It just smells funny...