From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EC10C43333 for ; Wed, 3 Mar 2021 14:21:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0966364E87 for ; Wed, 3 Mar 2021 14:21:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1443913AbhCCOVL (ORCPT ); Wed, 3 Mar 2021 09:21:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37800 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1842952AbhCCKW4 (ORCPT ); Wed, 3 Mar 2021 05:22:56 -0500 Received: from ssl.serverraum.org (ssl.serverraum.org [IPv6:2a01:4f8:151:8464::1:2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0DC28C061BC3 for ; Wed, 3 Mar 2021 00:59:10 -0800 (PST) Received: from ssl.serverraum.org (web.serverraum.org [172.16.0.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id 0F9F322235; Wed, 3 Mar 2021 09:59:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1614761944; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tnVNK+MZxnmzR8kmaUrLBXJQV16SWYWRvDlxXLF9j3k=; b=cy0vI+LdCayQVqJaVy5KjrVaV7fBeLnRtfit94bVzDxR+LeFxHFjF4so2wahwJ2T3LM/mS NnwkOW4mp0uivEmX1eUqyUWitMpuoPI7+CHHYsonzscxPQhmCG01hW07LaFWUr3zOSF3Z+ uBZlSppZ7DErhaaDHc91Pf3V6pJ+QFo= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 03 Mar 2021 09:59:03 +0100 From: Michael Walle To: Saravana Kannan Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , Jon Hunter , Marek Szyprowski , Geert Uytterhoeven , Guenter Roeck , Android Kernel Team , LKML Subject: Re: [PATCH v1 0/3] driver core: Set fw_devlink=on take II In-Reply-To: References: <20210302211133.2244281-1-saravanak@google.com> User-Agent: Roundcube Webmail/1.4.11 Message-ID: <12f31a46e8dc3f0e53c1a7440a4ce087@walle.cc> X-Sender: michael@walle.cc Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 2021-03-02 23:47, schrieb Saravana Kannan: > On Tue, Mar 2, 2021 at 2:42 PM Saravana Kannan > wrote: >> >> On Tue, Mar 2, 2021 at 2:24 PM Michael Walle wrote: >> > >> > Am 2021-03-02 22:11, schrieb Saravana Kannan: >> > > I think Patch 1 should fix [4] without [5]. Can you test the series >> > > please? >> > >> > Mh, I'm on latest linux-next (next-20210302) and I've applied patch 3/3 >> > and >> > reverted commit 7007b745a508 ("PCI: layerscape: Convert to >> > builtin_platform_driver()"). I'd assumed that PCIe shouldn't be working, >> > right? But it is. Did I miss something? >> >> You need to revert [5]. > > My bad. You did revert it. Ah... I wonder if it was due to > fw_devlink.strict that I added. To break PCI again, also set > fw_devlink.strict=1 in the kernel command line. Indeed, adding fw_devlink.strict=1 will break PCI again. But if I then apply 1/3 and 2/3 again, PCI is still broken. Just to be clear: I'm keeping the fw_devlink.strict=1 parameter. -michael