From: Andres Salomon <dilinger@queued.net>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: devicetree-discuss@lists.ozlabs.org,
Daniel Drake <dsd@laptop.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH 3/4] of/flattree: minor cleanups
Date: Thu, 17 Mar 2011 17:32:35 -0700 [thread overview]
Message-ID: <1300408356-15253-4-git-send-email-dilinger@queued.net> (raw)
In-Reply-To: <1300408356-15253-1-git-send-email-dilinger@queued.net>
- static-ize some functions
- add some additional comments
Signed-off-by: Andres Salomon <dilinger@queued.net>
---
drivers/of/fdt.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c
index af824e7..c9db49c 100644
--- a/drivers/of/fdt.c
+++ b/drivers/of/fdt.c
@@ -139,12 +139,13 @@ static void *unflatten_dt_alloc(unsigned long *mem, unsigned long size,
/**
* unflatten_dt_node - Alloc and populate a device_node from the flat tree
* @blob: The parent device tree blob
+ * @mem: Memory chunk to use for allocating device nodes and properties
* @p: pointer to node in flat tree
* @dad: Parent struct device_node
* @allnextpp: pointer to ->allnext from last allocated device_node
* @fpsize: Size of the node path up at the current depth.
*/
-unsigned long unflatten_dt_node(struct boot_param_header *blob,
+static unsigned long unflatten_dt_node(struct boot_param_header *blob,
unsigned long mem,
unsigned long *p,
struct device_node *dad,
@@ -230,6 +231,7 @@ unsigned long unflatten_dt_node(struct boot_param_header *blob,
}
kref_init(&np->kref);
}
+ /* process properties */
while (1) {
u32 sz, noff;
char *pname;
@@ -351,7 +353,7 @@ unsigned long unflatten_dt_node(struct boot_param_header *blob,
* @dt_alloc: An allocator that provides a virtual address to memory
* for the resulting tree
*/
-void __unflatten_device_tree(struct boot_param_header *blob,
+static void __unflatten_device_tree(struct boot_param_header *blob,
struct device_node **mynodes,
void * (*dt_alloc)(u64 size, u64 align))
{
--
1.7.2.3
next prev parent reply other threads:[~2011-03-18 0:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-18 0:32 [PATCH 0/4] switch DT creation to using of_attach_node (v2) Andres Salomon
2011-03-18 0:32 ` [PATCH 1/4] of: rework of_attach_node, removing CONFIG_OF_DYNAMIC Andres Salomon
2011-04-08 16:52 ` Grant Likely
2011-03-18 0:32 ` [PATCH 2/4] of/promtree: switch to building the DT using of_attach_node Andres Salomon
2011-03-18 0:32 ` Andres Salomon [this message]
2011-03-23 20:35 ` [PATCH 3/4] of/flattree: minor cleanups Grant Likely
2011-03-18 0:32 ` [PATCH 4/4] of/flattree: use of_attach_node to build tree Andres Salomon
2011-03-18 5:45 ` [PATCH 0/4] switch DT creation to using of_attach_node (v2) Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1300408356-15253-4-git-send-email-dilinger@queued.net \
--to=dilinger@queued.net \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=dsd@laptop.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).