linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Maxim Levitsky <maximlevitsky@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>,
	FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
	linux-kernel@vger.kernel.org, oakad@yahoo.com
Subject: Re: [PATH 0/4] Memstick patches for 2.6.39
Date: Sun, 20 Mar 2011 13:42:51 +0200	[thread overview]
Message-ID: <1300621371.15768.11.camel@maxim-laptop> (raw)
In-Reply-To: <20110319234701.0eab3744.akpm@linux-foundation.org>

On Sat, 2011-03-19 at 23:47 -0700, Andrew Morton wrote:
> On Sun, 20 Mar 2011 05:09:05 +0200 Maxim Levitsky <maximlevitsky@gmail.com> wrote:
> 
> > On Tue, 2011-03-15 at 14:04 -0700, Andrew Morton wrote:
> > > On Tue, 15 Mar 2011 22:00:10 +0200
> > > Maxim Levitsky <maximlevitsky@gmail.com> wrote:
> > > 
> > > > On Sat, 2011-03-12 at 18:23 +0200, Maxim Levitsky wrote:
> > > > > On Fri, 2011-03-04 at 06:16 +0200, Maxim Levitsky wrote:
> > > > > > Hi,
> > > > > > 
> > > > > > This is a repost of my patches for 2.6.39 inclusion, which I hope not to
> > > > > > miss this time.
> > > > > > 
> > > > > > I addressed the comments on the scatterlist issues.
> > > > > > 
> > > > > > Andrew, please note that my richoh memstick driver is standalone, unchanged from previos versions
> > > > > > has many users which use the version I posted at ubuntu's Launchpad and happy with it.
> > > > > > Please include it regardless of other patches.
> > > > > > 
> > > > > > The other half of my work is support for legacy memorysticks which consists of 2 patches,
> > > > > > first that adds few functions to scatterlist.c, and the other patch that adds the driver.
> > > > > > Driver is also stable and tested.
> > > > > > 
> > > > > > Best regards,
> > > > > > 	Maxim Levitsky
> > > > > 
> > > > > 
> > > > > Any update?
> > > > 
> > > > Any update?
> > > > 
> > > 
> > > I'm hoping that Alex will soon have time to (re)review these patches.
> > 
> > Andrew Morton, what the current state now?
> > 
> 
> Technical discussion is ongoing.  James has described what appears to
> be the architecturally preferred way of implementing this and there is
> as yet no followup to his suggestion.
> 

But I will at least see my r592 driver in kernel?
It doesn't depend on ether ms legacy driver nor on changes in
scatterlist.c

Also, I don't have much time now to improve the ms_block driver till
this summer (studying).
The driver works. Yes it has a flaw in regard to scatterlist processing,
because I didn't find a better way to deal with this monster, but I will
fix that later. I am not the kind of guy that runs away after a merge.
It would be nice to just see my code in kernel, code I wrote more that a
year ago.

This flaw is purely theoretical. Driver does work.

One of the ways to fix this is just use plain good kernel pointers.
Yes that means bouncing of high mem, but like they say "to hell with
that". The driver deals with legacy, and quite slow devices, so there
won't be any performance difference.
Besides, my other driver for that card reader, for xD portion, does
precisely that (more correctly common code in FTL frontend, the
mtd_blkdev.c does that) and the end result is quite good.


So, I am waiting for a word from you,


-- 
Thanks in advance,
Best regards,
        Maxim Levitsky

Visit my blog: http://maximlevitsky.wordpress.com
Warning: Above blog contains rants.


  reply	other threads:[~2011-03-20 11:42 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-04  4:16 [PATH 0/4] Memstick patches for 2.6.39 Maxim Levitsky
2011-03-04  4:16 ` [PATCH 1/4] scatterlist: new helper functions Maxim Levitsky
2011-03-06  7:29   ` FUJITA Tomonori
2011-03-06 15:14     ` Maxim Levitsky
2011-03-06 21:49       ` FUJITA Tomonori
2011-03-07  2:20         ` Maxim Levitsky
2011-03-09 17:24           ` Maxim Levitsky
2011-03-16  0:44           ` Andrew Morton
2011-03-16  2:35             ` FUJITA Tomonori
2011-03-16  4:18               ` Alex Dubov
2011-03-16  4:55                 ` FUJITA Tomonori
2011-03-17  3:46                   ` Alex Dubov
2011-03-17  3:57                     ` James Bottomley
2011-03-16 22:33                 ` Andrew Morton
2011-03-17  6:41                   ` Alex Dubov
2011-03-17 13:17                     ` Maxim Levitsky
2011-03-18  0:59                     ` FUJITA Tomonori
2011-03-04  4:16 ` [PATCH 2/4] memstick: add support for legacy memorysticks Maxim Levitsky
2011-03-04  4:16 ` [PATCH 3/4] memstick: Add driver for Ricoh R5C592 card reader Maxim Levitsky
2011-03-16  4:25   ` Alex Dubov
2011-03-04  4:16 ` [PATCH 4/4] memstick: add Alex Dubov to MAINTAINERS of the memstick core Maxim Levitsky
2011-03-12 16:23 ` [PATH 0/4] Memstick patches for 2.6.39 Maxim Levitsky
2011-03-15 20:00   ` Maxim Levitsky
2011-03-15 21:04     ` Andrew Morton
2011-03-16  0:25       ` Maxim Levitsky
2011-03-20  3:09       ` Maxim Levitsky
2011-03-20  6:47         ` Andrew Morton
2011-03-20 11:42           ` Maxim Levitsky [this message]
2011-03-22 13:01             ` Maxim Levitsky
2011-03-22 23:21             ` Andrew Morton
2011-03-23  0:59               ` Maxim Levitsky
2011-03-23  3:42                 ` Greg KH
2011-03-23 15:30                   ` Maxim Levitsky
2011-03-24  3:27                     ` Alex Dubov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1300621371.15768.11.camel@maxim-laptop \
    --to=maximlevitsky@gmail.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=akpm@linux-foundation.org \
    --cc=fujita.tomonori@lab.ntt.co.jp \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oakad@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).