From: Jamie Iles <jamie@jamieiles.com>
To: linux-kernel@vger.kernel.org
Cc: linux@arm.linux.org.uk, tglx@linutronix.de,
cbouatmailru@gmail.com, grant.likely@secretlab.ca, arnd@arndb.de,
nico@fluxnic.net, Jamie Iles <jamie@jamieiles.com>
Subject: [PATCHv3 4/7] basic_mmio_gpio: request register regions
Date: Mon, 11 Apr 2011 12:21:51 +0100 [thread overview]
Message-ID: <1302520914-22816-5-git-send-email-jamie@jamieiles.com> (raw)
In-Reply-To: <1302520914-22816-1-git-send-email-jamie@jamieiles.com>
Make sure that we get the register regions with request_mem_region()
before ioremap() to make sure we have exclusive access.
Signed-off-by: Jamie Iles <jamie@jamieiles.com>
Acked-by: Anton Vorontsov <cbouatmailru@gmail.com>
Cc: Grant Likely <grant.likely@secretlab.ca>
---
drivers/gpio/basic_mmio_gpio.c | 16 +++++++++++++---
1 files changed, 13 insertions(+), 3 deletions(-)
diff --git a/drivers/gpio/basic_mmio_gpio.c b/drivers/gpio/basic_mmio_gpio.c
index 2b2d384..90f7f89 100644
--- a/drivers/gpio/basic_mmio_gpio.c
+++ b/drivers/gpio/basic_mmio_gpio.c
@@ -192,6 +192,16 @@ static int bgpio_dir_out(struct gpio_chip *gc, unsigned int gpio, int val)
return 0;
}
+static void __iomem *bgpio_request_and_map(struct device *dev,
+ struct resource *res)
+{
+ if (!devm_request_mem_region(dev, res->start, resource_size(res),
+ res->name ?: "mmio_gpio"))
+ return NULL;
+
+ return devm_ioremap(dev, res->start, resource_size(res));
+}
+
static int bgpio_setup_accessors(struct platform_device *pdev,
struct bgpio_chip *bgc)
{
@@ -258,7 +268,7 @@ static int __devinit bgpio_probe(struct platform_device *pdev)
if (!bgc)
return -ENOMEM;
- bgc->reg_dat = devm_ioremap(dev, res_dat->start, dat_sz);
+ bgc->reg_dat = bgpio_request_and_map(dev, res_dat);
if (!bgc->reg_dat)
return -ENOMEM;
@@ -269,8 +279,8 @@ static int __devinit bgpio_probe(struct platform_device *pdev)
resource_size(res_set) != dat_sz)
return -EINVAL;
- bgc->reg_set = devm_ioremap(dev, res_set->start, dat_sz);
- bgc->reg_clr = devm_ioremap(dev, res_clr->start, dat_sz);
+ bgc->reg_set = bgpio_request_and_map(dev, res_set);
+ bgc->reg_clr = bgpio_request_and_map(dev, res_clr);
if (!bgc->reg_set || !bgc->reg_clr)
return -ENOMEM;
} else if (res_set || res_clr) {
--
1.7.4.2
next prev parent reply other threads:[~2011-04-11 11:22 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-11 11:21 [PATCHv3 0/7] gpio: extend basic_mmio_gpio for different controllers Jamie Iles
2011-04-11 11:21 ` [PATCHv3 1/7] basic_mmio_gpio: remove runtime width/endianness evaluation Jamie Iles
2011-05-03 19:41 ` Grant Likely
2011-04-11 11:21 ` [PATCHv3 2/7] basic_mmio_gpio: convert to platform_{get,set}_drvdata() Jamie Iles
2011-05-03 19:41 ` Grant Likely
2011-04-11 11:21 ` [PATCHv3 3/7] basic_mmio_gpio: allow overriding number of gpio Jamie Iles
2011-05-03 19:41 ` Grant Likely
2011-04-11 11:21 ` Jamie Iles [this message]
2011-05-03 19:41 ` [PATCHv3 4/7] basic_mmio_gpio: request register regions Grant Likely
2011-04-11 11:21 ` [PATCHv3 5/7] basic_mmio_gpio: detect output method at probe time Jamie Iles
2011-04-11 12:05 ` Anton Vorontsov
2011-05-03 19:42 ` Grant Likely
2011-04-11 11:21 ` [PATCHv3 6/7] basic_mmio_gpio: support different input/output registers Jamie Iles
2011-04-11 12:06 ` Anton Vorontsov
2011-05-03 19:42 ` Grant Likely
2011-04-11 11:21 ` [PATCHv3 7/7] basic_mmio_gpio: support direction registers Jamie Iles
2011-05-03 19:42 ` Grant Likely
2011-05-03 21:09 ` [PATCHv3 0/7] gpio: extend basic_mmio_gpio for different controllers Grant Likely
2011-05-03 21:13 ` Grant Likely
2011-05-03 21:36 ` Grant Likely
2011-05-03 21:52 ` Anton Vorontsov
2011-05-03 22:04 ` Jamie Iles
2011-05-03 22:34 ` Anton Vorontsov
2011-05-04 0:00 ` Grant Likely
2011-05-04 10:36 ` Anton Vorontsov
2011-05-04 11:09 ` Jamie Iles
2011-05-04 11:31 ` Anton Vorontsov
2011-05-04 14:37 ` Jamie Iles
2011-05-04 14:43 ` Grant Likely
2011-05-04 14:44 ` Alan Cox
2011-05-04 14:57 ` Jamie Iles
2011-05-04 15:02 ` Anton Vorontsov
2011-05-04 15:04 ` Jamie Iles
2011-05-13 19:37 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1302520914-22816-5-git-send-email-jamie@jamieiles.com \
--to=jamie@jamieiles.com \
--cc=arnd@arndb.de \
--cc=cbouatmailru@gmail.com \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=nico@fluxnic.net \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).