From: Hans Rosenfeld <hans.rosenfeld@amd.com>
To: <hpa@zytor.com>, <mingo@elte.hu>
Cc: <brgerst@gmail.com>, <tglx@linutronix.de>,
<suresh.b.siddha@intel.com>, <eranian@google.com>,
<robert.richter@amd.com>, <Andreas.Herrmann3@amd.com>,
<x86@kernel.org>, <linux-kernel@vger.kernel.org>,
Hans Rosenfeld <hans.rosenfeld@amd.com>
Subject: [PATCH] x86, xsave: fix non-lazy allocation of the xsave area
Date: Wed, 13 Apr 2011 12:58:21 +0200 [thread overview]
Message-ID: <1302692301-695807-1-git-send-email-hans.rosenfeld@amd.com> (raw)
In-Reply-To: <20110407153029.GU13@escobedo.osrc.amd.com>
A single static xsave area just for init is not enough, since there are
more user processes that are directly executed by kernel threads. Use
fpu_alloc(), and SIGKILL the process if that fails.
Signed-off-by: Hans Rosenfeld <hans.rosenfeld@amd.com>
---
arch/x86/include/asm/i387.h | 9 +++------
1 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/arch/x86/include/asm/i387.h b/arch/x86/include/asm/i387.h
index 989c0ac..833b6f1 100644
--- a/arch/x86/include/asm/i387.h
+++ b/arch/x86/include/asm/i387.h
@@ -329,15 +329,12 @@ static inline void fpu_copy(struct fpu *dst, struct fpu *src)
}
extern void fpu_finit(struct fpu *fpu);
-static union thread_xstate __init_xstate, *init_xstate = &__init_xstate;
static inline void fpu_clear(struct fpu *fpu)
{
- if (!fpu_allocated(fpu)) {
- BUG_ON(init_xstate == NULL);
- fpu->state = init_xstate;
- init_xstate = NULL;
- }
+ if (!fpu_allocated(fpu) && fpu_alloc(fpu))
+ do_group_exit(SIGKILL);
+
memset(fpu->state, 0, xstate_size);
fpu_finit(fpu);
set_used_math();
--
1.5.6.5
next prev parent reply other threads:[~2011-04-13 10:58 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-09 19:14 [RFC 0/8] rework of extended state handling, LWP support Hans Rosenfeld
2011-03-09 19:14 ` [RFC 1/8] x86, xsave: cleanup fpu/xsave support Hans Rosenfeld
2011-03-09 19:14 ` [RFC 2/8] x86, xsave: rework " Hans Rosenfeld
2011-03-09 19:14 ` [RFC 3/8] x86, xsave: cleanup fpu/xsave signal frame setup Hans Rosenfeld
2011-03-09 19:14 ` [RFC 4/8] x86, xsave: remove unused code Hans Rosenfeld
2011-03-09 19:14 ` [RFC 5/8] x86, xsave: more cleanups Hans Rosenfeld
2011-03-09 19:15 ` [RFC 6/8] x86, xsave: add support for non-lazy xstates Hans Rosenfeld
2011-03-09 19:15 ` [RFC 7/8] x86, xsave: add kernel support for AMDs Lightweight Profiling (LWP) Hans Rosenfeld
2011-03-09 19:15 ` [RFC 8/8] x86, xsave: remove lazy allocation of xstate area Hans Rosenfeld
2011-03-23 15:27 ` [RFC v2 0/8] x86, xsave: rework of extended state handling, LWP support Hans Rosenfeld
2011-03-23 15:27 ` [RFC v2 1/8] x86, xsave: cleanup fpu/xsave support Hans Rosenfeld
2011-03-23 15:27 ` [RFC v2 2/8] x86, xsave: rework " Hans Rosenfeld
2011-03-23 15:27 ` [RFC v2 3/8] x86, xsave: cleanup fpu/xsave signal frame setup Hans Rosenfeld
2011-03-23 15:27 ` [RFC v2 4/8] x86, xsave: remove unused code Hans Rosenfeld
2011-03-23 15:27 ` [RFC v2 5/8] x86, xsave: more cleanups Hans Rosenfeld
2011-03-23 15:27 ` [RFC v2 6/8] x86, xsave: add support for non-lazy xstates Hans Rosenfeld
2011-03-23 15:27 ` [RFC v2 7/8] x86, xsave: add kernel support for AMDs Lightweight Profiling (LWP) Hans Rosenfeld
2011-03-23 15:27 ` [RFC v2 8/8] x86, xsave: remove lazy allocation of xstate area Hans Rosenfeld
2011-03-24 11:39 ` Brian Gerst
2011-03-29 14:17 ` Hans Rosenfeld
2011-03-29 15:27 ` H. Peter Anvin
2011-03-30 13:11 ` Hans Rosenfeld
2011-04-05 15:50 ` [RFC v3 0/8] x86, xsave: rework of extended state handling, LWP support Hans Rosenfeld
2011-04-07 7:23 ` Ingo Molnar
2011-04-07 15:30 ` Hans Rosenfeld
2011-04-07 16:08 ` [RFC v4 6/8] x86, xsave: add support for non-lazy xstates Hans Rosenfeld
2011-04-07 16:08 ` [RFC v4 8/8] x86, xsave: remove lazy allocation of xstate area Hans Rosenfeld
2011-04-13 10:58 ` Hans Rosenfeld [this message]
2011-04-13 23:21 ` [PATCH] x86, xsave: fix non-lazy allocation of the xsave area H. Peter Anvin
2011-04-15 16:47 ` [PATCH 1/1] " Hans Rosenfeld
2011-05-16 19:10 ` [RFC v3 0/8] x86, xsave: rework of extended state handling, LWP support Hans Rosenfeld
2011-05-17 11:30 ` Ingo Molnar
2011-05-17 15:22 ` Hans Rosenfeld
2011-05-18 11:22 ` Ingo Molnar
2011-05-18 13:51 ` Ingo Molnar
2011-05-18 8:16 ` Joerg Roedel
2011-05-18 10:59 ` Ingo Molnar
2011-05-18 18:02 ` Andreas Herrmann
2011-04-05 15:50 ` [RFC v3 1/8] x86, xsave: cleanup fpu/xsave support Hans Rosenfeld
2011-04-05 15:50 ` [RFC v3 2/8] x86, xsave: rework " Hans Rosenfeld
2011-04-05 15:50 ` [RFC v3 3/8] x86, xsave: cleanup fpu/xsave signal frame setup Hans Rosenfeld
2011-04-05 15:50 ` [RFC v3 4/8] x86, xsave: remove unused code Hans Rosenfeld
2011-04-05 15:50 ` [RFC v3 5/8] x86, xsave: more cleanups Hans Rosenfeld
2011-04-05 15:50 ` [RFC v3 6/8] x86, xsave: add support for non-lazy xstates Hans Rosenfeld
2011-04-05 15:50 ` [RFC v3 7/8] x86, xsave: add kernel support for AMDs Lightweight Profiling (LWP) Hans Rosenfeld
2011-04-06 22:06 ` [tip:x86/xsave] " tip-bot for Hans Rosenfeld
2011-04-05 15:50 ` [RFC v3 8/8] x86, xsave: remove lazy allocation of xstate area Hans Rosenfeld
2011-04-06 22:06 ` [tip:x86/xsave] " tip-bot for Hans Rosenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1302692301-695807-1-git-send-email-hans.rosenfeld@amd.com \
--to=hans.rosenfeld@amd.com \
--cc=Andreas.Herrmann3@amd.com \
--cc=brgerst@gmail.com \
--cc=eranian@google.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=robert.richter@amd.com \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).