LKML Archive on
 help / color / Atom feed
From: Samir Bellabes <>
Cc: Samir Bellabes <>
Subject: [PATCH] [PATCH] remove unused parameters from sched_fork() and wake_up_new_task()
Date: Wed, 11 May 2011 18:18:05 +0200
Message-ID: <> (raw)

sched_fork() and wake_up_new_task() are defined with a parameter
'unsigned long clone_flags', which is unused.
This patch removes the parameters.

Signed-off-by: Samir Bellabes <>
 include/linux/sched.h |    5 ++---
 kernel/fork.c         |    4 ++--
 kernel/sched.c        |    4 ++--
 3 files changed, 6 insertions(+), 7 deletions(-)

diff --git a/include/linux/sched.h b/include/linux/sched.h
index 4ec2c02..fef4a76 100644
--- a/include/linux/sched.h
+++ b/include/linux/sched.h
@@ -2057,14 +2057,13 @@ extern void xtime_update(unsigned long ticks);
 extern int wake_up_state(struct task_struct *tsk, unsigned int state);
 extern int wake_up_process(struct task_struct *tsk);
-extern void wake_up_new_task(struct task_struct *tsk,
-				unsigned long clone_flags);
+extern void wake_up_new_task(struct task_struct *tsk);
 #ifdef CONFIG_SMP
  extern void kick_process(struct task_struct *tsk);
  static inline void kick_process(struct task_struct *tsk) { }
-extern void sched_fork(struct task_struct *p, int clone_flags);
+extern void sched_fork(struct task_struct *p);
 extern void sched_dead(struct task_struct *p);
 extern void proc_caches_init(void);
diff --git a/kernel/fork.c b/kernel/fork.c
index e7548de..7c440fa 100644
--- a/kernel/fork.c
+++ b/kernel/fork.c
@@ -1153,7 +1153,7 @@ static struct task_struct *copy_process(unsigned long clone_flags,
 	/* Perform scheduler related setup. Assign this task to a CPU. */
-	sched_fork(p, clone_flags);
+	sched_fork(p);
 	retval = perf_event_init_task(p);
 	if (retval)
@@ -1464,7 +1464,7 @@ long do_fork(unsigned long clone_flags,
 		p->flags &= ~PF_STARTING;
-		wake_up_new_task(p, clone_flags);
+		wake_up_new_task(p);
 		tracehook_report_clone_complete(trace, regs,
 						clone_flags, nr, p);
diff --git a/kernel/sched.c b/kernel/sched.c
index 4801363..3105b01 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -2626,7 +2626,7 @@ static void __sched_fork(struct task_struct *p)
  * fork()/clone()-time setup:
-void sched_fork(struct task_struct *p, int clone_flags)
+void sched_fork(struct task_struct *p)
 	int cpu = get_cpu();
@@ -2707,7 +2707,7 @@ void sched_fork(struct task_struct *p, int clone_flags)
  * that must be done for every newly created context, then puts the task
  * on the runqueue and wakes it.
-void wake_up_new_task(struct task_struct *p, unsigned long clone_flags)
+void wake_up_new_task(struct task_struct *p)
 	unsigned long flags;
 	struct rq *rq;

             reply index

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-11 16:18 Samir Bellabes [this message]
2011-05-12 13:04 ` [tip:sched/core] sched: Remove " tip-bot for Samir Bellabes

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

LKML Archive on

Archives are clonable:
	git clone --mirror lkml/git/0.git
	git clone --mirror lkml/git/1.git
	git clone --mirror lkml/git/2.git
	git clone --mirror lkml/git/3.git
	git clone --mirror lkml/git/4.git
	git clone --mirror lkml/git/5.git
	git clone --mirror lkml/git/6.git
	git clone --mirror lkml/git/7.git
	git clone --mirror lkml/git/8.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ \
	public-inbox-index lkml

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone