LKML Archive on lore.kernel.org
 help / color / Atom feed
From: Borislav Petkov <bp@amd64.org>
To: "Nick Bowler" <nbowler@elliptictech.com>,
	"Jörg-Volker Peetz" <jvpeetz@web.de>
Cc: Boris Ostrovsky <boris.ostrovsky@amd.com>,
	Andreas Herrmann <andreas.herrmann3@amd.com>,
	Greg Kroah-Hartman <greg@kroah.com>,
	Hans Rosenfeld <hans.rosenfeld@amd.com>, X86-ML <x86@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Borislav Petkov <borislav.petkov@amd.com>,
	Boris Ostrovsky <Boris.Ostrovsky@amd.com>
Subject: [PATCH 2/2] x86, AMD: Fix ARAT feature setting again
Date: Tue, 17 May 2011 14:55:19 +0200
Message-ID: <1305636919-31165-3-git-send-email-bp@amd64.org> (raw)
In-Reply-To: <1305636919-31165-1-git-send-email-bp@amd64.org>

From: Borislav Petkov <borislav.petkov@amd.com>

Trying to enable the local APIC timer on early K8 revisions uncovers
a number of other issues with it, in conjunction with the C1E enter
path on AMD. Fixing those causes much more churn and troubles than the
benefit of using that timer brings so don't enable it on K8 at all,
falling back to the original functionality the kernel had wrt to that.

Reported-and-bisected-by: Nick Bowler <nbowler@elliptictech.com>
Cc: Boris Ostrovsky <Boris.Ostrovsky@amd.com>
Link: http://lkml.kernel.org/r/20110514195741.GA10757@elliptictech.com
Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
---
 arch/x86/kernel/cpu/amd.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kernel/cpu/amd.c b/arch/x86/kernel/cpu/amd.c
index 3532d3b..6f9d1f6 100644
--- a/arch/x86/kernel/cpu/amd.c
+++ b/arch/x86/kernel/cpu/amd.c
@@ -613,7 +613,7 @@ static void __cpuinit init_amd(struct cpuinfo_x86 *c)
 #endif
 
 	/* As a rule processors have APIC timer running in deep C states */
-	if (c->x86 >= 0xf && !cpu_has_amd_erratum(amd_erratum_400))
+	if (c->x86 > 0xf && !cpu_has_amd_erratum(amd_erratum_400))
 		set_cpu_cap(c, X86_FEATURE_ARAT);
 
 	/*
-- 
1.7.4.rc2


  parent reply index

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-17 12:55 [PATCH 0/2] AMD ARAT fixes Borislav Petkov
2011-05-17 12:55 ` [PATCH 1/2] Revert "x86, AMD: Fix APIC timer erratum 400 affecting K8 Rev.A-E processors" Borislav Petkov
2011-05-17 12:55 ` Borislav Petkov [this message]
2011-05-17 13:47   ` [tip:x86/urgent] x86, AMD: Fix ARAT feature setting again tip-bot for Borislav Petkov
2011-05-17 16:38 ` [PATCH 0/2] AMD ARAT fixes Jörg-Volker Peetz
2011-05-17 16:53   ` Borislav Petkov
2011-05-17 17:21     ` Jörg-Volker Peetz
2011-05-17 17:46       ` Borislav Petkov
2011-05-17 17:51         ` Jörg-Volker Peetz
2011-05-17 18:01           ` Borislav Petkov
2011-05-17 22:30 ` Nick Bowler
2011-05-18  6:51   ` Borislav Petkov
2011-05-18 15:50 ` Borislav Petkov
2011-05-20 14:37   ` Chuck Ebbert
2011-05-20 18:10     ` Boris Ostrovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1305636919-31165-3-git-send-email-bp@amd64.org \
    --to=bp@amd64.org \
    --cc=andreas.herrmann3@amd.com \
    --cc=boris.ostrovsky@amd.com \
    --cc=borislav.petkov@amd.com \
    --cc=greg@kroah.com \
    --cc=hans.rosenfeld@amd.com \
    --cc=jvpeetz@web.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nbowler@elliptictech.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

LKML Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
	git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
	git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
	git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
	git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
	git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
	git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git
	git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git
	git clone --mirror https://lore.kernel.org/lkml/8 lkml/git/8.git
	git clone --mirror https://lore.kernel.org/lkml/9 lkml/git/9.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
		linux-kernel@vger.kernel.org
	public-inbox-index lkml

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git