From: Steven Rostedt <rostedt@goodmis.org>
To: Hillf Danton <dhillf@gmail.com>
Cc: Mike Galbraith <efault@gmx.de>,
LKML <linux-kernel@vger.kernel.org>,
Yong Zhang <yong.zhang0@gmail.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH] sched: fix rt_nr_migratory corruption raised in push_rt_task()
Date: Tue, 31 May 2011 11:08:00 -0400 [thread overview]
Message-ID: <1306854480.11899.29.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <BANLkTi=YXK7pCJqei6oz4dzLzHgJC_m=2g@mail.gmail.com>
On Tue, 2011-05-31 at 21:56 +0800, Hillf Danton wrote:
> On Tue, May 31, 2011 at 3:36 PM, Mike Galbraith <efault@gmx.de> wrote:
> > On Mon, 2011-05-30 at 21:39 +0800, Hillf Danton wrote:
> >> When pushing, if a pushable task could not be pushed, it is dequeued with no
> >> updating the rt_nr_migratory element of RT run-queue, then rt_nr_migratory is
> >> corrupted, which is fixed by removing the dequeue operation.
> >
> > Hm. I think you're right that this dequeue_pushable_task() call can be
> > removed, at least I didn't see it's reason for existing. I'd word it a
> > bit differently though, and not return 1 unless we really did push.
> >
>
> Hi Mike
>
> Your message shows what is called professional work, but something lost,
>
> > From: Hillf Danton <dhillf@gmail.com>
> >
> > sched, rt: fix rq->rt.pushable_tasks bug in push_rt_task()
> >
> > Do not call dequeue_pushable_task() when failing to push an eligible
> > task, as it remains pushable, merely not at this particular moment.
> >
> > Signed-off-by: Hillf Danton <dhillf@gmail.com>
>
> Signed-off-by: Mike Galbraith <efault@gmx.de>
>
Yeah, Mike, can you remail this adding your SOB too. You can keep
Hillf's SOB as well, since both of you made changes.
Thanks!
-- Steve
next prev parent reply other threads:[~2011-05-31 15:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-30 13:39 [PATCH] sched: fix rt_nr_migratory corruption raised in push_rt_task() Hillf Danton
2011-05-31 7:36 ` Mike Galbraith
2011-05-31 13:56 ` Hillf Danton
2011-05-31 15:08 ` Steven Rostedt [this message]
2011-06-01 2:14 ` [PATCH] sched, rt: fix rq->rt.pushable_tasks bug " Mike Galbraith
2011-06-01 2:29 ` Mike Galbraith
2011-08-14 16:02 ` [tip:sched/core] sched, rt: Fix " tip-bot for Hillf Danton
2011-06-01 2:21 ` [PATCH] sched: fix rt_nr_migratory corruption raised " Mike Galbraith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1306854480.11899.29.camel@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=dhillf@gmail.com \
--cc=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=yong.zhang0@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).