From: Steven Rostedt <rostedt@goodmis.org>
To: Hillf Danton <dhillf@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Yong Zhang <yong.zhang0@gmail.com>,
Mike Galbraith <efault@gmx.de>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH] sched: remove the next highest_prio in RT scheduling
Date: Sat, 04 Jun 2011 01:06:28 -0400 [thread overview]
Message-ID: <1307163988.31814.11.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <BANLkTikzjVd69XRb6psBm1aYSem126YynA@mail.gmail.com>
On Sat, 2011-06-04 at 12:44 +0800, Hillf Danton wrote:
> Both the next and curr reach same result, or incorrect result, before locking
Not quite. curr could be of higher priority than this rq, but next be of
lower priority. In that case, we still want to skip the rq.
But this patch does simplify things, and I give you credit for that.
I'll have to run some tests to see how much in practice this occurs, and
see if it is worth removing and using your method instead.
-- Steve
> RQ, as the comment says, it is racy. After locking RQ, priority is checked again
> to pull the correct tasks with no running task included. The difference between
> the next and curr before locking RQ is the core of the patch that incorrect
> result could be achieved with no updating the next field.
>
> thanks
> Hillf
next prev parent reply other threads:[~2011-06-04 5:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-28 14:25 [PATCH] sched: remove the next highest_prio in RT scheduling Hillf Danton
2011-05-31 14:40 ` Steven Rostedt
2011-06-04 4:44 ` Hillf Danton
2011-06-04 5:06 ` Steven Rostedt [this message]
2011-06-04 5:11 ` Hillf Danton
2011-06-04 17:34 ` Steven Rostedt
2011-08-14 16:07 ` [tip:sched/core] sched: Use pushable_tasks to determine next highest prio tip-bot for Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1307163988.31814.11.camel@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=dhillf@gmail.com \
--cc=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=yong.zhang0@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).